Page MenuHomePhabricator

[RISCV] Change parseVTypeI function
ClosedPublic

Authored by StephenFan on Feb 6 2021, 11:56 PM.

Details

Summary

Change parseVTypeI function to Make the added vset instruction test cases report more concrete error message.

Diff Detail

Event Timeline

StephenFan created this revision.Feb 6 2021, 11:56 PM
StephenFan requested review of this revision.Feb 6 2021, 11:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2021, 11:56 PM
StephenFan retitled this revision from Correct parseVTypeI function 1. Make the assembler detect the out of range immediate in vsetivli instruction. 2. Make the added vsetvli instrction test cases report more concrete error message. to [RISCV] Change parseVTypeI function.Feb 6 2021, 11:57 PM
StephenFan edited the summary of this revision. (Show Details)Feb 7 2021, 12:44 AM
craig.topper added inline comments.Feb 11 2021, 12:01 PM
llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
1533

Can this be isNot?

1598

!VTypeIElements.empty()

Address craig.topper 's comment

Address @craig.topper 's comments

StephenFan marked 2 inline comments as done.Feb 11 2021, 11:18 PM
This revision is now accepted and ready to land.Feb 11 2021, 11:22 PM
This revision was landed with ongoing or failed builds.Feb 12 2021, 3:39 AM
This revision was automatically updated to reflect the committed changes.