Add all the registers that are currently used by
LLPC: https://github.com/GPUOpen-Drivers/llpc
This only affects disassembly of PAL metadata generated by LLPC and
similar frontends.
Differential D95619
[AMDGPU] Add more PAL metadata register names foad on Jan 28 2021, 7:44 AM. Authored by
Details Add all the registers that are currently used by This only affects disassembly of PAL metadata generated by LLPC and
Diff Detail
Unit Tests Event TimelineComment Actions I couldn't work out what order the existing entries were in, so I added the new ones in alphabetical order at the end. I couldn't find any existing test cases for these names. Comment Actions We have slight problems when it comes to differences between hardware versions. Comment Actions
Luckily LLPC only uses COMPUTE_USER_ACCUM_1 on gfx10+.
I had not noticed that. Comment Actions If these registers keep changing, we probably want to switch between architectures at some point. But it’s easier to look at (slightly off) names than at hex numbers, so LGTM. Comment Actions I am not familiar with graphics side much, but is there any reason to not use COMPUTE_PGM_RSRC* registers from https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h#L130 ? Comment Actions For dumping PAL metadata all we want is the offsets of the registers. AMDHSAKernelDescriptor.h seems to define the fields within some of these registers instead. Obviously it's related, but I don't think there's actually any duplicated information there. |