This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Implement mir parseCustomPseudoSourceValue
ClosedPublic

Authored by sebastian-ne on Jan 15 2021, 5:14 AM.

Details

Summary

Allow parsing generated mir with custom address space tokens.

Diff Detail

Event Timeline

sebastian-ne created this revision.Jan 15 2021, 5:14 AM
sebastian-ne requested review of this revision.Jan 15 2021, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2021, 5:14 AM
arsenm added inline comments.Jan 15 2021, 5:22 PM
llvm/lib/Target/AMDGPU/AMDGPUMIRFormatter.cpp
23

Isn't the point to stop using these meaningless names?

llvm/lib/Target/AMDGPU/AMDGPUMIRFormatter.h
2

Filename copy paste

Isn't the point to stop using these meaningless names?

I don’t know, I just tried to stop and resume compilation with llc and it failed at these tokens.
What would the better way be?

foad added a subscriber: foad.Jan 18 2021, 5:48 AM

Isn't the point to stop using these meaningless names?

I don’t know, I just tried to stop and resume compilation with llc and it failed at these tokens.
What would the better way be?

Implement AMDGPUPseudoSourceValue::printCustom? I see that is already done for AMDGPUGWSResourcePseudoSourceValue but not for the other kinds.

arsenm added inline comments.Jan 18 2021, 10:01 AM
llvm/test/CodeGen/AMDGPU/custom-addrspace.mir
1 ↗(On Diff #317336)

These should have meaningful names. This should also go in test/CodeGen/MIR/AMDGPU and test round tripping

sebastian-ne marked 3 inline comments as done.

Use better names and move test to MIR/AMDGPU.

arsenm accepted this revision.Jan 21 2021, 7:27 AM
arsenm added inline comments.
llvm/test/CodeGen/MIR/AMDGPU/custom-addrspace.ll
3–4

s/address spaces/pseudo source values/

This revision is now accepted and ready to land.Jan 21 2021, 7:27 AM
This revision was landed with ongoing or failed builds.Jan 21 2021, 7:32 AM
This revision was automatically updated to reflect the committed changes.