This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Add lowering for llvm abs intrinsic
ClosedPublic

Authored by david-arm on Jan 6 2021, 1:06 AM.

Details

Summary

Add functionality to permit lowering of the abs and neg intrinsics
using the passthru variants.

Diff Detail

Event Timeline

david-arm created this revision.Jan 6 2021, 1:06 AM
david-arm requested review of this revision.Jan 6 2021, 1:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 1:06 AM
paulwalker-arm accepted this revision.Jan 6 2021, 3:12 AM

Do you plan to add support for fixed length vectors?

llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
206–207

Please better align the new code.

This revision is now accepted and ready to land.Jan 6 2021, 3:12 AM

Hi @paulwalker-arm, I can add support for fixed length vectors in this patch. It's no trouble really. Aren't you supposed to be on holiday btw? 😉 Bored of The Witcher?

I'm just keeping things ticking over. It doesn't have to be this patch, I just did wanted to know if it's something I can take off my TODO list. If you're support eager then FABS also requires fixed length support :)

david-arm updated this revision to Diff 314878.Jan 6 2021, 6:23 AM
  • Added support for using SVE with fixed length vectors.
paulwalker-arm accepted this revision.EditedJan 7 2021, 2:00 AM

Thanks @david-arm . FYI the CHECK-DAGs within sve-fixed-length-int-arith.ll don't need to be DAGs but I'm going to restructure these tests anyway so there's no point changing them.

This revision was automatically updated to reflect the committed changes.