This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] NFC: rename SPIR-V conversion files for consistency
ClosedPublic

Authored by antiagainst on Dec 17 2020, 1:01 PM.

Details

Summary

This commit renames various SPIR-V related conversion files for
consistency. It drops the "Convert" prefix to various files and
fixes various comment headers.

Depends On D93488

Diff Detail

Event Timeline

antiagainst created this revision.Dec 17 2020, 1:01 PM
antiagainst requested review of this revision.Dec 17 2020, 1:01 PM

Fix CMake dependency

Harbormaster completed remote builds in B82855: Diff 312597.
hanchung accepted this revision.Dec 21 2020, 6:52 AM
hanchung added inline comments.
mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVMPass.h
38

Remove the trailing _.

mlir/include/mlir/Conversion/VectorToSPIRV/VectorToSPIRV.h
13–14

Remove the trailing _.

mlir/include/mlir/Conversion/VectorToSPIRV/VectorToSPIRVPass.h
13–14

ditto

This revision is now accepted and ready to land.Dec 21 2020, 6:52 AM
ThomasRaoux accepted this revision.Dec 21 2020, 9:13 AM
This revision was landed with ongoing or failed builds.Dec 23 2020, 11:37 AM
This revision was automatically updated to reflect the committed changes.
antiagainst marked 3 inline comments as done.Dec 23 2020, 11:37 AM