Page MenuHomePhabricator

bgraur (Bogdan Graur)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2020, 8:52 AM (105 w, 3 d)

Recent Activity

Fri, Sep 23

bgraur added a comment to D119661: [LV] Support chained phis as incoming values for first-order recurs..

Heads-up: we have found this revision to be the culprit for an LTO compilation crash.

Fri, Sep 23, 8:17 AM · Restricted Project, Restricted Project

Aug 4 2022

bgraur updated subscribers of D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads.

@tstellar FYI the clang crash report from @joanahalili and the new compilation errors report from @asmok-g, both introduced by this patch.
Is a revert warranted here?

Aug 4 2022, 1:33 AM · Restricted Project, Restricted Project, Restricted Project
bgraur added a comment to D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads.

@SimplyDanny given the reports from @joanahalili and @asmok-g are you considering a revert for this patch?

Aug 4 2022, 1:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2022

bgraur added a comment to D128146: [libc++] Use uninitialized algorithms for vector.

Hi folks,

Jul 22 2022, 8:52 AM · Restricted Project, Restricted Project

Jul 20 2022

bgraur added a comment to D130124: [libc++][ranges] fix `std::search_n` incorrect `static_assert`.

Thanks a lot for the quick fix!!

Jul 20 2022, 12:25 AM · Restricted Project, Restricted Project

Jul 19 2022

bgraur added a comment to D124079: [libc++] Implement ranges::find_end, ranges::search{, _n}.

@philnik considering this commit breaks std::search_n() could you please revert?

Jul 19 2022, 1:30 AM · Restricted Project, Restricted Project
bgraur added a comment to D124079: [libc++] Implement ranges::find_end, ranges::search{, _n}.

This commit breaks std::search_n().

Jul 19 2022, 1:02 AM · Restricted Project, Restricted Project

Feb 25 2022

bgraur added a comment to D110322: [ConstantFolding] Fold constrained compare intrinsics.

This commit causes clang to crash when compiling the attached reproducer with the following compilation command:

Feb 25 2022, 2:04 PM · Restricted Project

Feb 18 2022

bgraur added a comment to D119855: [SLP]Fix vectorization of the alternate cmp instruction with swapped predicates..

I can confirm the clang crash is fixed with the updated patch.
Thanks for fixing Alexey!

Feb 18 2022, 12:51 AM · Restricted Project

Feb 17 2022

bgraur added a comment to D119855: [SLP]Fix vectorization of the alternate cmp instruction with swapped predicates..

Since we had so many issues related to the initial patch (https://reviews.llvm.org/D115955), would you please consider reverting that and work on the fix without the stress of adding new issues?

Feb 17 2022, 8:23 AM · Restricted Project
bgraur added a comment to D119855: [SLP]Fix vectorization of the alternate cmp instruction with swapped predicates..

Please find attached the reproducer for the crash.

Feb 17 2022, 8:19 AM · Restricted Project
bgraur added a comment to D119855: [SLP]Fix vectorization of the alternate cmp instruction with swapped predicates..

Here's a stack of the crash:

Feb 17 2022, 5:14 AM · Restricted Project
bgraur added a comment to D119855: [SLP]Fix vectorization of the alternate cmp instruction with swapped predicates..

I was trying to confirm that this patch fixes a mis-compile and it seems clang crashes with this patched in (does not crash without the patch).

Feb 17 2022, 5:11 AM · Restricted Project

Dec 27 2021

bgraur committed rGba89c6d50569: Fix forward for "signed version of createExpression" (authored by antondaubert).
Fix forward for "signed version of createExpression"
Dec 27 2021, 4:53 AM
bgraur closed D116301: Fix forward for "signed version of createExpression".
Dec 27 2021, 4:53 AM · Restricted Project
bgraur accepted D116301: Fix forward for "signed version of createExpression".
Dec 27 2021, 2:51 AM · Restricted Project

Dec 10 2021

bgraur added a reverting change for rG847a6807332b: X86InstrInfo: Support immediates that are +1/-1 different in…: rGea81cea8163a: Revert "X86InstrInfo: Support immediates that are +1/-1 different in….
Dec 10 2021, 2:02 PM
bgraur committed rGea81cea8163a: Revert "X86InstrInfo: Support immediates that are +1/-1 different in… (authored by bgraur).
Revert "X86InstrInfo: Support immediates that are +1/-1 different in…
Dec 10 2021, 2:02 PM
bgraur added a reverting change for D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr: rGea81cea8163a: Revert "X86InstrInfo: Support immediates that are +1/-1 different in….
Dec 10 2021, 2:02 PM · Restricted Project
bgraur closed D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr".
Dec 10 2021, 2:01 PM · Restricted Project
bgraur added a comment to D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr.

An LGTM on the revert would be greatly appreciated.

Dec 10 2021, 10:33 AM · Restricted Project
bgraur added a comment to D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr.

Thanks! Created a revert here: https://reviews.llvm.org/D115528

Dec 10 2021, 8:25 AM · Restricted Project
bgraur added reviewers for D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr": foad, xbolva00, RKSimon, lebedev.ri.
Dec 10 2021, 8:18 AM · Restricted Project
bgraur added a reverting change for rG847a6807332b: X86InstrInfo: Support immediates that are +1/-1 different in…: D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr".
Dec 10 2021, 8:13 AM
bgraur requested review of D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr".
Dec 10 2021, 8:13 AM · Restricted Project
bgraur added a reverting change for D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr: D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr".
Dec 10 2021, 8:13 AM · Restricted Project
bgraur added a comment to D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr.

We have root caused to this revision a mis-compile affecting AMD Rome machines.
I have attached a reproducer program that shows the problem when compiled with -O2 or -O3.

Please revert this change until you have a chance to look at the problem.

NOTE: the repro uses the abseil library that can be found at https://github.com/abseil/abseil-cpp. The reproducer might probably be reduced more (if needed) but it would be great if you could revert early.

Reproducer:

Please post standalone reproducer, one that does not require guessing versions of external dependecies,
and the actual reproduction steps, as in the actual complete compilation and run command.

Dec 10 2021, 6:18 AM · Restricted Project

Dec 9 2021

bgraur added a comment to D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr.

We have root caused to this revision a mis-compile affecting AMD Rome machines.
I have attached a reproducer program that shows the problem when compiled with -O2 or -O3.

Dec 9 2021, 7:58 AM · Restricted Project

Nov 19 2021

bgraur added a comment to rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when….

Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing an almost 20x increase in compilation times for some files (from 42s to 728s).

Nov 19 2021, 9:35 AM

Nov 8 2021

bgraur added a comment to D113027: [libcxx] Remove nonstandard _FilesystemClock::{to,from}_time_t.

This revision removes the only available methods to convert std::chrono::file_time_type to/from anything else.

Nov 8 2021, 6:38 AM · Restricted Project

Oct 15 2021

bgraur committed rG6a89fefd13cd: Adds //mlir:GPUTransforms dependency to //llvm:MC as the former includes (authored by bgraur).
Adds //mlir:GPUTransforms dependency to //llvm:MC as the former includes
Oct 15 2021, 4:46 AM
bgraur closed D111876: Adds //mlir:GPUTransforms dependency to //llvm:MC as the former includes headers from the latter..
Oct 15 2021, 4:46 AM · Restricted Project
bgraur requested review of D111876: Adds //mlir:GPUTransforms dependency to //llvm:MC as the former includes headers from the latter..
Oct 15 2021, 4:21 AM · Restricted Project

Jul 15 2021

bgraur committed rG442123cada4c: Fixes memory sanitizer 'use-of-uninitialized-value' diagnostic. (authored by bgraur).
Fixes memory sanitizer 'use-of-uninitialized-value' diagnostic.
Jul 15 2021, 2:40 AM
bgraur closed D106047: Fixes memory sanitizer 'use-of-uninitialized-value' diagnostic..
Jul 15 2021, 2:40 AM · Restricted Project
bgraur added a reviewer for D106047: Fixes memory sanitizer 'use-of-uninitialized-value' diagnostic.: bkramer.
Jul 15 2021, 2:17 AM · Restricted Project
bgraur requested review of D106047: Fixes memory sanitizer 'use-of-uninitialized-value' diagnostic..
Jul 15 2021, 2:17 AM · Restricted Project

Jul 13 2021

bgraur added reviewers for D105894: [libc++] NFCI: Restore code duplication in wrap_iter, with test.: Quuxplusone, ldionne.
Jul 13 2021, 8:09 AM · Restricted Project
bgraur added a comment to D105894: [libc++] NFCI: Restore code duplication in wrap_iter, with test..

The reverted commit introduced an error when std::rel_ops are used.
Here's a small reproducer:

Jul 13 2021, 8:08 AM · Restricted Project
bgraur added a reverting change for rG7756216547e5: [libc++] NFCI: Remove code duplication and obsolete declarations in wrap_iter: D105894: [libc++] NFCI: Restore code duplication in wrap_iter, with test..
Jul 13 2021, 8:07 AM
bgraur added a reverting change for D105040: [libc++] NFCI: Remove code duplication and obsolete declarations in wrap_iter: D105894: [libc++] NFCI: Restore code duplication in wrap_iter, with test..
Jul 13 2021, 8:07 AM · Restricted Project
bgraur requested review of D105894: [libc++] NFCI: Restore code duplication in wrap_iter, with test..
Jul 13 2021, 8:07 AM · Restricted Project
bgraur accepted D105887: Renames google_benchmark BUILD files to BUILD.bazel..

Just curious -- why is that needed? Is it not possible to make this change upstream? Otherwise, we'll have to do the same thing again when we update Google Benchmark next.

Jul 13 2021, 7:55 AM · Restricted Project
bgraur added a reviewer for D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.: alexfh.
Jul 13 2021, 6:34 AM · Restricted Project
bgraur added a reviewer for D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.: bkramer.
Jul 13 2021, 6:08 AM · Restricted Project
bgraur retitled D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning. from Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning. to [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning..
Jul 13 2021, 6:06 AM · Restricted Project
bgraur requested review of D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning..
Jul 13 2021, 6:04 AM · Restricted Project
bgraur requested review of D105887: Renames google_benchmark BUILD files to BUILD.bazel..
Jul 13 2021, 4:15 AM · Restricted Project

Jul 10 2021

bgraur added a comment to D105040: [libc++] NFCI: Remove code duplication and obsolete declarations in wrap_iter.

Hi Louis,

Jul 10 2021, 2:33 AM · Restricted Project

Apr 14 2021

bgraur requested review of D100451: [NFC] Fix unused variable warning..
Apr 14 2021, 12:33 AM · Restricted Project
bgraur requested review of D100449: [NFC] Fix unused warning..
Apr 14 2021, 12:04 AM · Restricted Project

Dec 31 2020

bgraur added a comment to D93957: Revert "[ThinLTO][test] Add visibility related tests".

Not sure how the build bots are configured.

Dec 31 2020, 10:18 AM · Restricted Project
bgraur added a comment to D93957: Revert "[ThinLTO][test] Add visibility related tests".

The descritption is: "Both newly added tests fail in Release."

Dec 31 2020, 10:06 AM · Restricted Project
bgraur added a comment to D93957: Revert "[ThinLTO][test] Add visibility related tests".

Ideally, this roll-forward should also have included this fix.
The test failure was 100% reproducible.

Dec 31 2020, 9:58 AM · Restricted Project
bgraur updated the summary of D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:39 AM · Restricted Project, Restricted Project
bgraur updated the summary of D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:38 AM · Restricted Project, Restricted Project
bgraur added a reverting change for rG52aa4e210744: [ThinLTO][test] Add visibility related tests: D93957: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:36 AM
bgraur requested review of D93957: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:36 AM · Restricted Project
bgraur added a reverting change for D92899: [ThinLTO][test] Add visibility related tests: D93957: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:36 AM · Restricted Project
bgraur added a reverting change for rG6f1503d59854: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:32 AM
bgraur added a reverting change for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:32 AM · Restricted Project, Restricted Project
bgraur requested review of D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:32 AM · Restricted Project, Restricted Project

Dec 30 2020

bgraur requested review of D93944: Fixes warning 'enumeration value not handled in switch'..
Dec 30 2020, 6:34 AM · Restricted Project

Dec 29 2020

bgraur abandoned D93897: Revert "[mlir][spirv] NFC: rename SPIR-V conversion files for consistency".
Dec 29 2020, 7:55 AM · Restricted Project
bgraur abandoned D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".

Roman fixed forward the cause of the infinite loop.
This revert is no longer necessary.

Dec 29 2020, 5:12 AM · Restricted Project
bgraur abandoned D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".

This is not the actual culprit for the TensorFlow test suite failure.
Sorry for the noise!

Dec 29 2020, 5:09 AM · Restricted Project
bgraur updated the summary of D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
Dec 29 2020, 3:49 AM · Restricted Project
bgraur updated the diff for D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
  1. Updating D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns" #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
Dec 29 2020, 3:45 AM · Restricted Project
bgraur updated the summary of D93897: Revert "[mlir][spirv] NFC: rename SPIR-V conversion files for consistency".
Dec 29 2020, 3:42 AM · Restricted Project
bgraur added a reverting change for D93489: [mlir][spirv] NFC: rename SPIR-V conversion files for consistency: D93897: Revert "[mlir][spirv] NFC: rename SPIR-V conversion files for consistency".
Dec 29 2020, 3:36 AM · Restricted Project
bgraur added a reverting change for rG930c74f12d79: [mlir][spirv] NFC: rename SPIR-V conversion files for consistency: D93897: Revert "[mlir][spirv] NFC: rename SPIR-V conversion files for consistency".
Dec 29 2020, 3:36 AM
bgraur requested review of D93897: Revert "[mlir][spirv] NFC: rename SPIR-V conversion files for consistency".
Dec 29 2020, 3:36 AM · Restricted Project
bgraur added a reverting change for rGa16fbff17d32: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns: D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
Dec 29 2020, 3:34 AM
bgraur requested review of D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
Dec 29 2020, 3:34 AM · Restricted Project
bgraur added a reverting change for D93488: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns: D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
Dec 29 2020, 3:34 AM · Restricted Project

Dec 28 2020

bgraur added a comment to D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".

How about submitting this revert and you work on the fix separately?
If another problem is added with the fix reverting will be harder.

Dec 28 2020, 8:17 AM · Restricted Project
bgraur added a comment to D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".

Here's a small repro:

Dec 28 2020, 7:44 AM · Restricted Project
bgraur added a comment to D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".

@lebedev.ri: I'll need some time to localize and minimize a test for this.
The infinite loop occurs while compiling an internal source file @Google while validating the upstream.

Dec 28 2020, 5:33 AM · Restricted Project
bgraur added a reverting change for rGd9ebaeeb468d: [InstCombine] Hoist xor-by-constant from xor-by-value: D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".
Dec 28 2020, 5:13 AM
bgraur requested review of D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".
Dec 28 2020, 5:13 AM · Restricted Project

Sep 17 2020

bgraur updated the summary of D87838: [amdgpu] Compilation fix for Release.
Sep 17 2020, 9:06 AM · Restricted Project
bgraur added a reviewer for D87838: [amdgpu] Compilation fix for Release: bkramer.
Sep 17 2020, 9:03 AM · Restricted Project
bgraur updated subscribers of D87838: [amdgpu] Compilation fix for Release.
Sep 17 2020, 9:01 AM · Restricted Project
bgraur requested review of D87838: [amdgpu] Compilation fix for Release.
Sep 17 2020, 8:58 AM · Restricted Project