- User Since
- Sep 17 2020, 8:52 AM (168 w, 5 h)
Oct 5 2023
Sep 21 2023
We found another issue where the compiler enters an infinite loop at this revision.
The infinite loop reproduces up until revision 7db87a66b0206af027724fc1704e5e5ce7772a45 where the compiler exits with error:
Sep 20 2023
Just tried the patch and it fixes our issue! Waiting unpatiantly for you to submit the fix forward!
Is there something else above, like assertion message? It would really help more rather than the rest of the stack trace
Sorry I cut the first few lines! Here's the complete stack trace:
Heads-up: this revision is causing a crash in the LTO compiler backend.
Sep 7 2023
@khei4 the last commit is causing again lots of false positive for tests executed under asan.
Aug 9 2023
Aug 8 2023
Heads-up: this is likely causing a miscompile. We're working on a reproducer.
Jul 12 2023
Thanks for the quick fix @arsenm !
Jul 10 2023
@arsenm it looks like calling std::frexp(long double, int) is changing some global state as floating point operations following it start to produce NaNs.
Jul 5 2023
@arsenm we bisected an eigen3 C++ test failure to clang: Use new frexp intrinsic for builtins and add f16 version which got reverted in 0c545a441285a73e00b859dd52f1a85cb9eeeefc and then reapplied in this commit (b15bf305ca3e9ce63aaef7247d32fb3a75174531).
Jun 6 2023
@Allen I got to a repro that requires a headers and two cc files.
Jun 5 2023
@Allen would you be so kind to revert the patch while we're working on the reproducer (might take some time)?
Jun 4 2023
@Allen the latest patch is again causing a similar miscompile as the previous one I reported.
May 15 2023
@Allen this last patch is causing a miscompile again.
May 12 2023
Apr 26 2023
Apr 25 2023
We see the same compilation error as the one reported by @sbc100 in several other C libraries.
Apr 6 2023
Mar 17 2023
What's the resolution here? Can we revert this and continue the discussions independently?
We can always re-land this change if the conclusion is that the approach here is the one that we want.
Mar 10 2023
We've found another clang crasher caused by this change.
Mar 1 2023
@Allen test unittests/ProfileData/ProfileDataTests fails when built with optimisations level -O1 with clang including this patch.
Feb 10 2023
The correct way to using a custom built libc++ is documented here: https://libcxx.llvm.org/UsingLibcxx.html#using-a-custom-built-libc
I tried myself to reproduce the miscompile building clang from the LLVM source tree using the cmake method and found out that it is important to use the standard library headers from the LLVM sources and not the system headers which may be an older version.
Feb 8 2023
Thanks a lot for reverting!
Feb 7 2023
Heads-up: this patch is producing miscompiles in our code.
We have verified the code is correct and the test passes without this patch and crashes with it.
Jan 31 2023
We're seeing a lot of fallout from this patch and they all look related to the ODR violations that seem to be intentionally added here: both the patch description and the comment for the __exception_guard mention explicitly that combinations of code compiled with exceptions and without exceptions are common.
Dec 20 2022
Hi Roman, this revision was identified as the culprit for a miscompile in another part of the code than what @alexfh was checking.
It would be great if you could revert this patch while waiting for a reproducer. What do you think?
Oct 25 2022
Thanks a lot Alina!
Oct 17 2022
Heads-up: a root cause is pointing to this patch for a miscompile that leads to an infinite loop in one of our tests.
Working on a reproducer.
Oct 14 2022
Sep 23 2022
Heads-up: we have found this revision to be the culprit for an LTO compilation crash.
Aug 4 2022
Jul 22 2022
Jul 20 2022
Thanks a lot for the quick fix!!
Jul 19 2022
@philnik considering this commit breaks std::search_n() could you please revert?
This commit breaks std::search_n().
Feb 25 2022
This commit causes clang to crash when compiling the attached reproducer with the following compilation command:
Feb 18 2022
I can confirm the clang crash is fixed with the updated patch.
Thanks for fixing Alexey!
Feb 17 2022
Since we had so many issues related to the initial patch (https://reviews.llvm.org/D115955), would you please consider reverting that and work on the fix without the stress of adding new issues?
Please find attached the reproducer for the crash.
Here's a stack of the crash:
I was trying to confirm that this patch fixes a mis-compile and it seems clang crashes with this patched in (does not crash without the patch).
Dec 27 2021
Dec 10 2021
An LGTM on the revert would be greatly appreciated.
Thanks! Created a revert here: https://reviews.llvm.org/D115528
Dec 9 2021
We have root caused to this revision a mis-compile affecting AMD Rome machines.
I have attached a reproducer program that shows the problem when compiled with -O2 or -O3.
Nov 19 2021
Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing an almost 20x increase in compilation times for some files (from 42s to 728s).
Nov 8 2021
This revision removes the only available methods to convert std::chrono::file_time_type to/from anything else.
Oct 15 2021
Jul 15 2021
Jul 13 2021
The reverted commit introduced an error when std::rel_ops are used.
Here's a small reproducer:
Jul 10 2021
Apr 14 2021
Dec 31 2020
Not sure how the build bots are configured.
The descritption is: "Both newly added tests fail in Release."
Ideally, this roll-forward should also have included this fix.
The test failure was 100% reproducible.