- User Since
- Sep 17 2020, 8:52 AM (105 w, 3 d)
Fri, Sep 23
Heads-up: we have found this revision to be the culprit for an LTO compilation crash.
Aug 4 2022
Jul 22 2022
Jul 20 2022
Thanks a lot for the quick fix!!
Jul 19 2022
@philnik considering this commit breaks std::search_n() could you please revert?
This commit breaks std::search_n().
Feb 25 2022
This commit causes clang to crash when compiling the attached reproducer with the following compilation command:
Feb 18 2022
I can confirm the clang crash is fixed with the updated patch.
Thanks for fixing Alexey!
Feb 17 2022
Since we had so many issues related to the initial patch (https://reviews.llvm.org/D115955), would you please consider reverting that and work on the fix without the stress of adding new issues?
Please find attached the reproducer for the crash.
Here's a stack of the crash:
I was trying to confirm that this patch fixes a mis-compile and it seems clang crashes with this patched in (does not crash without the patch).
Dec 27 2021
Dec 10 2021
An LGTM on the revert would be greatly appreciated.
Thanks! Created a revert here: https://reviews.llvm.org/D115528
Dec 9 2021
We have root caused to this revision a mis-compile affecting AMD Rome machines.
I have attached a reproducer program that shows the problem when compiled with -O2 or -O3.
Nov 19 2021
Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing an almost 20x increase in compilation times for some files (from 42s to 728s).
Nov 8 2021
This revision removes the only available methods to convert std::chrono::file_time_type to/from anything else.
Oct 15 2021
Jul 15 2021
Jul 13 2021
The reverted commit introduced an error when std::rel_ops are used.
Here's a small reproducer:
Jul 10 2021
Apr 14 2021
Dec 31 2020
Not sure how the build bots are configured.
The descritption is: "Both newly added tests fail in Release."
Ideally, this roll-forward should also have included this fix.
The test failure was 100% reproducible.
Dec 30 2020
Dec 29 2020
Roman fixed forward the cause of the infinite loop.
This revert is no longer necessary.
This is not the actual culprit for the TensorFlow test suite failure.
Sorry for the noise!
- Updating D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns" #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Dec 28 2020
How about submitting this revert and you work on the fix separately?
If another problem is added with the fix reverting will be harder.
Here's a small repro:
@lebedev.ri: I'll need some time to localize and minimize a test for this.
The infinite loop occurs while compiling an internal source file @Google while validating the upstream.