Details
Diff Detail
Event Timeline
| llvm/test/CodeGen/AArch64/sve-masked-scatter-legalise.ll | ||
|---|---|---|
| 28–36 | Do we need a similar test for gather in test/CodeGen/AArch64/sve-masked-gather-legalize.ll? I also noticed these test files differ between American/British spelling of legalize/legalise in the filename, can this be renamed to use legalize? | |
| llvm/test/CodeGen/AArch64/sve-masked-scatter-legalise.ll | ||
|---|---|---|
| 28–36 | +1 for the gather-legalize.ll tests. | |
| llvm/test/CodeGen/AArch64/sve-masked-scatter-legalise.ll | ||
|---|---|---|
| 28–36 | Hi @c-rhodes, I wonder if it's better to do the renaming in a different patch because @kmclaughlin has made changes in this file too and it makes the diff a bit harder to read? Any new files created can be with the American spelling. | |
| llvm/test/CodeGen/AArch64/sve-masked-scatter-legalise.ll | ||
|---|---|---|
| 28–36 |
Sure, I think it's fine to push an NFC patch with that single change straight to main. | |
| llvm/test/CodeGen/AArch64/sve-masked-scatter-legalise.ll | ||
|---|---|---|
| 28–36 | Hi @c-rhodes & @david-arm, I tried adding more tests to sve-masked-gather-legalize.ll for floating point after your comments and ran into some legalisation issues when the result of the gather needs to be split. This was for all floating-point types, not just bfloat so I think this should be addressed separately to this patch. | |
Do we need a similar test for gather in test/CodeGen/AArch64/sve-masked-gather-legalize.ll? I also noticed these test files differ between American/British spelling of legalize/legalise in the filename, can this be renamed to use legalize?