Page MenuHomePhabricator

[lib/Object, tools] - Make ELFObjectFile::getELFFile return reference.
ClosedPublic

Authored by grimar on Dec 3 2020, 2:54 AM.

Diff Detail

Event Timeline

grimar created this revision.Dec 3 2020, 2:54 AM
grimar requested review of this revision.Dec 3 2020, 2:54 AM
MaskRay accepted this revision.Dec 3 2020, 10:35 PM

Looks great!

This revision is now accepted and ready to land.Dec 3 2020, 10:35 PM
zhuhan0 added a subscriber: zhuhan0.Dec 4 2020, 3:10 PM

Hello, this seems to break the build. Error here http://lab.llvm.org:8011/#/builders/16/builds/2910/steps/5/logs/stdio. Line 46 of llvm/tools/llvm-profgen/ProfiledBinary.cpp should now take a reference instead of pointer.

Sorry nvm, this is already fixed.