Page MenuHomePhabricator

zhuhan0 (Han Zhu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2020, 11:40 AM (37 w, 4 d)

Recent Activity

Jun 24 2020

zhuhan0 added a comment to D82516: [openmp] Use config.test_extra_flags in archer and multiplex tests.

Thanks @jdoerfert! I don't yet have commit access. Could you commit this for me?

Jun 24 2020, 10:45 PM · Restricted Project
zhuhan0 updated the summary of D82516: [openmp] Use config.test_extra_flags in archer and multiplex tests.
Jun 24 2020, 6:29 PM · Restricted Project
zhuhan0 created D82516: [openmp] Use config.test_extra_flags in archer and multiplex tests.
Jun 24 2020, 5:58 PM · Restricted Project

Jun 23 2020

zhuhan0 added a comment to D81176: [HIP] Add default header and include path.

This broke a test clang/test/Tooling/clang-check-offload.cpp for a critical Linux distro at Facebook. With this change, the test adds a -include __clang_hip_runtime_wrapper argument. The wrapper includes some standard c++ headers, but our distro don't have those headers in the default include paths, thus causing a break.

I notice this behavior doesn't happen for CUDA tests, which also rely on a similar __clang_cuda_runtime_wrapper. I think what's causing the difference is the different handling of nogpuinc/nogpulib option. My knowledge on this area is limited, so correct me if I'm wrong. CUDA seems to respect nogpuinc and doesn't include its wrapper if the flag is provided: https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChains/Cuda.cpp#L255. But based on this change, HIP does things differently: https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChains/AMDGPU.cpp#L226.

If I modify RocmInstallationDetector::AddHIPIncludeArgs to also respect nogpuinc/nogpulib, the test will pass for us. Is it a mistake for HIP to always include the wrapper file? Could you provide a fix for this issue? Thanks!

Thanks for investigating the issue. It makes sense to respect nogpuinc and nogpulib. fixed by 2580635bd2f3c0527353e4d7823326cd9f92ff7c

Jun 23 2020, 12:21 PM · Restricted Project

Jun 21 2020

zhuhan0 added a comment to D81176: [HIP] Add default header and include path.

This broke a test clang/test/Tooling/clang-check-offload.cpp for a critical Linux distro at Facebook. With this change, the test adds a -include __clang_hip_runtime_wrapper argument. The wrapper includes some standard c++ headers, but our distro don't have those headers in the default include paths, thus causing a break.

Jun 21 2020, 11:57 PM · Restricted Project

May 6 2020

zhuhan0 added a comment to D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

@smeenai Yes please. Thanks!

May 6 2020, 7:20 PM · Restricted Project
zhuhan0 updated the diff for D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Address comment

May 6 2020, 5:38 PM · Restricted Project

May 4 2020

zhuhan0 updated the diff for D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Rebase

May 4 2020, 10:43 AM · Restricted Project

Apr 28 2020

zhuhan0 added a comment to D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Thanks @hans My bad. Didn't test this when LLVM_ENABLE_PIC=OFF.

Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the diff for D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Spacing.

Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 added reviewers for D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON: smeenai, modocache, beanz, phosek.
Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the summary of D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the summary of D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the summary of D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the summary of D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 7:27 PM · Restricted Project
zhuhan0 updated the summary of D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 6:54 PM · Restricted Project
zhuhan0 created D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 28 2020, 6:54 PM · Restricted Project

Apr 27 2020

zhuhan0 added a comment to D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

@smeenai Thank you!

Apr 27 2020, 2:00 PM · Restricted Project
zhuhan0 added a comment to D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

@smeenai Yes.

Apr 27 2020, 1:30 PM · Restricted Project

Apr 26 2020

zhuhan0 added a comment to D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Hello @beanz @phosek @smeenai any comment on this patch? :)

Apr 26 2020, 9:15 PM · Restricted Project
zhuhan0 updated the diff for D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Rebase

Apr 26 2020, 9:15 PM · Restricted Project

Apr 21 2020

zhuhan0 updated the diff for D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.

Spacing

Apr 21 2020, 10:14 AM · Restricted Project

Apr 20 2020

zhuhan0 updated the summary of D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 20 2020, 11:25 PM · Restricted Project
zhuhan0 added reviewers for D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON: chandlerc, bogner, smeenai, modocache.
Apr 20 2020, 11:18 PM · Restricted Project
zhuhan0 updated the summary of D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 20 2020, 9:41 PM · Restricted Project
zhuhan0 created D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON.
Apr 20 2020, 9:40 PM · Restricted Project