Given that OpState already implicit converts to Operator*, this seems reasonable.
The alternative would be to add more functions to OpState which forward to Operation.
Differential D92266 Authored by csigg on Nov 28 2020, 5:03 AM.
Details Summary Given that OpState already implicit converts to Operator*, this seems reasonable. The alternative would be to add more functions to OpState which forward to Operation.
Diff Detail
Event TimelineHerald added subscribers: mravishankar, teijeong, rdzhabarov and 22 others. · View Herald Transcript This revision is now accepted and ready to land.Nov 30 2020, 12:36 AM This revision now requires review to proceed.Nov 30 2020, 4:09 AM Comment Actions Much nicer, thanks!! We could probably remove some of the duplicated methods from Op now, the duplication doesn't bring a huge benefit IMO. This revision is now accepted and ready to land.Dec 1 2020, 2:29 PM Comment Actions
Sure, I can do that. Closed by commit rGc4a04059026b: Add `Operation* OpState::operator->()` to provide more convenient access to… (authored by csigg). · Explain WhyDec 2 2020, 6:46 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 308950 |