Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation.
ClosedPublic
Actions

Authored by csigg on Nov 28 2020, 5:03 AM.

Details

Reviewers

mravishankar
antiagainst
rriddle
aartbik
ftynse
nicolasvasilache
herhut

Commits

rGc4a04059026b: Add `Operation* OpState::operator->()` to provide more convenient access to…

Summary

Given that OpState already implicit converts to Operator*, this seems reasonable.

The alternative would be to add more functions to OpState which forward to Operation.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

csigg created this revision.Nov 28 2020, 5:03 AM

Herald added a reviewer: mravishankar. · View Herald TranscriptNov 28 2020, 5:03 AM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: rriddle. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: mravishankar, teijeong, rdzhabarov and 22 others. · View Herald Transcript

csigg requested review of this revision.Nov 28 2020, 5:03 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 28 2020, 5:03 AM

Herald added a reviewer: herhut. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B80411: Diff 308154.Nov 28 2020, 5:21 AM

ftynse accepted this revision.Nov 30 2020, 12:36 AM

This revision is now accepted and ready to land.Nov 30 2020, 12:36 AM

csigg added 1 blocking reviewer(s): rriddle.Nov 30 2020, 4:09 AM

This revision now requires review to proceed.Nov 30 2020, 4:09 AM

Much nicer, thanks!! We could probably remove some of the duplicated methods from Op now, the duplication doesn't bring a huge benefit IMO.

This revision is now accepted and ready to land.Dec 1 2020, 2:29 PM

In D92266#2426800, @rriddle wrote:

Much nicer, thanks!! We could probably remove some of the duplicated methods from Op now, the duplication doesn't bring a huge benefit IMO.

Sure, I can do that.

Closed by commit rGc4a04059026b: Add `Operation* OpState::operator->()` to provide more convenient access to… (authored by csigg). · Explain WhyDec 2 2020, 6:46 AM

This revision was automatically updated to reflect the committed changes.

csigg added a commit: rGc4a04059026b: Add `Operation* OpState::operator->()` to provide more convenient access to….

Revision Contents
Changeset List

Path

Size

mlir/

examples/

toy/

Ch5/

mlir/

LowerToAffineLoops.cpp

6 lines

Ch6/

mlir/

LowerToAffineLoops.cpp

6 lines

Ch7/

mlir/

LowerToAffineLoops.cpp

6 lines

include/

mlir/

Dialect/

Linalg/

IR/

LinalgStructuredOpsInterface.td

4 lines

Vector/

VectorTransforms.h

2 lines

IR/

OpDefinition.h

3 lines

Interfaces/

VectorInterfaces.td

2 lines

lib/

Analysis/

AffineAnalysis.cpp

2 lines

BufferAliasAnalysis.cpp

7 lines

Utils.cpp

5 lines

Conversion/

AVX512ToLLVM/

ConvertAVX512ToLLVM.cpp

6 lines

GPUCommon/

ConvertLaunchFuncToRuntimeCalls.cpp

13 lines

PDLToPDLInterp/

PDLToPDLInterp.cpp

2 lines

SCFToOpenMP/

SCFToOpenMP.cpp

6 lines

SCFToSPIRV/

SCFToSPIRV.cpp

2 lines

StandardToLLVM/

StandardToLLVM.cpp

18 lines

StandardToSPIRV/

ConvertStandardToSPIRV.cpp

8 lines

Dialect/

Affine/

IR/

AffineOps.cpp

2 lines

Transforms/

AffineLoopInvariantCodeMotion.cpp

4 lines

SuperVectorize.cpp

4 lines

Utils/

Utils.cpp

2 lines

Async/

Transforms/

AsyncRefCountingOptimization.cpp

2 lines

GPU/

IR/

GPUDialect.cpp

2 lines

Transforms/

KernelOutlining.cpp

2 lines

Linalg/

Transforms/

8 lines

2 lines

18 lines

87 lines

2 lines

5 lines

2 lines

13 lines

2 lines

PDL/

IR/

PDL.cpp

2 lines

SCF/

SCF.cpp

4 lines

Transforms/

ParallelLoopFusion.cpp

2 lines

StructuralTypeConversions.cpp

4 lines

SPIRV/

Linking/

ModuleCombiner/

ModuleCombiner.cpp

4 lines

SPIRVCanonicalization.cpp

9 lines

Serialization/

Serializer.cpp

4 lines

Transforms/

RewriteInsertsPass.cpp

2 lines

StandardOps/

IR/

Ops.cpp

16 lines

Transforms/

TensorConstantBufferize.cpp

2 lines

Vector/

VectorOps.cpp

2 lines

VectorTransforms.cpp

2 lines

IR/

BuiltinDialect.cpp

3 lines

Parser/

Parser.cpp

4 lines

Transforms/

Inliner.cpp

2 lines

LoopFusion.cpp

4 lines

SCCP.cpp

4 lines

Utils/

InliningUtils.cpp

2 lines

LoopFusionUtils.cpp

8 lines

LoopUtils.cpp

55 lines

test/

lib/

Dialect/

SPIRV/

TestAvailability.cpp

2 lines

Transforms/

TestLinalgFusionTransforms.cpp

2 lines

TestLoopFusion.cpp

6 lines

tools/

mlir-tblgen/

OpDefinitionsGen.cpp

6 lines

SPIRVUtilsGen.cpp

4 lines

Diff 308950

View Options

mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp

View Options

mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp

View Options

mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp

View Options

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td

View Options

mlir/include/mlir/Dialect/Vector/VectorTransforms.h

View Options

mlir/include/mlir/IR/OpDefinition.h

View Options

mlir/include/mlir/Interfaces/VectorInterfaces.td

View Options

mlir/lib/Analysis/AffineAnalysis.cpp

View Options

mlir/lib/Analysis/BufferAliasAnalysis.cpp

View Options

mlir/lib/Analysis/Utils.cpp

View Options

mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp

View Options

mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp

View Options

mlir/lib/Conversion/PDLToPDLInterp/PDLToPDLInterp.cpp

View Options

mlir/lib/Conversion/SCFToOpenMP/SCFToOpenMP.cpp

View Options

mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRV.cpp

View Options

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

View Options

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp

View Options

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

View Options

mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp

View Options

mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp

View Options

mlir/lib/Dialect/Affine/Utils/Utils.cpp

View Options

mlir/lib/Dialect/Async/Transforms/AsyncRefCountingOptimization.cpp

View Options

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

View Options

mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/FusionOnTensors.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Loops.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp

View Options

mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp

View Options

mlir/lib/Dialect/PDL/IR/PDL.cpp

View Options

mlir/lib/Dialect/SCF/SCF.cpp

View Options

mlir/lib/Dialect/SCF/Transforms/ParallelLoopFusion.cpp

View Options

mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp

View Options

mlir/lib/Dialect/SPIRV/Linking/ModuleCombiner/ModuleCombiner.cpp

View Options

mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp

View Options

mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp

View Options

mlir/lib/Dialect/SPIRV/Transforms/RewriteInsertsPass.cpp

View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

View Options

mlir/lib/Dialect/StandardOps/Transforms/TensorConstantBufferize.cpp

View Options

mlir/lib/Dialect/Vector/VectorOps.cpp

View Options

mlir/lib/Dialect/Vector/VectorTransforms.cpp

View Options

mlir/lib/IR/BuiltinDialect.cpp

View Options

mlir/lib/Parser/Parser.cpp

View Options

mlir/lib/Transforms/Inliner.cpp

View Options

mlir/lib/Transforms/LoopFusion.cpp

View Options

mlir/lib/Transforms/SCCP.cpp

View Options

mlir/lib/Transforms/Utils/InliningUtils.cpp

View Options

mlir/lib/Transforms/Utils/LoopFusionUtils.cpp

View Options

mlir/lib/Transforms/Utils/LoopUtils.cpp

View Options

mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp

View Options

mlir/test/lib/Transforms/TestLinalgFusionTransforms.cpp

View Options

mlir/test/lib/Transforms/TestLoopFusion.cpp

View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

View Options

mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 308950

mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp

mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp

mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td

mlir/include/mlir/Dialect/Vector/VectorTransforms.h

mlir/include/mlir/IR/OpDefinition.h

mlir/include/mlir/Interfaces/VectorInterfaces.td

mlir/lib/Analysis/AffineAnalysis.cpp

mlir/lib/Analysis/BufferAliasAnalysis.cpp

mlir/lib/Analysis/Utils.cpp

mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp

mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp

mlir/lib/Conversion/PDLToPDLInterp/PDLToPDLInterp.cpp

mlir/lib/Conversion/SCFToOpenMP/SCFToOpenMP.cpp

mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRV.cpp

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp

mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp

mlir/lib/Dialect/Affine/Utils/Utils.cpp

mlir/lib/Dialect/Async/Transforms/AsyncRefCountingOptimization.cpp

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp

mlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp

mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp

mlir/lib/Dialect/Linalg/Transforms/FusionOnTensors.cpp

mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp

mlir/lib/Dialect/Linalg/Transforms/Loops.cpp

mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp

mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp

mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp

mlir/lib/Dialect/PDL/IR/PDL.cpp

mlir/lib/Dialect/SCF/SCF.cpp

mlir/lib/Dialect/SCF/Transforms/ParallelLoopFusion.cpp

mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp

mlir/lib/Dialect/SPIRV/Linking/ModuleCombiner/ModuleCombiner.cpp

mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp

mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp

mlir/lib/Dialect/SPIRV/Transforms/RewriteInsertsPass.cpp

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

mlir/lib/Dialect/StandardOps/Transforms/TensorConstantBufferize.cpp

mlir/lib/Dialect/Vector/VectorOps.cpp

mlir/lib/Dialect/Vector/VectorTransforms.cpp

mlir/lib/IR/BuiltinDialect.cpp

mlir/lib/Parser/Parser.cpp

mlir/lib/Transforms/Inliner.cpp

mlir/lib/Transforms/LoopFusion.cpp

mlir/lib/Transforms/SCCP.cpp

mlir/lib/Transforms/Utils/InliningUtils.cpp

mlir/lib/Transforms/Utils/LoopFusionUtils.cpp

mlir/lib/Transforms/Utils/LoopUtils.cpp

mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp

mlir/test/lib/Transforms/TestLinalgFusionTransforms.cpp

mlir/test/lib/Transforms/TestLoopFusion.cpp

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation.
ClosedPublic
Actions

Revision Contents
Changeset List