Update all reference from the specification to the new OpenACC 3.1
document.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
80 ms | x64 windows > LLVM.CodeGen/XCore::threads.ll |
Event Timeline
flang/lib/Semantics/check-acc-structure.cpp | ||
---|---|---|
149 | Please help me understand this: |
flang/lib/Semantics/check-acc-structure.cpp | ||
---|---|---|
81 | No strong opinion here(on line number part), however in openmp semantics they mention section number and some description https://github.com/llvm/llvm-project/blob/main/flang/lib/Semantics/check-omp-structure.cpp#L74 having said that, that is also confusing since it doesn't mention that sections belongs to openmp4.5 or openmp5.0 or openmp5.1? |
flang/lib/Semantics/check-acc-structure.cpp | ||
---|---|---|
81 | I agree that I would prefer that standards add a unique numbering to the restriction like the Fortran standard does. In the mean time, since there is no way in Flang (at the moment) to differentiate two standards or to force to use one standard over another I guess this is the best I can do. | |
149 | From 3.1 the serial construct takes the same restriction as the parallel and kernels for the supported clauses after device_type. There was already couple of tests in this sense but I can surely add some more. |
flang/lib/Semantics/check-acc-structure.cpp | ||
---|---|---|
149 | In fact the test are there already. The restriction has been simplified in 3.1 so it can be checked the same way for parallel, serial and kernels. |
No strong opinion here(on line number part), however in openmp semantics they mention section number and some description https://github.com/llvm/llvm-project/blob/main/flang/lib/Semantics/check-omp-structure.cpp#L74 having said that, that is also confusing since it doesn't mention that sections belongs to openmp4.5 or openmp5.0 or openmp5.1?
Here atleast that part is clear all line number reference here refer to openacc3.1