# [flang][openacc] Update reference to OpenACC 3.1 specificationClosedPublicActions

Authored by clementval on Nov 25 2020, 12:01 PM.
Tags
• Restricted Project
• Restricted Project
• Restricted Project

# Details

Reviewers
 sscalpone kiranktp SouraVX kiranchandramohan sameeranjoshi
Commits
rGd553243fe4b5: [flang][openacc] Update reference to OpenACC 3.1 specification
Summary

Update all reference from the specification to the new OpenACC 3.1
document.

# Unit TestsFailedView All

TimeTest
Script: -- : 'RUN: at line 1'; c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll | c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll

### Event Timeline

clementval created this revision.Nov 25 2020, 12:01 PM
Herald added projects: Restricted Project, Restricted Project. Nov 25 2020, 12:01 PM
Herald added subscribers: llvm-commits, teijeong, rdzhabarov and 15 others.
clementval requested review of this revision.Nov 25 2020, 12:01 PM
clementval added a project: Restricted Project.
SouraVX accepted this revision.Dec 8 2020, 7:19 AM
flang/lib/Semantics/check-acc-structure.cpp
149

This is a code change right ? Just curious, are there any test case modifications supporting this ?
Or is it just code refactoring ?

This revision is now accepted and ready to land.Dec 8 2020, 7:19 AM
flang/lib/Semantics/check-acc-structure.cpp
81

No strong opinion here(on line number part), however in openmp semantics they mention section number and some description https://github.com/llvm/llvm-project/blob/main/flang/lib/Semantics/check-omp-structure.cpp#L74 having said that, that is also confusing since it doesn't mention that sections belongs to openmp4.5 or openmp5.0 or openmp5.1?
Here atleast that part is clear all line number reference here refer to openacc3.1

flang/lib/Semantics/check-acc-structure.cpp
81

I agree that I would prefer that standards add a unique numbering to the restriction like the Fortran standard does. In the mean time, since there is no way in Flang (at the moment) to differentiate two standards or to force to use one standard over another I guess this is the best I can do.

149

From 3.1 the serial construct takes the same restriction as the parallel and kernels for the supported clauses after device_type. There was already couple of tests in this sense but I can surely add some more.

clementval marked an inline comment as done.Dec 8 2020, 11:16 AM
clementval marked an inline comment as done.Dec 8 2020, 11:33 AM