Page MenuHomePhabricator

[flang][openacc] Update reference to OpenACC 3.1 specification

Authored by clementval on Nov 25 2020, 12:01 PM.



Update all reference from the specification to the new OpenACC 3.1

Diff Detail

Unit TestsFailed

80 msx64 windows > LLVM.CodeGen/XCore::threads.ll
Script: -- : 'RUN: at line 1'; c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll | c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll

Event Timeline

clementval created this revision.Nov 25 2020, 12:01 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 25 2020, 12:01 PM
clementval requested review of this revision.Nov 25 2020, 12:01 PM
SouraVX accepted this revision.Dec 8 2020, 7:19 AM
SouraVX added inline comments.

Please help me understand this:
This is a code change right ? Just curious, are there any test case modifications supporting this ?
Or is it just code refactoring ?

This revision is now accepted and ready to land.Dec 8 2020, 7:19 AM
SouraVX added inline comments.Dec 8 2020, 7:28 AM

No strong opinion here(on line number part), however in openmp semantics they mention section number and some description having said that, that is also confusing since it doesn't mention that sections belongs to openmp4.5 or openmp5.0 or openmp5.1?
Here atleast that part is clear all line number reference here refer to openacc3.1

clementval added inline comments.Dec 8 2020, 11:16 AM

I agree that I would prefer that standards add a unique numbering to the restriction like the Fortran standard does. In the mean time, since there is no way in Flang (at the moment) to differentiate two standards or to force to use one standard over another I guess this is the best I can do.


From 3.1 the serial construct takes the same restriction as the parallel and kernels for the supported clauses after device_type. There was already couple of tests in this sense but I can surely add some more.

clementval marked an inline comment as done.Dec 8 2020, 11:16 AM
clementval marked an inline comment as done.Dec 8 2020, 11:33 AM
clementval added inline comments.Dec 8 2020, 11:35 AM

In fact the test are there already. The restriction has been simplified in 3.1 so it can be checked the same way for parallel, serial and kernels.

This revision was landed with ongoing or failed builds.Dec 8 2020, 11:36 AM
This revision was automatically updated to reflect the committed changes.