This is an archive of the discontinued LLVM Phabricator instance.

[lld] Add --no-lto-whole-program-visibility
ClosedPublic

Authored by tejohnson on Nov 24 2020, 2:56 PM.

Details

Summary

Enables overriding earlier --lto-whole-program-visibility.

Variant of D91583 while discussing alternate ways to identify and
handle the --export-dynamic case.

Diff Detail

Event Timeline

tejohnson created this revision.Nov 24 2020, 2:56 PM
Herald added a project: Restricted Project. · View Herald Transcript
tejohnson requested review of this revision.Nov 24 2020, 2:56 PM

This looks good.

lld/test/ELF/lto/devirt_vcall_vis_public.ll
34

Could you also add some comments that the existing --export-dynamic is to retain the symbols?

39

A --lto-whole-program-visibility --no-lto-whole-program-visibility RUN list is sufficient, no need for the previous RUN line.

tejohnson added inline comments.Nov 24 2020, 3:07 PM
lld/test/ELF/lto/devirt_vcall_vis_public.ll
34

Will do.

39

I assume you mean the variant I added with just the explicit --no-lto-whole-program-visibility, and not --lto-whole-program-visibility. Yeah that seems redundant, will remove.

tejohnson updated this revision to Diff 307462.Nov 24 2020, 3:12 PM

Address comments

MaskRay accepted this revision.Nov 24 2020, 3:17 PM

Looks great!

This revision is now accepted and ready to land.Nov 24 2020, 3:17 PM
This revision was automatically updated to reflect the committed changes.