Paths

Table of Contentst

Differential D92060

[lld] Add --no-lto-whole-program-visibility
ClosedPublic
Actions

Authored by tejohnson on Nov 24 2020, 2:56 PM.

Details

Reviewers

MaskRay
• espindola

Commits

rG07f234be1ccb: [lld] Add --no-lto-whole-program-visibility

Summary

Enables overriding earlier --lto-whole-program-visibility.

Variant of D91583 while discussing alternate ways to identify and
handle the --export-dynamic case.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

tejohnson created this revision.Nov 24 2020, 2:56 PM

Herald added a reviewer: • espindola. · View Herald TranscriptNov 24 2020, 2:56 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: dang, steven_wu, hiraditya and 3 others. · View Herald Transcript

tejohnson requested review of this revision.Nov 24 2020, 2:56 PM

tejohnson mentioned this in D91583: [LTO] Prevent devirtualization for symbols dynamically exported.Nov 24 2020, 2:57 PM

This looks good.

lld/test/ELF/lto/devirt_vcall_vis_public.ll
37	Could you also add some comments that the existing --export-dynamic is to retain the symbols?
42	A `--lto-whole-program-visibility --no-lto-whole-program-visibility` RUN list is sufficient, no need for the previous RUN line.

tejohnson added inline comments.Nov 24 2020, 3:07 PM

lld/test/ELF/lto/devirt_vcall_vis_public.ll
37	Will do.
42	I assume you mean the variant I added with just the explicit --no-lto-whole-program-visibility, and not --lto-whole-program-visibility. Yeah that seems redundant, will remove.

Address comments

Looks great!

This revision is now accepted and ready to land.Nov 24 2020, 3:17 PM

Harbormaster completed remote builds in B80016: Diff 307458.Nov 24 2020, 3:23 PM

Harbormaster completed remote builds in B80017: Diff 307462.Nov 24 2020, 3:43 PM

Closed by commit rG07f234be1ccb: [lld] Add --no-lto-whole-program-visibility (authored by tejohnson). · Explain WhyNov 24 2020, 4:46 PM

This revision was automatically updated to reflect the committed changes.

tejohnson added a commit: rG07f234be1ccb: [lld] Add --no-lto-whole-program-visibility.

Revision Contents
Changeset List

Path

Size

lld/

ELF/

3 lines

5 lines

test/

ELF/

lto/

devirt_vcall_vis_public.ll

7 lines

Diff 307480

lld/ELF/Driver.cpp

Loading...

lld/ELF/Options.td

Loading...

lld/test/ELF/lto/devirt_vcall_vis_public.ll

Loading...