[flang][openacc] Add clause validaty tests for data construct + fix default restriction

[clementval]

Summary

Add clause validity tests for the data construct. The default clause can appear only once
and this was not enforce in the ACC.td.

[sameeranjoshi]

LGTM.

[clementval]

Thanks for the review!

[clementval]

Rebase

[PeteSteinfeld]

@clementval , when I build and test an in-tree build, everything works fine. But when I build out-of-tree, the error message associated with line 165 does not appear. Do you know why?

Let me know what I can do to help figure this out.

flang/test/Semantics/acc-clause-validity.f90

140

In an out-of-tree build, the error message associated with this line does not appear.

[PeteSteinfeld]

@clementval , never mind. I had a setup error mixing up the "master" and "main" branches.

[clementval]

In D91888#2437715, @PeteSteinfeld wrote:

@clementval , never mind. I had a setup error mixing up the "master" and "main" branches.

Thanks for the review! I had similar problem today by mixing master and main ...

[clementval]

Rebase

[clementval]

This patched has landed.

flang/test/Semantics/acc-clause-validity.f90

program openacc_clause_validity
   implicit none
 
   integer :: i, j, b, gang_size, vector_size, worker_size
   integer, parameter :: N = 256
   integer, dimension(N) :: c
   logical, dimension(N) :: d, e
   real :: reduction_r
   logical :: reduction_l
-  real(8), dimension(N, N) :: aa
+  real(8), dimension(N, N) :: aa, bb, cc
   logical :: ifCondition = .TRUE.
 
   !ERROR: At least one clause is required on the DECLARE directive
   !$acc declare
   real(8), dimension(N) :: a, f, g, h
 
   !$acc init
   !$acc init if(.TRUE.)
program openacc_clause_validity
 
   !ERROR: At least one of DEFAULT_ASYNC, DEVICE_NUM, DEVICE_TYPE clause must appear on the SET directive
   !$acc set
 
   !ERROR: At least one of ATTACH, COPY, COPYIN, COPYOUT, CREATE, DEFAULT, DEVICEPTR, NO_CREATE, PRESENT clause must appear on the DATA directive
   !$acc data
   !$acc end data
 
-  !$acc data copyin(i)
+  !$acc data copy(aa) if(.true.)
+  !$acc end data
+
+  !$acc data copy(aa) if(ifCondition)
+  !$acc end data
+
+  !$acc data copy(aa, bb, cc)
+  !$acc end data
+
+  !$acc data copyin(aa) copyin(readonly: bb) copyout(cc)
+  !$acc end data
+
+  !$acc data copyin(readonly: aa, bb) copyout(zero: cc)
+  !$acc end data
+
+  !$acc data create(aa, bb(:,:)) create(zero: cc(:,:))
+  !$acc end data
+
+  !$acc data no_create(aa) present(bb, cc)
+  !$acc end data
+
+  !$acc data deviceptr(aa) attach(bb, cc)
+  !$acc end data
+
+  !$acc data copy(aa, bb) default(none)
+  !$acc end data
+
+  !$acc data copy(aa, bb) default(present)
+  !$acc end data
+
+  !ERROR: At most one DEFAULT clause can appear on the DATA directive
+  !$acc data copy(aa, bb) default(none) default(present)
+  !$acc end data
+
+  !ERROR: At most one IF clause can appear on the DATA directive
+  !$acc data copy(aa) if(.true.) if(ifCondition)
   !$acc end data
 
   !$acc data copyin(i)
   !ERROR: Unmatched PARALLEL directive
   !$acc end parallel
 
   !$acc update self(a, f) host(g) device(h)
 

llvm/include/llvm/Frontend/OpenACC/ACC.td

 //===----------------------------------------------------------------------===//
 
 // 2.12
 def ACC_Atomic : Directive<"atomic"> {}
 
 // 2.6.5
 def ACC_Data : Directive<"data"> {
   let allowedOnceClauses = [
-    VersionedClause<ACCC_If>
+    VersionedClause<ACCC_If>,
+    VersionedClause<ACCC_Default>
   ];
   let requiredClauses = [
     VersionedClause<ACCC_Attach>,
     VersionedClause<ACCC_Copy>,
     VersionedClause<ACCC_Copyin>,
     VersionedClause<ACCC_Copyout>,
     VersionedClause<ACCC_Create>,
     VersionedClause<ACCC_Default>,