Page MenuHomePhabricator

[LAA] NFC: Rename [get]MaxSafeRegisterWidth -> [get]MaxSafeVectorWidthInBits
ClosedPublic

Authored by c-rhodes on Nov 18 2020, 10:33 AM.

Details

Summary

MaxSafeRegisterWidth is a misnomer since it actually returns the maximum
safe vector width. Register suggests it relates directly to a physical
register where it could be a vector spanning one or more physical
registers.

Diff Detail

Event Timeline

c-rhodes created this revision.Nov 18 2020, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2020, 10:33 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
c-rhodes requested review of this revision.Nov 18 2020, 10:33 AM
ctetreau added inline comments.Nov 19 2020, 4:28 PM
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
5374

Should WidestRegister get renamed also?

c-rhodes added inline comments.Nov 20 2020, 3:43 AM
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
5374

Should WidestRegister get renamed also?

We'll probably look at changing this as well when we add support for scalable VFs here.

Please run clang-format, then this looks good to me.

c-rhodes updated this revision to Diff 307296.Nov 24 2020, 3:06 AM

Run clang-format

This revision is now accepted and ready to land.Nov 24 2020, 8:59 AM