Change-Id: If2650fc7f31bbdd49c76e74a9ca8e3734d769761
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Don't you need to update lib/Object/ELFObjectFile.cpp and test/Object/AMDGPU/elf-header-flags-mach.yaml?
| llvm/docs/AMDGPUUsage.rst | ||
|---|---|---|
| 326 | APU | |
Missing changes to these files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/NVPTX.cpp
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
llvm/lib/Object/ELFObjectFile.cpp
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml
llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test
| llvm/docs/AMDGPUUsage.rst | ||
|---|---|---|
| 326 | This still needs fixing. | |
| llvm/docs/AMDGPUUsage.rst | ||
|---|---|---|
| 326 | It now says APU in the diff I'm looking at. Is there something else that needs changing? | |
LGTM provided the other files are updated as other reviews have mentioned.
| llvm/docs/AMDGPUUsage.rst | ||
|---|---|---|
| 326 | I see it now. Thanks. | |
APU