Page MenuHomePhabricator

[AMDGPU] Add gfx90c target
ClosedPublic

Authored by tpr on Oct 29 2020, 1:12 PM.

Details

Summary

This differentiates the Ryzen 4000/4300/4500/4700 series APUs that were
previously included in gfx909.

Change-Id: Ia901a7157eb2f73ccd9f25dbacec38427312377d

Diff Detail

Event Timeline

tpr created this revision.Oct 29 2020, 1:12 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
tpr requested review of this revision.Oct 29 2020, 1:12 PM
tpr updated this revision to Diff 301723.Oct 29 2020, 1:15 PM

V2: Fixed copy-o in AMDGPUUsage.rst change.

tpr added a reviewer: t-tye.Oct 29 2020, 1:15 PM
foad added a subscriber: foad.Oct 30 2020, 3:18 AM
foad added inline comments.
llvm/docs/AMDGPUUsage.rst
261

Is xnack really supposed to be off for this target?

tpr updated this revision to Diff 301886.Oct 30 2020, 7:05 AM

V3: Listed products. Marked as "xnack enabled".

tpr edited the summary of this revision. (Show Details)Oct 30 2020, 7:07 AM
tpr marked an inline comment as done.
t-tye accepted this revision.Oct 30 2020, 7:29 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2020, 7:29 AM
scott.linder added inline comments.
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml
7–1

Heads up, I just landed a refactor of this file in https://reviews.llvm.org/D90245

It would probably be easiest to just start from the existing test, and copy-paste following the pattern. The RUN lines can now be in GFX# order, you don't need to create a new YAML document, and the tests are grouped by GFX#

This revision was landed with ongoing or failed builds.Tue, Nov 3, 8:28 AM
This revision was automatically updated to reflect the committed changes.