Page MenuHomePhabricator

[AMDGPU] Add gfx1033 target
ClosedPublic

Authored by tpr on Oct 30 2020, 2:01 AM.

Details

Summary

Change-Id: If2650fc7f31bbdd49c76e74a9ca8e3734d769761

Diff Detail

Event Timeline

tpr created this revision.Oct 30 2020, 2:01 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
tpr requested review of this revision.Oct 30 2020, 2:01 AM
foad added a subscriber: foad.Oct 30 2020, 2:36 AM

Don't you need to update lib/Object/ELFObjectFile.cpp and test/Object/AMDGPU/elf-header-flags-mach.yaml?

t-tye added inline comments.Oct 30 2020, 7:20 AM
llvm/docs/AMDGPUUsage.rst
326

APU

Missing changes to these files:

clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/NVPTX.cpp
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
llvm/lib/Object/ELFObjectFile.cpp
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml
llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test

tpr updated this revision to Diff 301931.Oct 30 2020, 9:46 AM

V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml.

tpr updated this revision to Diff 301953.Oct 30 2020, 10:39 AM

V3: Add missing bits.

This revision is now accepted and ready to land.Oct 30 2020, 11:13 AM
t-tye requested changes to this revision.Oct 30 2020, 11:14 AM
t-tye added inline comments.
llvm/docs/AMDGPUUsage.rst
326

This still needs fixing.

This revision now requires changes to proceed.Oct 30 2020, 11:14 AM
t-tye added inline comments.Oct 30 2020, 11:18 AM
llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test
61–64

Seems this should be in D90419 rather than this review?

tpr added inline comments.Sun, Nov 1, 2:03 PM
llvm/docs/AMDGPUUsage.rst
326

It now says APU in the diff I'm looking at. Is there something else that needs changing?

t-tye accepted this revision.Sun, Nov 1, 2:23 PM

LGTM provided the other files are updated as other reviews have mentioned.

llvm/docs/AMDGPUUsage.rst
326

I see it now. Thanks.

This revision is now accepted and ready to land.Sun, Nov 1, 2:23 PM
This revision was landed with ongoing or failed builds.Tue, Nov 3, 8:28 AM
This revision was automatically updated to reflect the committed changes.