Page MenuHomePhabricator

[flang][OpenMP] Upstream lowering of OpenMP `Flush` construct
ClosedPublic

Authored by SouraVX on Oct 23 2020, 8:07 AM.

Diff Detail

Event Timeline

SouraVX created this revision.Oct 23 2020, 8:07 AM
SouraVX requested review of this revision.Oct 23 2020, 8:07 AM
SouraVX retitled this revision from [flang][OpenMP] Upstream lowering of `ParallelOp` clauses to [flang][OpenMP] Upstream lowering of `FlushOp` clauses.Oct 23 2020, 8:08 AM
SouraVX retitled this revision from [flang][OpenMP] Upstream lowering of `FlushOp` clauses to [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
This revision is now accepted and ready to land.Oct 23 2020, 8:10 AM
flang/lib/Lower/OpenMP.cpp
112

Is this variable used? Would it give a warning and cause a failure in the Werror enabled bots?

After this patch both LLVM Master and FIR-dev branches will be in sync.

SouraVX added inline comments.Oct 23 2020, 8:14 AM
flang/lib/Lower/OpenMP.cpp
112

Yes the warning comes and failure may happen. But nobody mentioned this on FIR-dev ?
But let me reconfirm? is this flag Werror enabled by default on all LLVM bots ? if so let me remove this.

SouraVX updated this revision to Diff 300303.Oct 23 2020, 8:21 AM

Removed ununsed variable.

SouraVX marked an inline comment as done.Oct 23 2020, 8:21 AM
awarzynski added inline comments.
flang/lib/Lower/OpenMP.cpp
112

Two out three of our buildbots have Werror enabled for Flang:

As you can see one uses clang-10 and the other gcc-10. Hope this helps!

kiranchandramohan added inline comments.
flang/lib/Lower/OpenMP.cpp
112

Thanks @awarzynski.

112

I think we discussed the Werror setting when we were upstreaming Flang to LLVM. The LLVM default behaviour is not setting Werror. But Flang developers were of the opinion that it is a very useful flag to have to ensure that the codebase remains warning free and thus maintained at a high standard. So we decided to have a separate FLANG_WERROR flag which is by default OFF but switched ON in our buildbots.

SouraVX marked an inline comment as done.Oct 23 2020, 8:34 AM
SouraVX added inline comments.
flang/lib/Lower/OpenMP.cpp
112

Thanks for quick reference :). I've updated the patch(removed the unused variable).