Page MenuHomePhabricator

[LiveDebugValues] Handle spill locations with a fixed and scalable component.
Needs ReviewPublic

Authored by sdesmalen on Oct 23 2020, 7:11 AM.

Details

Summary

This patch fixes the two LiveDebugValues implementations
(InstrRef/VarLoc)Based to handle cases where the StackOffset contains
both a fixed and scalable component.

This depends on the TargetRegisterInfo::prependOffsetExpression being
added in D90020. Feel free to leave comments on that patch if you have them.

Diff Detail

Event Timeline

sdesmalen created this revision.Oct 23 2020, 7:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2020, 7:11 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
sdesmalen requested review of this revision.Oct 23 2020, 7:11 AM
sdesmalen edited the summary of this revision. (Show Details)Wed, Dec 2, 8:32 AM
sdesmalen set the repository for this revision to rG LLVM Github Monorepo.
djtodoro added inline comments.Thu, Dec 3, 7:36 AM
llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp
561

missing return false?

llvm/test/CodeGen/AArch64/live-debugvalues-sve.mir
48–52

no need for all these attributes