Page MenuHomePhabricator

[AArch64][SVE] Emit DWARF location expr for SVE (dbg.declare)
ClosedPublic

Authored by sdesmalen on Oct 23 2020, 7:09 AM.

Details

Summary

When using dbg.declare, the debug-info is generated from a list of
locals rather than through DBG_VALUE instructions in the MIR.
This patch is different from D90020 because it emits the DWARF
location expressions from that list of locals directly.

Diff Detail

Event Timeline

sdesmalen created this revision.Oct 23 2020, 7:09 AM
sdesmalen requested review of this revision.Oct 23 2020, 7:09 AM
sdesmalen updated this revision to Diff 308695.Dec 1 2020, 10:00 AM

Refactored patch to use appendOffsetExpression similar to the changes made to D90046.

sdesmalen set the repository for this revision to rG LLVM Github Monorepo.
sdesmalen added inline comments.Dec 9 2020, 9:27 AM
llvm/test/CodeGen/AArch64/debug-info-sve-dbg-declare.mir
81

Before someone comments on this, yes, I just realised this patch should also remove the attributes :)

jmorse accepted this revision.Dec 14 2020, 6:24 AM

LGTM

This revision is now accepted and ready to land.Dec 14 2020, 6:24 AM
sdesmalen updated this revision to Diff 314362.Jan 4 2021, 4:58 AM
  • Rebased patch (after changes to D90020 it can use getOffsetOpcodes directly, instead of adding a new function appendOffsetExpr that does the same thing)
  • Removed unnecessary attributes from the test.