Page MenuHomePhabricator

[mlir] Allow space literals (` `) in assemblyFormat.
ClosedPublic

Authored by csigg on Fri, Oct 16, 12:33 PM.

Details

Summary

Spaces are only printed, not parsed.

Diff Detail

Event Timeline

csigg created this revision.Fri, Oct 16, 12:33 PM
csigg requested review of this revision.Fri, Oct 16, 12:33 PM
rriddle requested changes to this revision.Fri, Oct 16, 12:43 PM

Thanks! A few missing cases, but otherwise looks good.

mlir/tools/mlir-tblgen/OpFormatGen.cpp
2243–2245

This should include the SpaceElement as well.

2567

nit: Can you move this comment before the if?

2686–2688

This Case should also include the SpaceElement.

This revision now requires changes to proceed.Fri, Oct 16, 12:43 PM
csigg updated this revision to Diff 298730.Fri, Oct 16, 1:02 PM
csigg marked 2 inline comments as done.

Apply reviewer comments.

mlir/tools/mlir-tblgen/OpFormatGen.cpp
2243–2245

Thanks, I wouldn't have found this or the one below. Is there a simple way to test this?

csigg updated this revision to Diff 298863.Sat, Oct 17, 10:41 PM

Add tests for cases added in previous diff.

rriddle accepted this revision.Sun, Oct 18, 3:40 PM

Looks good, thanks!

This revision is now accepted and ready to land.Sun, Oct 18, 3:40 PM
This revision was landed with ongoing or failed builds.Sun, Oct 18, 10:25 PM
This revision was automatically updated to reflect the committed changes.