Paths

Table of Contentst

Differential D89438

[MLIR] ODS TypeDefs: getChecked() and internal enhancements
ClosedPublic
Actions

Authored by jdd on Oct 14 2020, 7:04 PM.

Details

Reviewers

Commits

rGf402e682d0ef: [MLIR] ODS TypeDefs: getChecked() and internal enhancements

Summary

Have the ODS TypeDef generator write the getChecked() definition.
Also, add to TypeParamCommaFormatter a JustParams format.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jdd created this revision.Oct 14 2020, 7:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2020, 7:04 PM

Herald added subscribers: rdzhabarov, tatianashp, msifontes and 12 others. · View Herald Transcript

jdd requested review of this revision.Oct 14 2020, 7:04 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 14 2020, 7:04 PM

Harbormaster completed remote builds in B75132: Diff 298276.Oct 14 2020, 7:23 PM

jdd mentioned this in D89440: [MLIR] ODS TypeDef documentation.Oct 15 2020, 4:51 PM

rriddle accepted this revision.Oct 18 2020, 3:59 PM

rriddle added inline comments.

mlir/tools/mlir-tblgen/TypeDefGen.cpp
88–90	Can you move the `prependComma` parameter to the end and have a default?
201	Please add comments for constant parameters, i.e. in this case `/prependComma=/true`
375	Same here and below.
498	Please wrap with braces here, the body is not trivial.

This revision is now accepted and ready to land.Oct 18 2020, 3:59 PM

jdd marked 4 inline comments as done.Oct 18 2020, 5:33 PM

Updates based on feedback fro River

Harbormaster completed remote builds in B75475: Diff 298912.Oct 18 2020, 6:03 PM

Closed by commit rGf402e682d0ef: [MLIR] ODS TypeDefs: getChecked() and internal enhancements (authored by jdd). · Explain WhyOct 18 2020, 6:10 PM

This revision was automatically updated to reflect the committed changes.

jdd added a commit: rGf402e682d0ef: [MLIR] ODS TypeDefs: getChecked() and internal enhancements.

Revision Contents
Changeset List

Path

Size

mlir/

test/

lib/

Dialect/

Test/

TestTypeDefs.td

3 lines

mlir-tblgen/

2 lines

tools/

mlir-tblgen/

92 lines

Diff 298913

mlir/test/lib/Dialect/Test/TestTypeDefs.td

Loading...

mlir/test/mlir-tblgen/typedefs.td

Loading...

mlir/tools/mlir-tblgen/TypeDefGen.cpp

Loading...