Page MenuHomePhabricator

[MLIR] ODS TypeDefs: getChecked() and internal enhancements
ClosedPublic

Authored by jdd on Oct 14 2020, 7:04 PM.

Details

Summary

Have the ODS TypeDef generator write the getChecked() definition.
Also, add to TypeParamCommaFormatter a JustParams format.

Diff Detail

Event Timeline

jdd created this revision.Oct 14 2020, 7:04 PM
jdd requested review of this revision.Oct 14 2020, 7:04 PM
rriddle accepted this revision.Oct 18 2020, 3:59 PM
rriddle added inline comments.
mlir/tools/mlir-tblgen/TypeDefGen.cpp
88–90

Can you move the prependComma parameter to the end and have a default?

201

Please add comments for constant parameters, i.e. in this case /*prependComma=*/true

375

Same here and below.

498

Please wrap with braces here, the body is not trivial.

This revision is now accepted and ready to land.Oct 18 2020, 3:59 PM
jdd marked 4 inline comments as done.Oct 18 2020, 5:33 PM
jdd updated this revision to Diff 298912.Oct 18 2020, 5:45 PM
  • Updates based on feedback fro River
This revision was automatically updated to reflect the committed changes.