Page MenuHomePhabricator

jdd (John Demme)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2020, 4:52 PM (24 w, 2 d)

Recent Activity

Sun, Nov 22

jdd committed rG95956c1c9aae: [MLIR] ODS typedef gen fixes & improvements (authored by jdd).
[MLIR] ODS typedef gen fixes & improvements
Sun, Nov 22, 4:15 PM
jdd closed D91939: [MLIR] ODS typedef gen fixes & improvements.
Sun, Nov 22, 4:15 PM · Restricted Project
jdd added a comment to D91939: [MLIR] ODS typedef gen fixes & improvements.

Nice, thanks! Does this add a verifier style check that makes sure that inner type is an RTLValueType, or is that still the responsibility of the custom parser logic?

Sun, Nov 22, 3:57 PM · Restricted Project
jdd updated the summary of D91939: [MLIR] ODS typedef gen fixes & improvements.
Sun, Nov 22, 3:34 PM · Restricted Project
jdd updated the summary of D91939: [MLIR] ODS typedef gen fixes & improvements.
Sun, Nov 22, 3:30 PM · Restricted Project
jdd updated the summary of D91939: [MLIR] ODS typedef gen fixes & improvements.
Sun, Nov 22, 3:30 PM · Restricted Project
jdd requested review of D91939: [MLIR] ODS typedef gen fixes & improvements.
Sun, Nov 22, 3:29 PM · Restricted Project

Oct 27 2020

jdd committed rG035e12e66449: [MLIR] [ODS] Allowing attr-dict in custom directive (authored by jdd).
[MLIR] [ODS] Allowing attr-dict in custom directive
Oct 27 2020, 6:26 PM
jdd closed D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 27 2020, 6:25 PM · Restricted Project
jdd updated the diff for D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
  • const MutableDictionaryAttr&
Oct 27 2020, 4:43 PM · Restricted Project
jdd updated the diff for D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
  • Changes from feedback #2
Oct 27 2020, 4:26 PM · Restricted Project
jdd added inline comments to D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 27 2020, 4:24 PM · Restricted Project

Oct 22 2020

jdd added a comment to D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.

Not sure I'm interpreting all your comments correctly but it's certainly closer.

Oct 22 2020, 5:50 PM · Restricted Project
jdd updated the diff for D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
  • Adding test, making suggested changes, fixing breaks
Oct 22 2020, 5:47 PM · Restricted Project
jdd added inline comments to D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 22 2020, 4:32 PM · Restricted Project
jdd added inline comments to D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 22 2020, 1:35 PM · Restricted Project
jdd added inline comments to D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 22 2020, 1:29 PM · Restricted Project

Oct 20 2020

jdd requested review of D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Oct 20 2020, 12:56 AM · Restricted Project

Oct 18 2020

jdd committed rGf402e682d0ef: [MLIR] ODS TypeDefs: getChecked() and internal enhancements (authored by jdd).
[MLIR] ODS TypeDefs: getChecked() and internal enhancements
Oct 18 2020, 6:11 PM
jdd closed D89438: [MLIR] ODS TypeDefs: getChecked() and internal enhancements.
Oct 18 2020, 6:10 PM · Restricted Project
jdd updated the diff for D89438: [MLIR] ODS TypeDefs: getChecked() and internal enhancements.
  • Updates based on feedback fro River
Oct 18 2020, 5:45 PM · Restricted Project
jdd committed rG6f878096640f: [MLIR] ODS TypeDef documentation (authored by jdd).
[MLIR] ODS TypeDef documentation
Oct 18 2020, 5:22 PM
jdd closed D89440: [MLIR] ODS TypeDef documentation.
Oct 18 2020, 5:22 PM · Restricted Project
jdd added inline comments to D89440: [MLIR] ODS TypeDef documentation.
Oct 18 2020, 5:18 PM · Restricted Project
jdd added inline comments to D89440: [MLIR] ODS TypeDef documentation.
Oct 18 2020, 5:01 PM · Restricted Project
jdd updated the diff for D89440: [MLIR] ODS TypeDef documentation.
  • Changes based on River's feedback.
Oct 18 2020, 5:01 PM · Restricted Project

Oct 15 2020

jdd added a comment to D89440: [MLIR] ODS TypeDef documentation.

Also, this documentation is very slightly wrong without https://reviews.llvm.org/D89438

Oct 15 2020, 4:51 PM · Restricted Project
jdd updated the diff for D89440: [MLIR] ODS TypeDef documentation.
  • Updating doc as per Mehdi's comments
Oct 15 2020, 4:48 PM · Restricted Project
jdd added inline comments to D89440: [MLIR] ODS TypeDef documentation.
Oct 15 2020, 4:46 PM · Restricted Project

Oct 14 2020

jdd added a comment to D89440: [MLIR] ODS TypeDef documentation.

I'm working on this in this branch: https://github.com/teqdruid/llvm-project/tree/ods-types-doc. It may be faster to edit directly. I can either push this branch upstream or give reviews/editors access to my fork.

Oct 14 2020, 7:26 PM · Restricted Project
jdd requested review of D89440: [MLIR] ODS TypeDef documentation.
Oct 14 2020, 7:23 PM · Restricted Project
jdd requested review of D89438: [MLIR] ODS TypeDefs: getChecked() and internal enhancements.
Oct 14 2020, 7:04 PM · Restricted Project

Oct 13 2020

jdd committed rG5fe53c412832: [MLIR] Add support for defining Types in tblgen (authored by jdd).
[MLIR] Add support for defining Types in tblgen
Oct 13 2020, 5:32 PM
jdd closed D86904: [mlir] Support for defining Types in tblgen.
Oct 13 2020, 5:32 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.
  • Rebasing w/ conflicts
  • New branch, applying everything at once
  • Clang-(format|tidy) fixes
  • One more clang-tidy fix
  • Changes based on Chris' comments
  • Ending a sentence comment w/ a period
  • Revisions base on River's comments
  • Clang-tidy and some missed comments
  • Missed a comment
  • clang-format
  • Changes based on review
  • Remove llvm:: from the cpp file
  • Clang-tidy fix
  • Another round of changes based on feedback.
Oct 13 2020, 3:00 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.
  • Another round of changes based on feedback.
Oct 13 2020, 2:15 PM · Restricted Project, Restricted Project
jdd added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Oct 13 2020, 2:10 PM · Restricted Project, Restricted Project

Oct 10 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.
  • Clang-tidy fix
Oct 10 2020, 7:16 PM · Restricted Project, Restricted Project

Oct 9 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.
  • Changes based on review
  • Remove llvm:: from the cpp file
Oct 9 2020, 10:22 PM · Restricted Project, Restricted Project
jdd added a comment to D86904: [mlir] Support for defining Types in tblgen.

I'll update the documentation as you requested. Do you mind if I do it in a subsequent commit? I have a feeling there's going to be some back-and-forth on the documentation and I don't want that editorial process to gate this commit.

Oct 9 2020, 10:21 PM · Restricted Project, Restricted Project

Oct 8 2020

jdd added a comment to D89059: Add basic comparison operations for the RTL dialect.

Hi Andrew- We're using GH PRs to do reviews.

Oct 8 2020, 11:57 AM

Oct 5 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

clang-format

Oct 5 2020, 3:30 PM · Restricted Project, Restricted Project

Oct 2 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Missed a comment

Oct 2 2020, 8:46 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Revisions base on River's comments

Oct 2 2020, 8:43 PM · Restricted Project, Restricted Project
jdd updated the summary of D86904: [mlir] Support for defining Types in tblgen.
Oct 2 2020, 8:42 PM · Restricted Project, Restricted Project
jdd added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Oct 2 2020, 7:19 PM · Restricted Project, Restricted Project
jdd added a comment to D86904: [mlir] Support for defining Types in tblgen.

As for declaring parse(...), print(...), and getMnemonic() in the header file: these are intended for cases where (for some reason) the dialect doesn't use the global parse/print dispatch method. The dialect could call each parse/print method in its Dialect::parseType/Dialect::printType methods, in concert with the getMnemonic(). I figure even if it's not often used, its just an extra 3 lines in each type declaration.

Oct 2 2020, 12:35 PM · Restricted Project, Restricted Project

Oct 1 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Changes based on Chris' comments

Oct 1 2020, 11:16 AM · Restricted Project, Restricted Project

Sep 29 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

One more clang-tidy fix

Sep 29 2020, 11:54 AM · Restricted Project, Restricted Project

Sep 28 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Fixing the previous arc diff

Sep 28 2020, 6:11 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Fixing whitespace and clang-tidy issues

Sep 28 2020, 6:10 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Let's try this again

Sep 28 2020, 4:47 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

I will never understand arc

Sep 28 2020, 4:44 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Syncing w/ master & removing auto-parsing stuff

Sep 28 2020, 4:41 PM · Restricted Project, Restricted Project
jdd added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Sep 28 2020, 12:56 PM · Restricted Project, Restricted Project

Sep 24 2020

jdd added a comment to D88267: Common code preparation for tblgen-types patch.

This is my first patch, so I’ll need someone to land it for me please. @mehdi_amini, since you reviewed it, would you be so kind as to commit it? I prefer 'John Demme' <me@teqdruid.com>.

Sep 24 2020, 9:16 PM · Restricted Project, Restricted Project
jdd updated the summary of D88267: Common code preparation for tblgen-types patch.
Sep 24 2020, 5:18 PM · Restricted Project, Restricted Project
jdd added a comment to D88267: Common code preparation for tblgen-types patch.

Integrated feedback

Sep 24 2020, 5:16 PM · Restricted Project, Restricted Project
jdd updated the diff for D88267: Common code preparation for tblgen-types patch.

Corrections based on feedback

Sep 24 2020, 5:15 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Doesn't cleanly apply to current master. Fixing.

Sep 24 2020, 2:26 PM · Restricted Project, Restricted Project

Sep 18 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Adding ::get method to classes so we can keep storage types in the cpp file.

Sep 18 2020, 6:41 PM · Restricted Project, Restricted Project

Sep 17 2020

jdd added a comment to D86904: [mlir] Support for defining Types in tblgen.

Addressed

Sep 17 2020, 5:46 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Changed 'memebers' to 'parameters' and addressed existing review comments

Sep 17 2020, 5:43 PM · Restricted Project, Restricted Project

Sep 16 2020

jdd added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Sep 16 2020, 12:42 PM · Restricted Project, Restricted Project
jdd added a comment to D86904: [mlir] Support for defining Types in tblgen.

It looks like the test build didn't happen... Am I right? Did I do something wrong?

Sep 16 2020, 12:22 PM · Restricted Project, Restricted Project

Sep 15 2020

jdd updated the summary of D86904: [mlir] Support for defining Types in tblgen.
Sep 15 2020, 11:22 PM · Restricted Project, Restricted Project
jdd retitled D86904: [mlir] Support for defining Types in tblgen from [mlir] [InProgress] Support for defining Types in tblgen to [mlir] Support for defining Types in tblgen.
Sep 15 2020, 11:11 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.
Sep 15 2020, 11:10 PM · Restricted Project, Restricted Project

Sep 11 2020

jdd added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Sep 11 2020, 2:56 PM · Restricted Project, Restricted Project

Sep 1 2020

jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Restoring old revision

Sep 1 2020, 4:49 PM · Restricted Project, Restricted Project
jdd updated the diff for D86904: [mlir] Support for defining Types in tblgen.

Moved hash_value(float) to hashing.h, fixed clang-tidy warnings

Sep 1 2020, 4:46 PM · Restricted Project, Restricted Project

Aug 31 2020

jdd retitled D86904: [mlir] Support for defining Types in tblgen from [mlir] Support for defining Types in tblgen to [mlir] [InProgress] Support for defining Types in tblgen.
Aug 31 2020, 8:35 PM · Restricted Project, Restricted Project
jdd retitled D86904: [mlir] Support for defining Types in tblgen from Support for defining Types in tblgen to [mlir] Support for defining Types in tblgen.
Aug 31 2020, 8:29 PM · Restricted Project, Restricted Project
jdd requested review of D86904: [mlir] Support for defining Types in tblgen.
Aug 31 2020, 8:28 PM · Restricted Project, Restricted Project
jdd abandoned D86903: Test fixes.
Aug 31 2020, 8:26 PM · Restricted Project
jdd requested review of D86903: Test fixes.
Aug 31 2020, 8:20 PM · Restricted Project

Jul 23 2020

jdd added inline comments to D84339: [mlir] First-party modeling of LLVM types.
Jul 23 2020, 11:06 AM · Restricted Project