Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
The semantics of async or not is *very* different from most analysis point of view. It isn't clear to me that having a single op for modeling both instead of a new operation is the right tradeoff here: I'm afraid it is too error prone.
I generally agree with this, but I'm also struggling to come up with any optimizations we would actually want to do on gpu.launch_func.
Can you remove the printing of the extra attribute?
mlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir | ||
---|---|---|
23 | It is sad that this gets printed. I assume there currently is no way around this with assemblyFormat. Does this roundtrip when reparsed? I assume operand_segment_sizes just gets overwritten with the constructed attribute. |
Switch two test instances of gpu.launch_func from standard form to custom form. Rebase.
mlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir | ||
---|---|---|
23 | That was the standard format. Changed to custom format now. |
I reverted because it seems a test was crashing here: https://buildkite.com/mlir/mlir-core/builds/8962#330b9ea4-53a6-4ec9-8d10-5b40b806aa41
(I hope I got the right patch)
It is sad that this gets printed. I assume there currently is no way around this with assemblyFormat. Does this roundtrip when reparsed? I assume operand_segment_sizes just gets overwritten with the constructed attribute.