Page MenuHomePhabricator

[mlir][openacc] Add if, deviceptr operands and default attribute
ClosedPublic

Authored by clementval on Sep 25 2020, 12:39 PM.

Details

Summary

Add operands to represent if and deviceptr. Default clause is represented with
an attribute.

Diff Detail

Unit TestsFailed

TimeTest
24,740 mslinux > LLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

clementval created this revision.Sep 25 2020, 12:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2020, 12:39 PM
clementval requested review of this revision.Sep 25 2020, 12:39 PM

LGTM.

mlir/test/Dialect/OpenACC/ops.mlir
522

default = none would look better. But i guess this is due to a mix of the name you chose and the assembly format.

This revision is now accepted and ready to land.Sep 26 2020, 6:22 AM
This revision was landed with ongoing or failed builds.Sep 27 2020, 6:28 PM
This revision was automatically updated to reflect the committed changes.