This patch remove the printer/parser for the acc.data operation since its syntax
fits nicely with the assembly format. It reduces the maintenance for this op.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I understand that this patch is just changing to assembly format but #just-asking, the following clauses are missing.
if( condition )
deviceptr( var-list )
default( none | present )
mlir/test/Dialect/OpenACC/ops.mlir | ||
---|---|---|
124 | Is this separation of variables and types due to using assembly format? The previous style might be better for longer heterogeneous lists. |
mlir/test/Dialect/OpenACC/ops.mlir | ||
---|---|---|
124 | Yeah this is because of the assembly format. I'm not aware of a way to keep the previous style without custom parser. All operation I have seen using assembly format have variadic operand set this way. |
Comment Actions
Thanks for the review. If you have time can you have a look at D88326 since it is the first patch of the serie.