This is an archive of the discontinued LLVM Phabricator instance.

Differential D88142

fix a mistake in RISCVInstrInfoV.td
ClosedPublic

Authored by achieveartificialintelligence on Sep 23 2020, 3:19 AM.

Details

Reviewers
HsiangKai
rogfer01
evandro
fpallares
simoncook
kito-cheng
Commits
rG2de693756fef: [RISCV] fix a mistake in RISCVInstrInfoV.td
Summary

comment in the class VALUVVNoVm
op vd, vs1, vs2
should be
 op vd, vs2, vs1

Diff Detail

Event Timeline

achieveartificialintelligence created this revision.Sep 23 2020, 3:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2020, 3:19 AM
Herald added subscribers: llvm-commits, luismarques, apazos and 22 others. · View Herald Transcript
achieveartificialintelligence requested review of this revision.Sep 23 2020, 3:19 AM
Herald added a subscriber: MaskRay. · View Herald TranscriptSep 23 2020, 3:19 AM
Harbormaster completed remote builds in B72639: Diff 293682.Sep 23 2020, 3:53 AM
HsiangKai accepted this revision.Oct 15 2020, 7:49 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Oct 15 2020, 7:49 AM
Herald added a subscriber: NickHung. · View Herald TranscriptOct 15 2020, 7:49 AM
Closed by commit rG2de693756fef: [RISCV] fix a mistake in RISCVInstrInfoV.td (authored by sunshaoce <llvm@foxmail.com>). · Explain WhyOct 15 2020, 8:17 AM
This revision was automatically updated to reflect the committed changes.
achieveartificialintelligence added a commit: rG2de693756fef: [RISCV] fix a mistake in RISCVInstrInfoV.td.

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
2 lines

Diff 298390

llvm/lib/Target/RISCV/RISCVInstrInfoV.td

Show First 20 Lines • Show All 210 Lines • ▼ Show 20 Lines
} }
// op vd, vs1, vs2, vm (reverse the order of vs1 and vs2) // op vd, vs1, vs2, vm (reverse the order of vs1 and vs2)
class VALUrVV<bits<6> funct6, RISCVVFormat opv, string opcodestr> class VALUrVV<bits<6> funct6, RISCVVFormat opv, string opcodestr>
: RVInstVV<funct6, opv, (outs VRegOp:$vd), : RVInstVV<funct6, opv, (outs VRegOp:$vd),
(ins VRegOp:$vs1, VRegOp:$vs2, VMaskOp:$vm), (ins VRegOp:$vs1, VRegOp:$vs2, VMaskOp:$vm),
opcodestr, "$vd, $vs1, $vs2$vm">; opcodestr, "$vd, $vs1, $vs2$vm">;
// op vd, vs1, vs2 // op vd, vs2, vs1
class VALUVVNoVm<bits<6> funct6, RISCVVFormat opv, string opcodestr> class VALUVVNoVm<bits<6> funct6, RISCVVFormat opv, string opcodestr>
: RVInstVV<funct6, opv, (outs VRegOp:$vd), : RVInstVV<funct6, opv, (outs VRegOp:$vd),
(ins VRegOp:$vs2, VRegOp:$vs1), (ins VRegOp:$vs2, VRegOp:$vs1),
opcodestr, "$vd, $vs2, $vs1"> { opcodestr, "$vd, $vs2, $vs1"> {
let vm = 1; let vm = 1;
} }
// op vd, vs2, rs1, vm // op vd, vs2, rs1, vm
▲ Show 20 Lines • Show All 914 Lines • Show Last 20 Lines