- User Since
- Feb 28 2019, 2:06 AM (120 w, 3 d)
Jul 28 2020
Aside from the minor nit below this patch LGTM. Thanks a lot for all the changes @HsiangKai.
Jul 27 2020
Thanks for the update @HsiangKai.
Jul 16 2020
Apologies we didn't identify this earlier but with the change of the mask register layout (MLEN=1) the overlap constraints involving the mask register were modified:
Jul 15 2020
Jul 13 2020
Jul 1 2020
Jun 22 2020
Hi @HsiangKai, thanks for the patch. So far everything looks good aside from a couple of minor nits.
Jun 8 2020
I'm not a reviewer but the patch LGTM, thanks for all the changes @HsiangKai.
May 25 2020
I've added a couple more inline comments.
May 21 2020
May 20 2020
Hi Kai, I've added an inline comment regarding constraint validation:
Mar 6 2020
Feb 19 2020
Feb 14 2020
Thanks for addressing my comments @HsiangKai. After a closer look I've added some more inline comments, and some general ones too:
Feb 4 2020
Thanks for updating the patch to the stable v0.8 release (previously version 0.8-draft-20191213). I've added some inline comments.
Nov 19 2019
I believe I'm having a problem with Archer when I run the OpenMP tests with an architecture that doesn't support TSan yet:
Nov 15 2019
Hi, thank you for this patch!
Jul 24 2019
I've tested this patch with current upstream LLVM and Clang on a HiFive Unleashed board and all tests are passing, including OMPT. I don't have commit access yet, @Hahnfeld would you mind commiting this for me? Thank you!
Jul 18 2019
Now that D60456 has landed we believe this need not be WIP anymore.
Thanks @Hahnfeld for the review. I've just updated the patch.
Remove reset of exit_frame pointer for OMPT since it is now done at call-site and fix return address computation macro used for some tests (as the generated code has changed).
Thank you @jlpeyton!
Jul 17 2019
I've noticed some tests in libomp still have the REQUIRES: openmp-4.5 or REQUIRES: openmp-4.0 constraints. Given that the REQUIRES: openmp-5.0 have been removed I am wondering whether this may be an oversight. Those tests are currently not run, as lit considers them unsupported.
Mar 29 2019
Mar 28 2019
Thanks for the quick review @Hahnfeld, I've just replied to your inline comments and updated the patch!
Update print_possible_return_addresses macro in runtime/test/ompt/callback.h to handle uncompressed instructions, as pointed out by @Hahnfeld.
Mar 27 2019
Mar 12 2019
I'm glad it helps, thank you for your time!
Great, thank you for reviewing!
Mar 11 2019
Thank you. I've updated the test using 'update_llc_test_checks.py' and I've added a comment as suggested.
Thank you Alex. I've updated the test name and I've added a comment.
Hope it looks better now.