Page MenuHomePhabricator

fpallares (Ferran Pallarès Roca)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 2:06 AM (25 w, 2 d)

Recent Activity

Jul 24 2019

Herald added a reviewer for D59880: [OpenMP] RISCV64 port: jdoerfert.

I've tested this patch with current upstream LLVM and Clang on a HiFive Unleashed board and all tests are passing, including OMPT. I don't have commit access yet, @Hahnfeld would you mind commiting this for me? Thank you!

Jul 24 2019, 12:54 AM · Restricted Project

Jul 18 2019

fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Now that D60456 has landed we believe this need not be WIP anymore.

Jul 18 2019, 9:26 AM · Restricted Project
fpallares retitled D59880: [OpenMP] RISCV64 port from [OpenMP][WIP] RISCV64 port to [OpenMP] RISCV64 port.
Jul 18 2019, 9:26 AM · Restricted Project
fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Thanks @Hahnfeld for the review. I've just updated the patch.

Jul 18 2019, 9:25 AM · Restricted Project
fpallares updated the diff for D59880: [OpenMP] RISCV64 port.

Remove reset of exit_frame pointer for OMPT since it is now done at call-site and fix return address computation macro used for some tests (as the generated code has changed).

Jul 18 2019, 9:16 AM · Restricted Project
fpallares added a comment to rL365963: [OpenMP] Remove OMP spec versioning.

Thank you @jlpeyton!

Jul 18 2019, 2:03 AM

Jul 17 2019

fpallares added a comment to rL365963: [OpenMP] Remove OMP spec versioning.

I've noticed some tests in libomp still have the REQUIRES: openmp-4.5 or REQUIRES: openmp-4.0 constraints. Given that the REQUIRES: openmp-5.0 have been removed I am wondering whether this may be an oversight. Those tests are currently not run, as lit considers them unsupported.

Jul 17 2019, 12:34 AM

Mar 29 2019

fpallares retitled D59880: [OpenMP] RISCV64 port from [WIP] RISCV64 port to [OpenMP][WIP] RISCV64 port.
Mar 29 2019, 4:42 AM · Restricted Project

Mar 28 2019

fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Thanks for the quick review @Hahnfeld, I've just replied to your inline comments and updated the patch!

Mar 28 2019, 3:37 AM · Restricted Project
fpallares updated the diff for D59880: [OpenMP] RISCV64 port.

Update print_possible_return_addresses macro in runtime/test/ompt/callback.h to handle uncompressed instructions, as pointed out by @Hahnfeld.

Mar 28 2019, 3:32 AM · Restricted Project

Mar 27 2019

fpallares created D59880: [OpenMP] RISCV64 port.
Mar 27 2019, 8:06 AM · Restricted Project

Mar 12 2019

fpallares added a comment to D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

I'm glad it helps, thank you for your time!

Mar 12 2019, 1:56 AM · Restricted Project
fpallares added a comment to D59209: Allow fp as an alias of s0.

Great, thank you for reviewing!

Mar 12 2019, 1:56 AM · Restricted Project

Mar 11 2019

fpallares updated the diff for D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

Thank you. I've updated the test using 'update_llc_test_checks.py' and I've added a comment as suggested.

Mar 11 2019, 10:14 AM · Restricted Project
fpallares updated the diff for D59209: Allow fp as an alias of s0.

Thank you Alex. I've updated the test name and I've added a comment.
Hope it looks better now.

Mar 11 2019, 9:42 AM · Restricted Project
fpallares created D59209: Allow fp as an alias of s0.
Mar 11 2019, 7:19 AM · Restricted Project
fpallares added a comment to D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

Ping.

Mar 11 2019, 2:49 AM · Restricted Project

Mar 1 2019

fpallares created D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.
Mar 1 2019, 7:17 AM · Restricted Project