- User Since
- Feb 28 2019, 2:06 AM (25 w, 2 d)
Jul 24 2019
I've tested this patch with current upstream LLVM and Clang on a HiFive Unleashed board and all tests are passing, including OMPT. I don't have commit access yet, @Hahnfeld would you mind commiting this for me? Thank you!
Jul 18 2019
Now that D60456 has landed we believe this need not be WIP anymore.
Thanks @Hahnfeld for the review. I've just updated the patch.
Remove reset of exit_frame pointer for OMPT since it is now done at call-site and fix return address computation macro used for some tests (as the generated code has changed).
Thank you @jlpeyton!
Jul 17 2019
I've noticed some tests in libomp still have the REQUIRES: openmp-4.5 or REQUIRES: openmp-4.0 constraints. Given that the REQUIRES: openmp-5.0 have been removed I am wondering whether this may be an oversight. Those tests are currently not run, as lit considers them unsupported.
Mar 29 2019
Mar 28 2019
Thanks for the quick review @Hahnfeld, I've just replied to your inline comments and updated the patch!
Update print_possible_return_addresses macro in runtime/test/ompt/callback.h to handle uncompressed instructions, as pointed out by @Hahnfeld.
Mar 27 2019
Mar 12 2019
I'm glad it helps, thank you for your time!
Great, thank you for reviewing!
Mar 11 2019
Thank you. I've updated the test using 'update_llc_test_checks.py' and I've added a comment as suggested.
Thank you Alex. I've updated the test name and I've added a comment.
Hope it looks better now.