Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

fpallares (Ferran Pallarès Roca)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 2:06 AM (249 w, 19 h)

Recent Activity

Jul 28 2020

fpallares added inline comments to D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 28 2020, 1:51 AM · Restricted Project, Restricted Project
fpallares accepted D80802: [RISCV] Upgrade RVV MC to v0.9..

Aside from the minor nit below this patch LGTM. Thanks a lot for all the changes @HsiangKai.

Jul 28 2020, 1:48 AM · Restricted Project, Restricted Project

Jul 27 2020

fpallares added a comment to D80802: [RISCV] Upgrade RVV MC to v0.9..

Thanks for the update @HsiangKai.

Jul 27 2020, 4:27 AM · Restricted Project, Restricted Project

Jul 16 2020

fpallares added a comment to D80802: [RISCV] Upgrade RVV MC to v0.9..

Apologies we didn't identify this earlier but with the change of the mask register layout (MLEN=1) the overlap constraints involving the mask register were modified:

Jul 16 2020, 7:37 AM · Restricted Project, Restricted Project

Jul 15 2020

fpallares added inline comments to D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 15 2020, 10:08 AM · Restricted Project, Restricted Project

Jul 13 2020

fpallares added inline comments to D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 13 2020, 9:17 AM · Restricted Project, Restricted Project

Jul 1 2020

fpallares added inline comments to D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 1 2020, 6:28 AM · Restricted Project, Restricted Project
fpallares added inline comments to D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 1 2020, 5:22 AM · Restricted Project, Restricted Project

Jun 22 2020

fpallares added a comment to D80802: [RISCV] Upgrade RVV MC to v0.9..

Hi @HsiangKai, thanks for the patch. So far everything looks good aside from a couple of minor nits.

Jun 22 2020, 9:39 AM · Restricted Project, Restricted Project

Jun 8 2020

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

I'm not a reviewer but the patch LGTM, thanks for all the changes @HsiangKai.

Jun 8 2020, 7:05 AM · Restricted Project, Restricted Project

May 25 2020

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

I've added a couple more inline comments.

May 25 2020, 10:42 AM · Restricted Project, Restricted Project

May 21 2020

fpallares added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 21 2020, 1:04 AM · Restricted Project, Restricted Project

May 20 2020

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Hi Kai, I've added an inline comment regarding constraint validation:

May 20 2020, 10:54 AM · Restricted Project, Restricted Project
fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 20 2020, 10:54 AM · Restricted Project, Restricted Project

Mar 6 2020

fpallares added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Mar 6 2020, 2:46 AM · Restricted Project, Restricted Project

Feb 19 2020

fpallares added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Feb 19 2020, 2:23 AM · Restricted Project, Restricted Project

Feb 14 2020

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Thanks for addressing my comments @HsiangKai. After a closer look I've added some more inline comments, and some general ones too:

Feb 14 2020, 8:50 AM · Restricted Project, Restricted Project

Feb 4 2020

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Thanks for updating the patch to the stable v0.8 release (previously version 0.8-draft-20191213). I've added some inline comments.

Feb 4 2020, 5:10 AM · Restricted Project, Restricted Project

Nov 19 2019

fpallares added a comment to rG2b8115b10b03: [OpenMP] Add implementation and tests of Archer tool.

I believe I'm having a problem with Archer when I run the OpenMP tests with an architecture that doesn't support TSan yet:

Nov 19 2019, 3:29 AM

Nov 15 2019

fpallares added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Hi, thank you for this patch!

Nov 15 2019, 11:08 AM · Restricted Project, Restricted Project

Jul 24 2019

Herald added a reviewer for D59880: [OpenMP] RISCV64 port: jdoerfert.

I've tested this patch with current upstream LLVM and Clang on a HiFive Unleashed board and all tests are passing, including OMPT. I don't have commit access yet, @Hahnfeld would you mind commiting this for me? Thank you!

Jul 24 2019, 12:54 AM · Restricted Project

Jul 18 2019

fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Now that D60456 has landed we believe this need not be WIP anymore.

Jul 18 2019, 9:26 AM · Restricted Project
fpallares retitled D59880: [OpenMP] RISCV64 port from [OpenMP][WIP] RISCV64 port to [OpenMP] RISCV64 port.
Jul 18 2019, 9:26 AM · Restricted Project
fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Thanks @Hahnfeld for the review. I've just updated the patch.

Jul 18 2019, 9:25 AM · Restricted Project
fpallares updated the diff for D59880: [OpenMP] RISCV64 port.

Remove reset of exit_frame pointer for OMPT since it is now done at call-site and fix return address computation macro used for some tests (as the generated code has changed).

Jul 18 2019, 9:16 AM · Restricted Project
fpallares added a comment to rL365963: [OpenMP] Remove OMP spec versioning.

Thank you @jlpeyton!

Jul 18 2019, 2:03 AM

Jul 17 2019

fpallares added a comment to rL365963: [OpenMP] Remove OMP spec versioning.

I've noticed some tests in libomp still have the REQUIRES: openmp-4.5 or REQUIRES: openmp-4.0 constraints. Given that the REQUIRES: openmp-5.0 have been removed I am wondering whether this may be an oversight. Those tests are currently not run, as lit considers them unsupported.

Jul 17 2019, 12:34 AM

Mar 29 2019

fpallares retitled D59880: [OpenMP] RISCV64 port from [WIP] RISCV64 port to [OpenMP][WIP] RISCV64 port.
Mar 29 2019, 4:42 AM · Restricted Project

Mar 28 2019

fpallares added a comment to D59880: [OpenMP] RISCV64 port.

Thanks for the quick review @Hahnfeld, I've just replied to your inline comments and updated the patch!

Mar 28 2019, 3:37 AM · Restricted Project
fpallares updated the diff for D59880: [OpenMP] RISCV64 port.

Update print_possible_return_addresses macro in runtime/test/ompt/callback.h to handle uncompressed instructions, as pointed out by @Hahnfeld.

Mar 28 2019, 3:32 AM · Restricted Project

Mar 27 2019

fpallares created D59880: [OpenMP] RISCV64 port.
Mar 27 2019, 8:06 AM · Restricted Project

Mar 12 2019

fpallares added a comment to D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

I'm glad it helps, thank you for your time!

Mar 12 2019, 1:56 AM · Restricted Project
fpallares added a comment to D59209: Allow fp as an alias of s0.

Great, thank you for reviewing!

Mar 12 2019, 1:56 AM · Restricted Project

Mar 11 2019

fpallares updated the diff for D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

Thank you. I've updated the test using 'update_llc_test_checks.py' and I've added a comment as suggested.

Mar 11 2019, 10:14 AM · Restricted Project
fpallares updated the diff for D59209: Allow fp as an alias of s0.

Thank you Alex. I've updated the test name and I've added a comment.
Hope it looks better now.

Mar 11 2019, 9:42 AM · Restricted Project
fpallares created D59209: Allow fp as an alias of s0.
Mar 11 2019, 7:19 AM · Restricted Project
fpallares added a comment to D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.

Ping.

Mar 11 2019, 2:49 AM · Restricted Project

Mar 1 2019

fpallares created D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A.
Mar 1 2019, 7:17 AM · Restricted Project