Differential D88102

[mlir][openacc] Add update operation
ClosedPublic
Actions

Authored by clementval on Sep 22 2020, 8:54 AM.

Details

Reviewers

mehdi_amini
rriddle
ftynse
kiranktp
kiranchandramohan
SouraVX

Commits

rGecc997807180: [mlir][openacc] Add update operation

Summary

This patch introduce the update operation that represent the OpenACC update directive.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

clementval created this revision.Sep 22 2020, 8:54 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 8:54 AM

Herald added subscribers: tatianashp, msifontes, jurahul and 11 others. · View Herald Transcript

clementval requested review of this revision.Sep 22 2020, 8:54 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptSep 22 2020, 8:54 AM

Harbormaster completed remote builds in B72527: Diff 293476.Sep 22 2020, 9:11 AM

Remove region from parse function comment

Use correct attribute

Harbormaster completed remote builds in B72569: Diff 293545.Sep 22 2020, 1:19 PM

Harbormaster completed remote builds in B72570: Diff 293546.Sep 22 2020, 1:23 PM

Switch to assembly format.

Harbormaster completed remote builds in B72713: Diff 293833.Sep 23 2020, 12:56 PM

rriddle added inline comments.Sep 28 2020, 9:57 AM

mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
348	Are any of these necessary?
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
810	Return this error directly, it auto-converts to failure.
817	nit: Drop trivial braces.
818	Missing returns for each of these errors.

clementval marked 4 inline comments as done.Sep 28 2020, 10:28 AM

clementval added inline comments.

mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
348	Not really. Just removed them.

Address review comments

Harbormaster completed remote builds in B73196: Diff 294749.Sep 28 2020, 10:41 AM

ftynse accepted this revision.Sep 29 2020, 4:51 AM

ftynse added inline comments.

mlir/test/Dialect/OpenACC/invalid.mlir
72	Nit: we usually don't capitalize error messages

This revision is now accepted and ready to land.Sep 29 2020, 4:51 AM

Address review comments

Rebase

This revision was landed with ongoing or failed builds.Sep 29 2020, 6:58 AM

Closed by commit rGecc997807180: [mlir][openacc] Add update operation (authored by clementval). · Explain Why

This revision was automatically updated to reflect the committed changes.

clementval added a commit: rGecc997807180: [mlir][openacc] Add update operation.

Harbormaster completed remote builds in B73333: Diff 294967.Sep 29 2020, 7:05 AM

Harbormaster completed remote builds in B73329: Diff 294961.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

OpenACC/

40 lines

lib/

Dialect/

OpenACC/

IR/

24 lines

test/

Dialect/

OpenACC/

24 lines

30 lines

Diff 294961

mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td

Loading...

mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp

Loading...

mlir/test/Dialect/OpenACC/invalid.mlir

Loading...

mlir/test/Dialect/OpenACC/ops.mlir

Loading...