[MLIR][NFC] Adopt use of TypeRange in build() methods.
ClosedPublic
Actions

Authored by jurahul on Sep 18 2020, 2:22 PM.

Details

Reviewers

rriddle
antiagainst
aartbik
ftynse
nicolasvasilache
herhut
jpienaar

Commits

rG08e4f078523b: [MLIR][NFC] Adopt use of TypeRange in build() methods.

Summary

Use TypeRange instead of ArrayRef<Type> where possible.
Change some of the custom builders to also use TypeRange

Depends On D87926

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jurahul created this revision.Sep 18 2020, 2:22 PM

Herald added a reviewer: rriddle. · View Herald TranscriptSep 18 2020, 2:22 PM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: tatianashp, msifontes, Kayjukh and 13 others. · View Herald Transcript

jurahul requested review of this revision.Sep 18 2020, 2:22 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 18 2020, 2:22 PM

Herald added a reviewer: herhut. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

jurahul added a reviewer: jpienaar.Sep 18 2020, 2:22 PM

Harbormaster completed remote builds in B72243: Diff 292898.Sep 18 2020, 2:42 PM

jurahul added a child revision: D87955: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>.Sep 18 2020, 4:40 PM

jpienaar accepted this revision.Sep 21 2020, 10:14 AM

This revision is now accepted and ready to land.Sep 21 2020, 10:14 AM

Rebase

Harbormaster completed remote builds in B72616: Diff 293636.Sep 22 2020, 9:17 PM

This revision was landed with ongoing or failed builds.Sep 23 2020, 9:08 AM

Closed by commit rG08e4f078523b: [MLIR][NFC] Adopt use of TypeRange in build() methods. (authored by jurahul). · Explain Why

This revision was automatically updated to reflect the committed changes.

jurahul added a commit: rG08e4f078523b: [MLIR][NFC] Adopt use of TypeRange in build() methods..

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

Affine/

IR/

AffineOps.td

6 lines

GPU/

GPUOps.td

4 lines

LLVMIR/

LLVMOps.td

4 lines

Linalg/

IR/

LinalgStructuredOps.td

8 lines

LinalgStructuredOpsInterface.td

2 lines

StandardOps/

IR/

Ops.td

6 lines

lib/

Conversion/

GPUToVulkan/

ConvertGPULaunchFuncToVulkanLaunchFunc.cpp

2 lines

ConvertLaunchFuncToVulkanCalls.cpp

35 lines

LinalgToStandard/

LinalgToStandard.cpp

6 lines

OpenMPToLLVM/

OpenMPToLLVM.cpp

4 lines

StandardToLLVM/

StandardToLLVM.cpp

10 lines

VectorToLLVM/

ConvertVectorToLLVM.cpp

2 lines

Dialect/

Affine/

IR/

AffineOps.cpp

6 lines

GPU/

IR/

GPUDialect.cpp

4 lines

LLVMIR/

IR/

LLVMDialect.cpp

4 lines

Linalg/

IR/

LinalgOps.cpp

24 lines

test/

lib/

Dialect/

Test/

TestDialect.cpp

2 lines

unittests/

TableGen/

OpBuildGen.cpp

64 lines

Diff 293766

View Options

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

View Options

mlir/include/mlir/Dialect/GPU/GPUOps.td

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

View Options

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td

View Options

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td

View Options

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

View Options

mlir/lib/Conversion/GPUToVulkan/ConvertGPULaunchFuncToVulkanLaunchFunc.cpp

View Options

mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp

View Options

mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp

View Options

mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp

View Options

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

View Options

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

View Options

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

View Options

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

View Options

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

View Options

mlir/test/lib/Dialect/Test/TestDialect.cpp

View Options

mlir/unittests/TableGen/OpBuildGen.cpp

[MLIR][NFC] Adopt use of TypeRange in build() methods.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 293766

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

mlir/include/mlir/Dialect/GPU/GPUOps.td

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

mlir/lib/Conversion/GPUToVulkan/ConvertGPULaunchFuncToVulkanLaunchFunc.cpp

mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp

mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp

mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

mlir/test/lib/Dialect/Test/TestDialect.cpp

mlir/unittests/TableGen/OpBuildGen.cpp

[MLIR][NFC] Adopt use of TypeRange in build() methods.
ClosedPublic
Actions

Revision Contents
Changeset List