This tweaks the generated code for parsing attributes with a custom
directive to call addAttribute on the OperationState directly,
and adds a newline after this call. Previously, the generated code
would call addAttribute on the OperationState field attributes,
which has no such method and fails to compile. Furthermore, the lack
of newline would generate code with incorrectly formatted single line
if statements. Added tests for parsing and printing attributes with
a custom directive.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
It wasn't clear from the description that this is actually fixing something that wasn't working, can you update the description in the commit?
Comment Actions
Update description about custom directive attribute parsing
This adds some description about the issue and why this revision was needed.
Comment Actions
@mehdi_amini I've amended the commit description to include some background on the issue this revision intends to fix.
Comment Actions
This is my first contribution to LLVM, so I will need need some assistance per the policy. @mehdi_amini as the reviewer, do you mind committing this on my behalf? Not sure if this is already associated in Phabricator, but my name is Mike Urbach, and email is mikeurbach@gmail.com. The GitHub username is also mikeurbach, if that is needed.