Page MenuHomePhabricator

mikeurbach (Mike Urbach)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2020, 10:22 AM (9 w, 4 d)

Recent Activity

Tue, Nov 3

mikeurbach abandoned D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

This revision was superseded by https://reviews.llvm.org/D90363.

Tue, Nov 3, 4:04 PM · Restricted Project
mikeurbach committed rG2e36e0dad52b: [MLIR] Move eraseArguments and eraseResults to FunctionLike (authored by mikeurbach).
[MLIR] Move eraseArguments and eraseResults to FunctionLike
Tue, Nov 3, 3:54 PM
mikeurbach closed D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.
Tue, Nov 3, 3:54 PM · Restricted Project
mikeurbach updated the diff for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Updates after review.

Tue, Nov 3, 3:16 PM · Restricted Project
mikeurbach added a comment to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Awesome, thanks for taking a look. Those final comments all make sense.. I will clean those up.

Tue, Nov 3, 12:47 PM · Restricted Project
mikeurbach added a comment to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

@rriddle when you get a chance, please take another look. I think I've addressed your comments from the previous revision.

Tue, Nov 3, 12:34 PM · Restricted Project
mikeurbach updated the diff for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Remove unused file from previous revision.

Tue, Nov 3, 12:22 PM · Restricted Project
mikeurbach updated the diff for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Refactor implementations into FunctionSupport.cpp, and address other comments.

Tue, Nov 3, 12:18 PM · Restricted Project

Fri, Oct 30

mikeurbach added inline comments to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.
Fri, Oct 30, 1:56 PM · Restricted Project
mikeurbach added inline comments to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.
Fri, Oct 30, 9:07 AM · Restricted Project

Thu, Oct 29

mikeurbach updated the diff for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Moved BitVector creation into a helper in Support.

Thu, Oct 29, 12:33 PM · Restricted Project
mikeurbach added inline comments to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.
Thu, Oct 29, 9:46 AM · Restricted Project

Wed, Oct 28

mikeurbach updated the diff for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

Add missing header guard to new header file.

Wed, Oct 28, 8:19 PM · Restricted Project
mikeurbach added reviewers for D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike: ftynse, mravishankar.
Wed, Oct 28, 8:13 PM · Restricted Project
mikeurbach updated subscribers of D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

I took a slightly different approach here compared to the previous implementation. Rather than requiring a new hook on the concrete ops, I just added a member function on FunctionLike and defined it in terms of FunctionType. To me, this isn't much different than how getType and setType work today. By doing it this way, existing FunctionLike ops do not need to change, and can immediately access the new functionality. However, this doesn't really fix the assumption we are using FunctionType, and indeed perpetuates it. I updated the comments to try to be more explicit about this and what concrete ops need to do if they want this functionality and want to use their own function type.

Wed, Oct 28, 8:12 PM · Restricted Project
mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Well, I tried to share my updates and ended up creating a new revision, that is here now: https://reviews.llvm.org/D90363

Wed, Oct 28, 7:24 PM · Restricted Project
mikeurbach requested review of D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.
Wed, Oct 28, 7:22 PM · Restricted Project

Tue, Oct 27

mikeurbach added inline comments to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Tue, Oct 27, 11:55 AM · Restricted Project
mikeurbach added inline comments to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Tue, Oct 27, 8:45 AM · Restricted Project

Mon, Oct 26

mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Thanks for the feedback. A couple questions to inline comments, otherwise I'm addressing the rest of the comments.

Mon, Oct 26, 8:14 PM · Restricted Project
mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Can this logic be generalized for all Regions? In the patch https://reviews.llvm.org/D90118 I need to drop arguments for region of an linalg::IndexedGenericOp. Having this method there would be more ergonomic.

Mon, Oct 26, 1:13 PM · Restricted Project

Oct 23 2020

mikeurbach removed reviewers for D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike: mravishankar, antiagainst, rriddle, ftynse, herhut.
Oct 23 2020, 3:07 PM · Restricted Project
mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

I'm not sure if there is a way to mark this as a draft, but please consider it as such. I'm trying to illustrate the ideas discussed here: https://llvm.discourse.group/t/moving-erasearguments-from-funcop-to-functionlike/2016.

Oct 23 2020, 3:04 PM · Restricted Project
mikeurbach requested review of D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Oct 23 2020, 2:50 PM · Restricted Project

Sep 23 2020

mikeurbach added a comment to D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

This is my first contribution to LLVM, so I will need need some assistance per the policy. @mehdi_amini as the reviewer, do you mind committing this on my behalf? Not sure if this is already associated in Phabricator, but my name is Mike Urbach, and email is mikeurbach@gmail.com. The GitHub username is also mikeurbach, if that is needed.

Sep 23 2020, 11:01 AM · Restricted Project
mikeurbach updated the diff for D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

Use arc diff --edit --verbatim to update summary

Sep 23 2020, 10:59 AM · Restricted Project
mikeurbach added a comment to D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

@mehdi_amini I've amended the commit description to include some background on the issue this revision intends to fix.

Sep 23 2020, 10:00 AM · Restricted Project
mikeurbach updated the diff for D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

Update description about custom directive attribute parsing

Sep 23 2020, 9:58 AM · Restricted Project

Sep 17 2020

mikeurbach requested review of D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..
Sep 17 2020, 2:57 PM · Restricted Project