- User Since
- Sep 16 2020, 10:22 AM (9 w, 4 d)
Tue, Nov 3
This revision was superseded by https://reviews.llvm.org/D90363.
Updates after review.
Awesome, thanks for taking a look. Those final comments all make sense.. I will clean those up.
@rriddle when you get a chance, please take another look. I think I've addressed your comments from the previous revision.
Remove unused file from previous revision.
Refactor implementations into FunctionSupport.cpp, and address other comments.
Fri, Oct 30
Thu, Oct 29
Moved BitVector creation into a helper in Support.
Wed, Oct 28
Add missing header guard to new header file.
I took a slightly different approach here compared to the previous implementation. Rather than requiring a new hook on the concrete ops, I just added a member function on FunctionLike and defined it in terms of FunctionType. To me, this isn't much different than how getType and setType work today. By doing it this way, existing FunctionLike ops do not need to change, and can immediately access the new functionality. However, this doesn't really fix the assumption we are using FunctionType, and indeed perpetuates it. I updated the comments to try to be more explicit about this and what concrete ops need to do if they want this functionality and want to use their own function type.
Well, I tried to share my updates and ended up creating a new revision, that is here now: https://reviews.llvm.org/D90363
Tue, Oct 27
Mon, Oct 26
Thanks for the feedback. A couple questions to inline comments, otherwise I'm addressing the rest of the comments.
Oct 23 2020
I'm not sure if there is a way to mark this as a draft, but please consider it as such. I'm trying to illustrate the ideas discussed here: https://llvm.discourse.group/t/moving-erasearguments-from-funcop-to-functionlike/2016.
Sep 23 2020
This is my first contribution to LLVM, so I will need need some assistance per the policy. @mehdi_amini as the reviewer, do you mind committing this on my behalf? Not sure if this is already associated in Phabricator, but my name is Mike Urbach, and email is email@example.com. The GitHub username is also mikeurbach, if that is needed.
Use arc diff --edit --verbatim to update summary
@mehdi_amini I've amended the commit description to include some background on the issue this revision intends to fix.
Update description about custom directive attribute parsing