Page MenuHomePhabricator

[SVE] Change definition of reduction ISD nodes to have an SVE vector result type.
ClosedPublic

Authored by paulwalker-arm on Sep 17 2020, 10:25 AM.

Details

Summary

The current nodes, AArch64::SMAXV_PRED for example, are defined to
return a NEON vector result. This is incorrect because they modify
the complete SVE register and are thus changed to represent such.

This patch also adds nodes for UADDV_PRED and SADDV_PRED, which
unifies the handling of all SVE reductions.

NOTE: Floating-point reductions are already implemented correctly, so this patch is essentially making everything consistent with those.

Diff Detail

Event Timeline

Herald added a reviewer: efriedma. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
paulwalker-arm requested review of this revision.Sep 17 2020, 10:25 AM
This revision is now accepted and ready to land.Sep 17 2020, 12:23 PM
This revision was landed with ongoing or failed builds.Sep 21 2020, 5:23 AM
This revision was automatically updated to reflect the committed changes.