This patch add the missing operands to the acc.loop operation. Only the device_type
information is not part of the operation for now.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/OpenACC/OpenACC.h | ||
---|---|---|
38 | This seems unrelated? | |
mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td | ||
231 | nit: UnitAttr is already an Optional construct, so this is redundant. | |
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp | ||
483–484 | nit: Remove this extra newline. | |
612 | nit: Nest this within the existing if for gangNum | |
621–635 | nit: You don't need the == ... here. | |
630 | Same here. |
@rriddle and @kiranchandramohan Thanks for the reviews. I just updated the patche to address the comments.
mlir/include/mlir/Dialect/OpenACC/OpenACC.h | ||
---|---|---|
38 | Seq is not really part of exec mapping but in group of attributes that includes auto, independent and seq and as they are mutually exclusive it doesn't really belong here anymore. | |
mlir/test/Dialect/OpenACC/ops.mlir | ||
79 | Those are UnitAttr so if they are present it means that are "active". |
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp | ||
---|---|---|
518 | nit: Drop trivial braces here. |
This seems unrelated?