Page MenuHomePhabricator

[PowerPC][PCRelative] Set TLS unsupported with PC relative memops
ClosedPublic

Authored by kamaub on Aug 6 2020, 10:32 AM.

Details

Summary

Introduce a fatal error if any thread local storage code is compiled
using pc relative memory operations as well as a hidden override
option -enable-ppc-pcrel-tls so that this support can be incrementally
added if possible.

Diff Detail

Event Timeline

kamaub created this revision.Aug 6 2020, 10:32 AM
kamaub requested review of this revision.Aug 6 2020, 10:32 AM
kamaub added a project: Restricted Project.Aug 6 2020, 10:34 AM
kamaub updated this revision to Diff 283682.Aug 6 2020, 11:20 AM

Replacing assert() with report_fatal_error()

kamaub edited the summary of this revision. (Show Details)Aug 6 2020, 11:21 AM
nemanjai accepted this revision.Aug 6 2020, 12:52 PM

Feel free to address the comment when committing the patch.

llvm/test/CodeGen/PowerPC/pcrel-tls.ll
5

This doesn't work on every configuration. Please remove it and we can add a run line once PC-Rel TLS is implemented and no longer trips the assert.

This revision is now accepted and ready to land.Aug 6 2020, 12:52 PM
kamaub marked an inline comment as done.Aug 7 2020, 8:59 AM