Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This turned out to be a slightly more complicated patch than expected due to the extract complication of NEON not supporting 64bit vector multiplies.
If I'm following correctly, this enables the use of SVE for NEON-sized vectors by default if SVE is available. I think this would actually mark the first time we're generating SVE instructions for -march=armv8.4-a+sve without the user explicitly requesting scalable vector operations, right? I'd like to see test coverage for this, at least. Or maybe we want to be more conservative for a little while...
Call me a scaredy cat but I'll take the conservative option :)
I've updated the patch to only affect 64/128-bit vector mul operations when wide vectors are enabled.
I've updated the patch to only affect 64/128-bit vector mul operations when wide vectors are enabled.
Please add test coverage for this. Otherwise LGTM
llvm/test/CodeGen/AArch64/sve-fixed-length-int-arith.ll | ||
---|---|---|
652–670 | As part of the previous revert I removed the NO_SVE check lines from these tests, which means the global "CHECK-NOT for ptrue" will apply. So I'm hoping I've got the testing covered. Please let me know if I've misunderstood and extra tests are required. |
As part of the previous revert I removed the NO_SVE check lines from these tests, which means the global "CHECK-NOT for ptrue" will apply. So I'm hoping I've got the testing covered. Please let me know if I've misunderstood and extra tests are required.