This patch renames some mapping keys:
AbbrOffset -> DebugAbbrevOffset
AddrSize -> AddressSize
AbbrCode -> AbbrevCode
Differential D85289
[DWARFYAML][debug_info] Rename some mapping keys. NFC. Higuoxing on Aug 5 2020, 3:33 AM. Authored by
Details This patch renames some mapping keys: AbbrOffset -> DebugAbbrevOffset
Diff Detail
Event TimelineComment Actions We should make these mapping keys' name consistent with the spec. Comment Actions I see the point, but we don't do it for all fields in other contexts, and I have some mild concerns that DebugAbbrevOffset is unnecessarily verbose (I'd think AbbrevOffset would be sufficient. Perhaps it would be best to draw in one or two others? @JDevlieghere / @labath, any thoughts? Comment Actions Sorry about the delay, I was OOO. I think that making these consistent with the DWARF spec is a good idea. It's true that this makes DebugAbbrevOffset a bit longish. I could also live with just AbbrevOffset, but I think the longer version is also fine for two reasons:
Comment Actions Okay, LGTM. I don't mind either way, and I suspect with the offset field becoming optional soon, it's unlikely to appear frequently, so the verbosity is a non-issue then.
|