This patch renames some mapping keys:
AbbrOffset -> DebugAbbrevOffset
AddrSize -> AddressSize
AbbrCode -> AbbrevCode
Paths
| Differential D85289
[DWARFYAML][debug_info] Rename some mapping keys. NFC. AcceptedPublic Authored by Higuoxing on Aug 5 2020, 3:33 AM.
Details Summary This patch renames some mapping keys: AbbrOffset -> DebugAbbrevOffset
Diff Detail
Unit TestsFailed Event TimelineComment Actions
We should make these mapping keys' name consistent with the spec. Comment Actions I see the point, but we don't do it for all fields in other contexts, and I have some mild concerns that DebugAbbrevOffset is unnecessarily verbose (I'd think AbbrevOffset would be sufficient. Perhaps it would be best to draw in one or two others? @JDevlieghere / @labath, any thoughts? Comment Actions
Yeah, I'm ok with these names. I would like to hear more people's ideas! Comment Actions Sorry about the delay, I was OOO. I think that making these consistent with the DWARF spec is a good idea. It's true that this makes DebugAbbrevOffset a bit longish. I could also live with just AbbrevOffset, but I think the longer version is also fine for two reasons:
Comment Actions Okay, LGTM. I don't mind either way, and I suspect with the offset field becoming optional soon, it's unlikely to appear frequently, so the verbosity is a non-issue then.
This revision is now accepted and ready to land.Aug 27 2020, 12:44 AM
Revision Contents
Diff 283187 lldb/test/API/functionalities/source-map/a.yaml
lldb/unittests/Expression/DWARFExpressionTest.cpp
lldb/unittests/Symbol/Inputs/inlined-functions.yaml
lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp
lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp
llvm/lib/ObjectYAML/DWARFYAML.cpp
llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml
llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml
llvm/test/ObjectYAML/MachO/DWARF2-AddrSize8-FormValues.yaml
llvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml
llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_cu_ranges.yaml
llvm/test/tools/llvm-gsymutil/ARM_AArch64/fat-macho-dwarf.yaml
llvm/test/tools/llvm-gsymutil/X86/mach-dwarf.yaml
llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml
llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml
llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp
llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp
|
clang-tidy: error: 'lldb/Expression/DWARFExpression.h' file not found [clang-diagnostic-error]
not useful