This is an archive of the discontinued LLVM Phabricator instance.

Differential D84727

[RISC-V] Add support for AddressSanitizer
AbandonedPublic

Authored by joshua-arch1 on Jul 27 2020, 10:50 PM.

Details

Reviewers
kito-cheng
Jim
PkmX
lenary
mgorny
fedor.sergeev
simoncook
cryptoad
shiva0217
rogfer01
rkruppe
s.egerton
sameer.abuasal
luismarques
Summary

compiler-rt/

    
* cmake/config-ix.cmake: New options for RISCV32 and RISCV64.
* test/asan/CMakeLists.txt: Ditto.

Diff Detail

Event Timeline

joshua-arch1 created this revision.Jul 27 2020, 10:50 PM
Herald added subscribers: luismarques, sameer.abuasal, s.egerton and 11 others. · View Herald TranscriptJul 27 2020, 10:50 PM
joshua-arch1 requested review of this revision.Jul 27 2020, 10:50 PM
joshua-arch1 added reviewers: kito-cheng, Jim.
joshua-arch1 added a reviewer: PkmX.Jul 27 2020, 10:52 PM
lenary added a reviewer: lenary.Jul 28 2020, 2:29 AM

There is only support for 64-bit RISC-V in the sanitizer implementation: rG977205b595c. Until the 32-bit risc-v linux ABI is stable, this should not be landed.

joshua-arch1 added reviewers: mgorny, fedor.sergeev, simoncook, cryptoad, shiva0217, rogfer01, rkruppe, s.egerton, sameer.abuasal, luismarques.Jul 28 2020, 5:37 AM
joshua-arch1 updated this revision to Diff 281888.EditedJul 30 2020, 5:24 AM

I have removed support for 32-bit RISC-V in Linux sanitizer implementation. Please review it.

joshua-arch1 added a comment.Aug 18 2020, 11:10 PM
This comment was removed by joshua-arch1.
joshua-arch1 added a comment.Aug 18 2020, 11:11 PM
In D84727#2178059, @lenary wrote:

There is only support for 64-bit RISC-V in the sanitizer implementation: rG977205b595c. Until the 32-bit risc-v linux ABI is stable, this should not be landed.

Have my patch been reviewed?

joshua-arch1 mentioned this in D86198: llvm enable sanitizer (RISCV64).Aug 19 2020, 6:57 PM
joshua-arch1 abandoned this revision.Aug 20 2020, 4:11 AM

Revision Contents

PathSize
compiler-rt/
cmake/
28 lines
test/
asan/
4 lines

Diff 281116

compiler-rt/cmake/config-ix.cmake

Context not available.
set(X86_64 x86_64 x86_64h) set(X86_64 x86_64 x86_64h)
endif() endif()
set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64} ${RISCV64} set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64} ${RISCV32} ${RISCV64}
${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9}) ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9})
set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9}) ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${RISCV32} ${RISCV64})
set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV32} ${RISCV64}) set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV32} ${RISCV64})
set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64}) set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${RISCV32} ${RISCV64})
if(ANDROID) if(ANDROID)
set(OS_NAME "Android") set(OS_NAME "Android")
Context not available.
endif() endif()
if(OS_NAME MATCHES "Linux") if(OS_NAME MATCHES "Linux")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${RISCV32} ${RISCV64})
elseif (OS_NAME MATCHES "Windows") elseif (OS_NAME MATCHES "Windows")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64})
elseif(OS_NAME MATCHES "Android") elseif(OS_NAME MATCHES "Android")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV32} ${RISCV64})
else() else()
set(ALL_FUZZER_SUPPORTED_ARCH ${X86_64} ${ARM64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86_64} ${ARM64})
endif() endif()
set(ALL_GWP_ASAN_SUPPORTED_ARCH ${X86} ${X86_64}) set(ALL_GWP_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${RISCV32} ${RISCV64})
if(APPLE) if(APPLE)
set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64}) set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64})
else() else()
set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32} ${PPC64}) set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32} ${PPC64})
endif() endif()
set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64}) set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${RISCV32} ${RISCV64})
set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64}) set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64} ${RISCV32} ${RISCV64})
set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC64} set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC64}
${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9}) ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9} ${RISCV32} ${RISCV64})
set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64}) set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${RISCV32} ${RISCV64})
set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64} set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV32} ${RISCV64}
${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9}) ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9})
set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}) set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64})
set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}) set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64} ${RISCV32} ${RISCV64})
set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64} ${RISCV32} ${RISCV64})
set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64}) set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${RISCV32} ${RISCV64})
if(APPLE) if(APPLE)
set(ALL_XRAY_SUPPORTED_ARCH ${X86_64}) set(ALL_XRAY_SUPPORTED_ARCH ${X86_64})
else() else()
Context not available.

compiler-rt/test/asan/CMakeLists.txt

Context not available.
endif() endif()
macro(get_bits_for_arch arch bits) macro(get_bits_for_arch arch bits)
if (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|arm64|mips64|mips64el|s390x|sparcv9") if (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|arm64|mips64|mips64el|s390x|sparcv9|riscv64")
set(${bits} 64) set(${bits} 64)
elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc") elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc|riscv32")
set(${bits} 32) set(${bits} 32)
else() else()
message(FATAL_ERROR "Unknown target architecture: ${arch}") message(FATAL_ERROR "Unknown target architecture: ${arch}")
Context not available.