Ping? This is the last issue blocking lld's RISC-V tests to be rewritten to use llvm-mc and llvm-objdump right now.

Abandoning as this has been implemented by another commit.

@ruiu I've uploaded a new patch that adds the blank line to RISCVGlobalPointer as requested. As I do not have commit rights to the LLD repository, could you commit the patch if there are no last-minute issues.

In D39322#1190218, @ruiu wrote:

Apologies for my belated response. I think this patch is generally looking good. One thing I'd fix before submitting is to rewrite a test using assembly. We do not usually use YAML file for testing. Is there any reason you needed to write them in YAML?

Rebased. NFC from last revision.

RISCV now writes its own GOT header, with one entry that stores the address of .dynamic section. _GLOBAL_OFFSET_TABLE_ should be set to the head of .got so that _GLOBAL_OFFSET_TABLE_[0] == &_DYNAMIC.

I've rebased the diff to latest trunk again. Some notable differences from last revision:

Rebase onto master.

Rebase onto master.

Rebase onto master.

Rebase onto latest master.

Rebase onto latest master.

Rebase onto latest master.

Implement the -R option as an alias to either --rpath or --just-symbols. It is treated as latter if the argument file exists and is not a directory.

Added a check to only allow ET_EXEC and the corresponding test.

• Copy symbol type, size, binding, etc, like D39348.
• Update test cases.

In D39348#950848, @grimar wrote:

What is your use case to specify only single --just-symbol file ?

If the only input file is specified as the argument of --just-symbol, lld will error out (ld.bfd accepts this):

Oops. It looks like I actually didn't submit some of these draft comments.

Rebase onto latest master

• Rebase onto latest master
• Clean up #includes

• Rebase onto latest master
• Clean up #includes

clang-format-diff RISCV::writePLT.

Make R_RISCV_CALL reuse R_RISCV_PCREL_HI20 and R_RISCV_PCREL_LO12_I.

I believe the best place would be either the issue tracker on the psABI doc, or RISC-V's sw-dev mailing list.

• Mark TLS_DTP_OFFSET as internal linkage.

• Use write32le.
• Since __global_pointer$ is no longer absolute, remove workaround to make it a static link-time constant in PIE.

• Use {read,write}32le to read/write insturctions.
• Make __global_pointer$ non-absolute.

De-template RISCV class.

De-template RISCV class and assume little-endian.

• Renamed uint32_t to RelType.
• Detemplate the RISCV class.

In D39322#908393, @ruiu wrote:

As you said this looks like a pretty straightforward port to RISC-V. Thank you for doing this!

IIRC, last time when we discussed RISC-V support in lld, I had a concern that linker relaxation (moving code inside a section to make it compact) is virtually mandatory to link RISC-V object files. What is the situation of it? If you can link a small static executable with this patch, then it is probably no longer mandatory, but I want to make sure that that's the case.

llvm-readobj would also need to be modified to recognize RISC-V eflags, and I think it is better to keep that in a separate commit.

Added RISC-V tests for ObjectYAML