This is an archive of the discontinued LLVM Phabricator instance.

[FunctionAttrs] Rename functionattrs -> function-attrs
ClosedPublic

Authored by aeubanks on Jul 27 2020, 12:10 PM.

Details

Summary

To match NewPM pass name, and also for readability.
Also rename rpo-functionattrs -> rpo-function-attrs while we're here.

Diff Detail

Event Timeline

aeubanks created this revision.Jul 27 2020, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2020, 12:10 PM
arsenm added a subscriber: arsenm.Jul 27 2020, 12:12 PM

I think this is the backwards direction. I think most passes consistently use - as a word separator, and the annoying cases do not

I think this is the backwards direction. I think most passes consistently use - as a word separator, and the annoying cases do not

Sure I can go the other direction, I went this way because it was more consistent with relevant passes, but I agree that a dash is better overall.
Looks like I'd only have to update 43 tests for "functionattrs" -> "function-attrs".

aeubanks updated this revision to Diff 281025.Jul 27 2020, 12:43 PM

Rename the other way

aeubanks retitled this revision from [NewPM] Rename function-attrs -> functionattrs to [FunctionAttrs] Rename functionattrs -> function-attrs.Jul 27 2020, 12:44 PM
aeubanks edited the summary of this revision. (Show Details)
aeubanks added a reviewer: arsenm.
arsenm accepted this revision.Jul 27 2020, 3:38 PM
This revision is now accepted and ready to land.Jul 27 2020, 3:38 PM
This revision was landed with ongoing or failed builds.Jul 28 2020, 9:09 AM
This revision was automatically updated to reflect the committed changes.