[flang] Use octal escapes for character literals in modfiles

[tskeith]

Summary

Character literals can be formatted using octal or hex escapes for
non-ascii characters. This is so that the program can be unparsed for
either pgf90 or gfortran to compile. But modfiles should not be affected
by that -- they should be consistent.

This changes causes modfiles to always have character literals formatted
with octal escapes.

[klausler]

flang/lib/Semantics/mod-file.cpp

108

Could use common::Restorer here instead of a flag and a destructor.

flang/lib/Semantics/mod-file.h

35

nit: should be explicit.

[tskeith]

Use common::ScopedSet instead of explicit destructor.

[tskeith]

flang/lib/Semantics/mod-file.cpp

108

Good idea, I've done that.

[klausler]

LGTM, thanks.

flang/lib/Semantics/mod-file.h

 
 using SourceName = parser::CharBlock;
 class Symbol;
 class Scope;
 class SemanticsContext;
 
 class ModFileWriter {
 public:
-  ModFileWriter(SemanticsContext &context) : context_{context} {}
+  ModFileWriter(SemanticsContext &);
+  ~ModFileWriter();
   bool WriteAll();
 
 private:
   SemanticsContext &context_;
+  const bool saveUseHexadecimalEscapeSequences_;
   // Buffer to use with raw_string_ostream
   std::string usesBuf_;
   std::string useExtraAttrsBuf_;
   std::string declsBuf_;
   std::string containsBuf_;
 
   llvm::raw_string_ostream uses_{usesBuf_};
   llvm::raw_string_ostream useExtraAttrs_{

flang/lib/Semantics/mod-file.cpp

private:
 
   template <typename T> void DoExpr(evaluate::Expr<T> expr) {
     for (const Symbol &symbol : evaluate::CollectSymbols(expr)) {
       DoSymbol(symbol);
     }
   }
 };
 
+ModFileWriter::ModFileWriter(SemanticsContext &context)
+    : context_{context}, saveUseHexadecimalEscapeSequences_{
+                             parser::useHexadecimalEscapeSequences} {
+  // this flag affects character literals: force it to be consistent
+  parser::useHexadecimalEscapeSequences = false;
+}
+
+ModFileWriter::~ModFileWriter() {
+  parser::useHexadecimalEscapeSequences = saveUseHexadecimalEscapeSequences_;
+}
+
 bool ModFileWriter::WriteAll() {
   WriteAll(context_.globalScope());
   return !context_.AnyFatalError();
 }
 
 void ModFileWriter::WriteAll(const Scope &scope) {
   for (const auto &child : scope.children()) {
     WriteOne(child);