Thanks for posting on discourse.
Makes sense to me. We can lower this to our vm.cond_fail pseudo-op (https://github.com/google/iree/blob/bf894c869e281985f392775c0cc0bb199201b477/iree/compiler/Dialect/VM/IR/VMOps.td#L1875), which forget lowers to a cond_br with a vm.fail terminator in the target block.
I think the semantics would need to be spelt out. Is execution guaranteed to abort on failure? The next line only talks about the error message printing being optional.
Yes please. Keeping consistency with the rest of the file and project comment style is important.
We have been following "regular" writing practices wrt lines vs sentences vs paragraph as one is optimising for the reader and not for changes/diffing (where tools do a good job with highlighting already and changing isn't the common case). Inconsistencies/deviations make readers wonder about the significance and impairs reading. Of course if there is a discussion where we adopt a new documentation convention, then this may change.