This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add FIR builder
ClosedPublic

Authored by schweitz on Jul 2 2020, 6:03 PM.

Details

Summary
The FIR builder is a helper class that manages the creation of MLIR
operations from the bridge. The focus of the builder is the creation of
Operations, Types, etc.

Diff Detail

Event Timeline

schweitz created this revision.Jul 2 2020, 6:03 PM
SouraVX added a subscriber: SouraVX.Jul 2 2020, 9:08 PM
jeanPerier accepted this revision.Jul 3 2020, 12:44 AM

LGTM

flang/lib/Lower/FIRBuilder.cpp
145

There is a fir::isa_integer in FIRType.h now, I do not think it is up-streamed yet, but maybe it could be upstreamed with this patch if it is easy. I am fine with leaving this for a later upstream otherwise.

This revision is now accepted and ready to land.Jul 3 2020, 12:44 AM
sscalpone accepted this revision.Jul 3 2020, 11:44 AM
This revision was automatically updated to reflect the committed changes.