This is an archive of the discontinued LLVM Phabricator instance.

Differential D82795

[flang] Silence some warnings from clang-tidy
ClosedPublic

Authored by tskeith on Jun 29 2020, 11:20 AM.

Details

Reviewers
klausler
PeteSteinfeld
schweitz
sscalpone
jdoerfert
DavidTruby
Commits
rG98202edacbad: [flang] Silence some warnings from clang-tidy
Summary

Disable some of the warnings from clang-tidy, in particular,
readability-identifier-naming. They add clutter to reviews.

Diff Detail

Event Timeline

tskeith created this revision.Jun 29 2020, 11:20 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 29 2020, 11:20 AM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B62190: Diff 274185.Jun 29 2020, 11:54 AM
PeteSteinfeld accepted this revision.Jun 29 2020, 2:25 PM

Looks good to me.

This revision is now accepted and ready to land.Jun 29 2020, 2:25 PM
sscalpone requested changes to this revision.Jun 29 2020, 10:59 PM

Perhaps update clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp to include flang in the llvm-include-order rule?

This revision now requires changes to proceed.Jun 29 2020, 10:59 PM
tskeith added a comment.Jun 30 2020, 7:44 AM
In D82795#2121845, @sscalpone wrote:

Perhaps update clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp to include flang in the llvm-include-order rule?

clang-format already enforces the include order so I don't think we need clang-tidy to check it.

sscalpone accepted this revision.Jun 30 2020, 9:08 AM

I put out a call on slack for a volunteer to update clang-tidy/llvm/IncludeOrderCheck.cpp

This revision is now accepted and ready to land.Jun 30 2020, 9:08 AM
Closed by commit rG98202edacbad: [flang] Silence some warnings from clang-tidy (authored by tskeith). · Explain WhyJun 30 2020, 10:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
flang/
1 line

Diff 274185

flang/.clang-tidy

  • This file was added.
Checks: '-*,llvm-*,-llvm-include-order,misc-*,-misc-no-recursion,-misc-unused-parameters,-misc-non-private-member-variables-in-classes'