Page MenuHomePhabricator

[flang] Silence some warnings from clang-tidy
ClosedPublic

Authored by tskeith on Mon, Jun 29, 11:20 AM.

Details

Summary

Disable some of the warnings from clang-tidy, in particular,
readability-identifier-naming. They add clutter to reviews.

Diff Detail

Event Timeline

tskeith created this revision.Mon, Jun 29, 11:20 AM
Herald added a project: Restricted Project. · View Herald Transcript
PeteSteinfeld accepted this revision.Mon, Jun 29, 2:25 PM

Looks good to me.

This revision is now accepted and ready to land.Mon, Jun 29, 2:25 PM
sscalpone requested changes to this revision.Mon, Jun 29, 10:59 PM

Perhaps update clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp to include flang in the llvm-include-order rule?

This revision now requires changes to proceed.Mon, Jun 29, 10:59 PM

Perhaps update clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp to include flang in the llvm-include-order rule?

clang-format already enforces the include order so I don't think we need clang-tidy to check it.

sscalpone accepted this revision.Tue, Jun 30, 9:08 AM

I put out a call on slack for a volunteer to update clang-tidy/llvm/IncludeOrderCheck.cpp

This revision is now accepted and ready to land.Tue, Jun 30, 9:08 AM
This revision was automatically updated to reflect the committed changes.