'InitialLength' is replaced with 'Format' (DWARF32 by default) and 'Length' in this patch.
Besides, test cases for DWARFv4 and DWARFv5, DWARF32 and DWARF64 is
added.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM. Well done on catching the lldb failures - I don't even build lldb by default personally.
llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml | ||
---|---|---|
693–702 | Any particular reason you've dropped the DWARF: tag? Having it back would help make the diff a little simpler, I'd hope. | |
llvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml | ||
1–7 | generating -> generating a |
Thanks for reviewing!
llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml | ||
---|---|---|
693–702 | Because the first tag after "DWARF:" is "debug_abbrev". I will bring it back later. |
Forgot to mark as accepted before, but one more comment to add.
llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml | ||
---|---|---|
693–702 | I didn't realise it wasn't on the next line. In that case, I'm happy for it to be deleted. Alternatively, you should add it to the DWARF64 case too. |
This commit causes test case failures on s390x (unfortunately hidden as the build bot was already red due to an unrelated issue):
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624
At first glance, seems like this could be endian-related?
Yes, if we don't specify the endianness in YAML, yaml2macho will emit binaries that have the same endianness as the host machine. I'll fix it. Thanks a lot!
Any particular reason you've dropped the DWARF: tag? Having it back would help make the diff a little simpler, I'd hope.