Page MenuHomePhabricator

[DWARFYAML][debug_info] Teach yaml2obj emit correct DWARF64 unit header.
ClosedPublic

Authored by Higuoxing on Jun 25 2020, 7:26 PM.

Details

Summary

This patch helps teach yaml2obj emit correct DWARF64 unit header of the .debug_info section.

Diff Detail

Event Timeline

Higuoxing created this revision.Jun 25 2020, 7:26 PM
jhenderson accepted this revision.Jun 26 2020, 1:31 AM

LGTM. The DWARF64 nature of an object also affects any DW_FORM_sec_offset attributes in the body of the table. Is that something that is already correct and covered by testing? If not, that should be done in a separate change.

This revision is now accepted and ready to land.Jun 26 2020, 1:31 AM

LGTM. The DWARF64 nature of an object also affects any DW_FORM_sec_offset attributes in the body of the table. Is that something that is already correct and covered by testing? If not, that should be done in a separate change.

The body of the table isn't tested yet, I will do it in a separate change.

Thanks for reviewing!

This revision was automatically updated to reflect the committed changes.