This is an archive of the discontinued LLVM Phabricator instance.

[openmp] Use Directive_enumSize instead of OMPD_unknown position
ClosedPublic

Authored by clementval on Jun 24 2020, 6:19 PM.

Details

Summary

Previously OMPD_unknown was last item in the Directive enumeration and its position was
used in various comparison and assertion. With the new Directive enumeration, this should be
change with llvm::omp::Directive_enumSize. This patch fix two place where it was not done in
D81736.

Diff Detail

Event Timeline

clementval created this revision.Jun 24 2020, 6:19 PM

add unsigned cast

jdoerfert accepted this revision.Jun 24 2020, 10:05 PM

LGTM, maybe a minor adjustment necessary.

clang/lib/Basic/OpenMPKinds.cpp
583

<, right?

This revision is now accepted and ready to land.Jun 24 2020, 10:05 PM
clementval marked 2 inline comments as done.Jun 25 2020, 6:17 AM
clementval added inline comments.
clang/lib/Basic/OpenMPKinds.cpp
583

You are right.

clementval marked an inline comment as done.Jun 25 2020, 6:19 AM
This revision was automatically updated to reflect the committed changes.