Page MenuHomePhabricator

jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (189 w, 4 d)

Recent Activity

Today

jdenny added inline comments to D104559: [OpenMP] Improve ref count debug messages.
Mon, Jun 21, 2:31 PM · Restricted Project
jdenny updated the diff for D104559: [OpenMP] Improve ref count debug messages.

Reformatted documentation change to fit better on the page.

Mon, Jun 21, 2:30 PM · Restricted Project
jdenny added a comment to D104566: [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines.

LG

Mon, Jun 21, 2:09 PM · Restricted Project, Restricted Project
jdenny committed rG2bfe0536e514: [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines (authored by jdenny).
[UpdateCCTestChecks] Fix --replace-value-regex across RUN lines
Mon, Jun 21, 2:09 PM
jdenny closed D104566: [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines.
Mon, Jun 21, 2:08 PM · Restricted Project, Restricted Project
jdenny updated the diff for D104559: [OpenMP] Improve ref count debug messages.

Applied jhuber6's suggestions:

Mon, Jun 21, 8:07 AM · Restricted Project

Fri, Jun 18

jdenny requested review of D104566: [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines.
Fri, Jun 18, 12:48 PM · Restricted Project, Restricted Project
jdenny added a comment to D104559: [OpenMP] Improve ref count debug messages.

Thanks for addressing this. Please update the documentation as well ./openmp/docs/design/Runtimes.rst.

Fri, Jun 18, 12:10 PM · Restricted Project
jdenny requested review of D104560: [OpenMP] Fix delete map type in ref count debug messages.
Fri, Jun 18, 11:14 AM · Restricted Project
jdenny set the repository for D104559: [OpenMP] Improve ref count debug messages to rG LLVM Github Monorepo.
Fri, Jun 18, 11:11 AM · Restricted Project
jdenny requested review of D104559: [OpenMP] Improve ref count debug messages.
Fri, Jun 18, 11:10 AM · Restricted Project

Apr 30 2021

jdenny committed rG82e99f50351d: [OpenMP] Fix second debug name from map clause (authored by jdenny).
[OpenMP] Fix second debug name from map clause
Apr 30 2021, 1:28 PM
jdenny closed D101564: [OpenMP] Fix second debug name from map clause.
Apr 30 2021, 1:28 PM · Restricted Project

Apr 29 2021

jdenny requested review of D101564: [OpenMP] Fix second debug name from map clause.
Apr 29 2021, 1:02 PM · Restricted Project

Apr 8 2021

jdenny accepted D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.

LGTM

Apr 8 2021, 1:15 PM · Restricted Project
jdenny accepted D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Thanks for all that work on the other tests! Still LGTM.

Apr 8 2021, 1:10 PM · Restricted Project

Apr 5 2021

jdenny added a comment to D98859: [lit] Handle plain negations directly in the internal shell.

Ah, I see. Even though it wouldn't add very much code, it sounds like we agree that the conceptual complexity isn't worthwhile given the direction we'd like to go eventually. Thanks again for looking into it.

Apr 5 2021, 10:43 AM · Restricted Project
jdenny accepted D98859: [lit] Handle plain negations directly in the internal shell.

Improved the testcases for '!'.

Apr 5 2021, 9:34 AM · Restricted Project

Mar 29 2021

jdenny added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Mar 29 2021, 2:18 PM · Restricted Project

Mar 27 2021

jdenny committed rG43279d1df90c: [FileCheck] Try to fix buildbot failures caused by c7c542e8f306 (authored by jdenny).
[FileCheck] Try to fix buildbot failures caused by c7c542e8f306
Mar 27 2021, 8:06 AM
jdenny committed rGc7c542e8f306: [FileCheck] Fix -dump-input per-pattern diagnostic indexing (authored by jdenny).
[FileCheck] Fix -dump-input per-pattern diagnostic indexing
Mar 27 2021, 7:44 AM
jdenny closed D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.
Mar 27 2021, 7:44 AM · Restricted Project

Mar 26 2021

jdenny added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

It seems the main issue left to address is tests that this patch breaks.

Mar 26 2021, 10:16 AM · Restricted Project
jdenny added inline comments to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Mar 26 2021, 9:23 AM · Restricted Project
jdenny added a comment to D98859: [lit] Handle plain negations directly in the internal shell.

@jdenny - Updated with some tests. The existing tests in the shtest-not suite seem to cover the uses of 'not' quite well - so just for the change of making 'not' evaluated builtin those existing tests should cover all aspects I think.

Mar 26 2021, 8:50 AM · Restricted Project
jdenny added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

You say there are many test failures. Should I hold off reviewing the test changes already in this patch, or are those fine?

Mar 26 2021, 6:55 AM · Restricted Project

Mar 25 2021

jdenny added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

I haven't looked through the tests yet, but the implementation logic looks right to me. Thanks!

Mar 25 2021, 5:51 PM · Restricted Project
jdenny added inline comments to D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.
Mar 25 2021, 4:37 PM · Restricted Project
jdenny updated the diff for D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.

Rebased, and addressed reviewer comments.

Mar 25 2021, 4:37 PM · Restricted Project

Mar 24 2021

jdenny added inline comments to D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.
Mar 24 2021, 3:09 PM · Restricted Project

Mar 23 2021

jdenny requested changes to D98859: [lit] Handle plain negations directly in the internal shell.
Mar 23 2021, 6:43 AM · Restricted Project
jdenny reopened D98859: [lit] Handle plain negations directly in the internal shell.

Please add tests before committing this again.

Mar 23 2021, 6:42 AM · Restricted Project

Mar 18 2021

jdenny added a comment to D98691: [FileCheck] Fix PR49531: invalid use of string var.

Sorry it seems I forgot to run the whole testsuite when I put this up for review. The patch found 3 issues:

https://reviews.llvm.org/D98852
https://reviews.llvm.org/D98853
https://reviews.llvm.org/D98854

Mar 18 2021, 9:00 AM · Restricted Project

Mar 17 2021

jdenny committed rGf87b4109b267: [FileCheck] Fix redundant diagnostics due to numeric errors (authored by jdenny).
[FileCheck] Fix redundant diagnostics due to numeric errors
Mar 17 2021, 4:27 PM
jdenny committed rGdd59c1324df6: [FileCheck] Fix numeric error propagation (authored by jdenny).
[FileCheck] Fix numeric error propagation
Mar 17 2021, 4:27 PM
jdenny closed D98088: [FileCheck] Fix redundant diagnostics due to numeric errors.
Mar 17 2021, 4:27 PM · Restricted Project
jdenny closed D98086: [FileCheck] Fix numeric error propagation.
Mar 17 2021, 4:27 PM · Restricted Project
jdenny added a comment to D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.

Ping.

Mar 17 2021, 9:48 AM · Restricted Project
jdenny added a comment to D98086: [FileCheck] Fix numeric error propagation.

Thanks for the review. I'm rebasing and retesting, and then I'll push.

Mar 17 2021, 9:45 AM · Restricted Project
jdenny accepted D98691: [FileCheck] Fix PR49531: invalid use of string var.

LGTM if @jhenderson is happy.

Mar 17 2021, 9:37 AM · Restricted Project

Mar 15 2021

jdenny added inline comments to D98086: [FileCheck] Fix numeric error propagation.
Mar 15 2021, 12:18 PM · Restricted Project
jdenny updated the diff for D98086: [FileCheck] Fix numeric error propagation.

Address @jhenderson's review.

Mar 15 2021, 12:17 PM · Restricted Project

Mar 11 2021

jdenny added a comment to D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.

Maybe I should drop this change and just find a better name for checkWildcardRegexCharMatchFailure.

Mar 11 2021, 4:16 PM · Restricted Project
jdenny added a comment to D98086: [FileCheck] Fix numeric error propagation.

Yes, sorry, been busy. I was off sick much of last week, and am participating in the ACCU conference most of this week. I'll try to find time to look at this next week, if you want my input, but there's no need to wait on me otherwise.

Mar 11 2021, 4:05 PM · Restricted Project

Mar 10 2021

jdenny added inline comments to D98086: [FileCheck] Fix numeric error propagation.
Mar 10 2021, 5:44 PM · Restricted Project
jdenny added inline comments to D98086: [FileCheck] Fix numeric error propagation.
Mar 10 2021, 5:18 PM · Restricted Project
jdenny added inline comments to D98342: [FileCheck] Fix naming of OverflowErrorStr var.
Mar 10 2021, 4:52 PM · Restricted Project
jdenny accepted D97845: [FileCheck] Add support for hex alternate form in FileCheck.

LGTM. Thanks!

Mar 10 2021, 2:59 PM · Restricted Project
jdenny added a comment to D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.

Based on the comments in D97845, I see the semantic difference this patch addresses, but....

Mar 10 2021, 2:55 PM · Restricted Project
jdenny accepted D98342: [FileCheck] Fix naming of OverflowErrorStr var.
Mar 10 2021, 1:25 PM · Restricted Project
jdenny added a comment to D98342: [FileCheck] Fix naming of OverflowErrorStr var.

Other than a comment request, LGTM.

Mar 10 2021, 1:25 PM · Restricted Project
jdenny added inline comments to D98086: [FileCheck] Fix numeric error propagation.
Mar 10 2021, 1:09 PM · Restricted Project
jdenny updated the diff for D98088: [FileCheck] Fix redundant diagnostics due to numeric errors.

Rebased for contextual changes from D98086.

Mar 10 2021, 1:02 PM · Restricted Project
jdenny added inline comments to D98086: [FileCheck] Fix numeric error propagation.
Mar 10 2021, 1:00 PM · Restricted Project
jdenny updated the diff for D98086: [FileCheck] Fix numeric error propagation.

Applied @thopre's suggestions.

Mar 10 2021, 12:57 PM · Restricted Project

Mar 9 2021

jdenny added a comment to D98086: [FileCheck] Fix numeric error propagation.

I like the idea behind it. I suppose that's what you had in mind when you wrote your comments in https://reviews.llvm.org/D86222. It should make that patch a lot simpler.

Mar 9 2021, 6:01 PM · Restricted Project
jdenny added inline comments to D97845: [FileCheck] Add support for hex alternate form in FileCheck.
Mar 9 2021, 5:02 PM · Restricted Project
jdenny added a comment to D55725: [OpenMP] Add libs to clang-dedicated directories.

I have no immediate plans to pursue this again, but maybe one day. Feel free to take over. Be sure to read the RFC thread. There was some delay waiting on another patch from someone else, but I've lost track.

Mar 9 2021, 9:31 AM · Restricted Project

Mar 7 2021

jdenny updated the diff for D98088: [FileCheck] Fix redundant diagnostics due to numeric errors.

Rebased for changes to D98086.

Mar 7 2021, 12:33 PM · Restricted Project
jdenny updated the diff for D98086: [FileCheck] Fix numeric error propagation.

I've generalized this patch to also handle errors that occur after matching. One issue is that PrintNoMatch was handling those, but I moved the handling to PrintMatch so that we actually report the full match that was found. That seems like useful information and helps with -dump-input.

Mar 7 2021, 12:28 PM · Restricted Project
jdenny added a comment to D97046: [lit] Generalize `early_tests`.

I have a patch that implements the record-and-reorder feature. It turned out to be simpler than I feared. Now I just need to figure out how to write a test for it that makes sense and is reliable. For ninja check-llvm, the record-and-reorder mode completes the test suite 51% faster on my 48-core machine. I think it's time to abandon this change proposal.

Mar 7 2021, 6:50 AM · Restricted Project, Restricted Project

Mar 6 2021

jdenny planned changes to D98086: [FileCheck] Fix numeric error propagation.

Actually, I do need to rethink the logic for that overflow case: PrintNoMatch is being called after a match, so its diagnostics don't make sense in that case. Sorry for the noise. I'll work on it.

Mar 6 2021, 5:28 AM · Restricted Project
jdenny added inline comments to D97845: [FileCheck] Add support for hex alternate form in FileCheck.
Mar 6 2021, 4:37 AM · Restricted Project
jdenny added a comment to D98086: [FileCheck] Fix numeric error propagation.

This patch also extends input dumps to include similar error
diagnostics.

Mar 6 2021, 4:27 AM · Restricted Project

Mar 5 2021

jdenny added inline comments to D97845: [FileCheck] Add support for hex alternate form in FileCheck.
Mar 5 2021, 5:22 PM · Restricted Project
jdenny requested review of D98088: [FileCheck] Fix redundant diagnostics due to numeric errors.
Mar 5 2021, 3:54 PM · Restricted Project
jdenny requested review of D98086: [FileCheck] Fix numeric error propagation.
Mar 5 2021, 3:48 PM · Restricted Project

Mar 4 2021

jdenny planned changes to D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error.

As discussed, I'll try a different solution for this issue this patch addresses, probably in a different review.

Mar 4 2021, 2:25 PM · Restricted Project
jdenny updated the diff for D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.

Rebased and updated for D93341's effect on -dump-input.

Mar 4 2021, 10:45 AM · Restricted Project
jdenny added a comment to D96652: [FileCheck][NFC] Move -dump-input tests to a subdirectory.

Thanks for the quick review. Sorry for the delay in pushing.

Mar 4 2021, 9:48 AM · Restricted Project
jdenny committed rGd3778490622b: [FileCheck][NFC] Move -dump-input tests to a subdirectory (authored by jdenny).
[FileCheck][NFC] Move -dump-input tests to a subdirectory
Mar 4 2021, 9:48 AM
jdenny closed D96652: [FileCheck][NFC] Move -dump-input tests to a subdirectory.
Mar 4 2021, 9:48 AM · Restricted Project
jdenny added a comment to D97908: [OpenMP] Encapsulate more in checkDeviceAndCtors.

Thanks for the reviews!

Mar 4 2021, 9:19 AM · Restricted Project
jdenny committed rGbfe5452b93a7: [OpenMP] Fix lone target exit data (authored by jdenny).
[OpenMP] Fix lone target exit data
Mar 4 2021, 9:13 AM
jdenny committed rGd0eb25a64345: [OpenMP] Encapsulate more in checkDeviceAndCtors (authored by jdenny).
[OpenMP] Encapsulate more in checkDeviceAndCtors
Mar 4 2021, 9:13 AM
jdenny committed rG10c18c69f2a8: [OpenMP] Fix support for device as host (authored by jdenny).
[OpenMP] Fix support for device as host
Mar 4 2021, 9:13 AM
jdenny closed D97908: [OpenMP] Encapsulate more in checkDeviceAndCtors.
Mar 4 2021, 9:13 AM · Restricted Project
jdenny closed D97907: [OpenMP] Fix lone target exit data.
Mar 4 2021, 9:13 AM · Restricted Project
jdenny closed D97616: [OpenMP] Fix support for device as host.
Mar 4 2021, 9:13 AM · Restricted Project

Mar 3 2021

jdenny requested review of D97908: [OpenMP] Encapsulate more in checkDeviceAndCtors.
Mar 3 2021, 7:55 PM · Restricted Project
jdenny requested review of D97907: [OpenMP] Fix lone target exit data.
Mar 3 2021, 7:42 PM · Restricted Project
jdenny added a comment to D97616: [OpenMP] Fix support for device as host.
  • The modified functions all have a common prologue. In a separate patch, I think that most of that should be moved to CheckDeviceAndCtors. Agreed?

Sure!

Mar 3 2021, 12:40 PM · Restricted Project
jdenny updated the diff for D97616: [OpenMP] Fix support for device as host.
  • Rebased.
  • Added test for mandatory offload with omp_get_num_devices() == 0.
  • Added comments pointing to OpenMP spec issue 2669.
Mar 3 2021, 12:39 PM · Restricted Project
jdenny added a comment to D97472: [test] Use host platform specific error message substitution in lit tests .

I may be lost. Why is --ignore-case still needed in llvm/test/tools/yaml2obj/ELF/DWARF/debug-gnu-pubnames.yaml? I thought the special case for win32 was supposed to handle that.

I missed this testcase in my old patch. I noticed it because it started to fail when I tried to add --ignore-case as a solution. I can fix it in this patch as well if desired or open a separate patch for it after this one.

Mar 3 2021, 12:09 PM · Restricted Project
jdenny committed rW364e18ddd615: [GSoC] Add OpenACC project on runtime diagnostics (authored by jdenny).
[GSoC] Add OpenACC project on runtime diagnostics
Mar 3 2021, 9:49 AM
jdenny added a comment to D97472: [test] Use host platform specific error message substitution in lit tests .

I may be lost. Why is --ignore-case still needed in llvm/test/tools/yaml2obj/ELF/DWARF/debug-gnu-pubnames.yaml? I thought the special case for win32 was supposed to handle that.

Mar 3 2021, 8:43 AM · Restricted Project

Mar 2 2021

jdenny requested review of D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing.
Mar 2 2021, 3:16 PM · Restricted Project
jdenny added a comment to D93341: [FileCheck] Do not skip end of line in diagnostics.

@thopre It's been almost a month. I suggest we move forward with this and address any complaints post-commit.

Mar 2 2021, 1:20 PM · Restricted Project
jdenny added a comment to D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error.

What does the label:2 X error: no match found mean then? I thought this was (despite the prefix) applying to the CHECK since the CHECK is searched after the LABEL.

Mar 2 2021, 9:27 AM · Restricted Project
jdenny added a comment to D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error.

As far as I know, it does. However, before CHECK-LABEL, a CHECK-NOT range is not the same as a CHECK range:

So if you have

CHECK-NOT: bar
CHECK-LABEL: bar

it will invariably fail? (Trying to distinguish behavior of the directives from behavior of the dump output.)

Mar 2 2021, 8:45 AM · Restricted Project
jdenny added a comment to D97616: [OpenMP] Fix support for device as host.

One more question: How do I test the new check? For cuda offload, I can set CUDA_VISIBLE_DEVICES to an empty string, but I haven't found a general way.

Mar 2 2021, 7:00 AM · Restricted Project
jdenny updated the diff for D97616: [OpenMP] Fix support for device as host.

In anticipation of the spec change, I've updated the patch to check the omp_get_num_devices() == 0 case. A few questions:

Mar 2 2021, 6:58 AM · Restricted Project

Mar 1 2021

jdenny added a comment to D97616: [OpenMP] Fix support for device as host.

Thanks for pointing that out (OpenMP spec issue 2669). I wasn't aware it was changing. I'll wait until that settles.

Mar 1 2021, 3:04 PM · Restricted Project
jdenny added a comment to D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error.

The strange part to me is that a preceding directive's search range ends at the end of the CHECK-LABEL match. It seems like it ought to end at the start of the CHECK-LABEL match.

I'd expect the behavior of CHECK-NOT ranges to work the same for CHECK-LABEL as for a regular CHECK.

Mar 1 2021, 2:24 PM · Restricted Project
jdenny added a comment to D97616: [OpenMP] Fix support for device as host.

If OMP_TARGET_OFFLOAD=mandatory it will not fail but just return

Mar 1 2021, 2:01 PM · Restricted Project
jdenny added a comment to D97616: [OpenMP] Fix support for device as host.

Thanks!

Mar 1 2021, 10:10 AM · Restricted Project
jdenny added a comment to D97616: [OpenMP] Fix support for device as host.

In every case where this patch inserts a check, there is code immediately following it that calls HandleTargetOutcome(false, loc);, usually because CheckDeviceAndCtors(device_id) != OFFLOAD_SUCCESS. The inserted check prevents that from code from executing. Is that what you're asking?

Mar 1 2021, 9:42 AM · Restricted Project
jdenny added a comment to D97046: [lit] Generalize `early_tests`.

While it's beyond what I need at the moment, I agree that test_phases looks better than early_tests, late_tests, etc.

Mar 1 2021, 6:39 AM · Restricted Project, Restricted Project

Feb 28 2021

jdenny added a comment to D96662: [lit] Add --xfail and --filter-out (inverse of --filter).

If a lit invocation runs multiple test suites that contain identically named test files, is there any way to make an --xfail entry apply to only one of them?

Feb 28 2021, 12:27 PM · Restricted Project

Feb 27 2021

jdenny requested review of D97616: [OpenMP] Fix support for device as host.
Feb 27 2021, 10:33 AM · Restricted Project