Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (308 w, 1 d)

Recent Activity

Tue, Sep 19

jdenny committed rG30d77fb80857: [lit] Apply aa71680f2948's fix to an additional test (authored by jdenny).
[lit] Apply aa71680f2948's fix to an additional test
Tue, Sep 19, 3:41 PM · Restricted Project, Restricted Project
jdenny committed rGaa71680f2948: [lit] Fix a test fail under windows (authored by jdenny).
[lit] Fix a test fail under windows
Tue, Sep 19, 3:06 PM · Restricted Project, Restricted Project
jdenny committed rGf223022a4c52: [lit] Improve test output from lit's internal shell (authored by jdenny).
[lit] Improve test output from lit's internal shell
Tue, Sep 19, 9:41 AM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rG1495d51ee9e7: [lit] Drop "Script:", make -v and -a imply -vv (authored by jdenny).
[lit] Drop "Script:", make -v and -a imply -vv
Tue, Sep 19, 9:41 AM · Restricted Project, Restricted Project

Sun, Sep 17

jdenny updated the diff for D158954: WIP: [lit] Enable debugging lit tests with python's pdb.

Rebased onto the current D154987. See its summary for how to apply it successfully first.

Sun, Sep 17, 7:28 AM · Restricted Project, Restricted Project
jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Rebased onto PR #66408, which includes recent changes from main. Within TestRunner.py, this rebase required moving runShScript and PythonDirectiveLitAPI into runOnce to make the per-run --per-test-coverage file index visible to lit.run(cmd) calls. Extended tests to cover that case.

Sun, Sep 17, 7:10 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 14

jdenny updated the diff for D156954: [lit] Improve test output from lit's internal shell.

Rebased onto the most recent version of D154984.

Thu, Sep 14, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D154984: [lit] Drop "Script:", make -v and -a imply -vv.

Rebased onto today's main. This brings in PR #65242, which included some code to accommodate the Script: section. The current patch eliminates the Script: section, so this update cleans up that code. Otherwise, the current patch hasn't changed much.

Thu, Sep 14, 9:37 AM · Restricted Project, Restricted Project

Thu, Sep 7

jdenny added a reverting change for rG09b6e457d91c: [lit] Drop "Script:", make -v and -a imply -vv: rG9f111d990b78: Revert "[lit] Drop "Script:", make -v and -a imply -vv".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny committed rG9f111d990b78: Revert "[lit] Drop "Script:", make -v and -a imply -vv" (authored by jdenny).
Revert "[lit] Drop "Script:", make -v and -a imply -vv"
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rGc981c533055e: [lit] Improve test output from lit's internal shell: rGbb6d5fc205d2: Revert "[lit] Improve test output from lit's internal shell".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rGbb6d5fc205d2: Revert "[lit] Improve test output from lit's internal shell" (authored by jdenny).
Revert "[lit] Improve test output from lit's internal shell"
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
jdenny added a reverting change for D154984: [lit] Drop "Script:", make -v and -a imply -vv: rG9f111d990b78: Revert "[lit] Drop "Script:", make -v and -a imply -vv".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rGf254bbf23374: [lit] Try to fix c981c533055e test fails under windows: rGbbd0564c8c0f: Revert "[lit] Try to fix c981c533055e test fails under windows".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny committed rGbbd0564c8c0f: Revert "[lit] Try to fix c981c533055e test fails under windows" (authored by jdenny).
Revert "[lit] Try to fix c981c533055e test fails under windows"
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny added a reverting change for D156954: [lit] Improve test output from lit's internal shell: rGbb6d5fc205d2: Revert "[lit] Improve test output from lit's internal shell".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
jdenny added a reverting change for rG3db5db92d746: [lit] Fix f254bbf23374 FileCheck patterns: rG2b964c84dba0: Revert "[lit] Fix f254bbf23374 FileCheck patterns".
Thu, Sep 7, 9:38 AM · Restricted Project, Restricted Project
jdenny committed rG2b964c84dba0: Revert "[lit] Fix f254bbf23374 FileCheck patterns" (authored by jdenny).
Revert "[lit] Fix f254bbf23374 FileCheck patterns"
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rG012d844fb856: [lit] Fix c981c533055e's remaining test fails under windows: rGdc7aa0a143fe: Revert "[lit] Fix c981c533055e's remaining test fails under windows".
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny committed rGdc7aa0a143fe: Revert "[lit] Fix c981c533055e's remaining test fails under windows" (authored by jdenny).
Revert "[lit] Fix c981c533055e's remaining test fails under windows"
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rGb6bd9d275f78: [lit] Fix yet another test fail under windows: rG80786af06da3: Revert "[lit] Fix yet another test fail under windows".
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny committed rG80786af06da3: Revert "[lit] Fix yet another test fail under windows" (authored by jdenny).
Revert "[lit] Fix yet another test fail under windows"
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rG19b44c2bdf17: [lit] Echo full RUN lines in case of external shells (#65267): rGb5c5ae7ddb54: Revert "[lit] Echo full RUN lines in case of external shells (#65267)".
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny committed rGb5c5ae7ddb54: Revert "[lit] Echo full RUN lines in case of external shells (#65267)" (authored by jdenny).
Revert "[lit] Echo full RUN lines in case of external shells (#65267)"
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny added a reverting change for rGefec733bf5bb: Revert "[lit] Echo full RUN lines in case of external shells": rG7f9ceabf1cf5: Revert "Revert "[lit] Echo full RUN lines in case of external shells"".
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project
jdenny committed rG7f9ceabf1cf5: Revert "Revert "[lit] Echo full RUN lines in case of external shells"" (authored by jdenny).
Revert "Revert "[lit] Echo full RUN lines in case of external shells""
Thu, Sep 7, 9:37 AM · Restricted Project, Restricted Project

Tue, Sep 5

jdenny committed rGefec733bf5bb: Revert "[lit] Echo full RUN lines in case of external shells" (authored by jdenny).
Revert "[lit] Echo full RUN lines in case of external shells"
Tue, Sep 5, 2:22 PM · Restricted Project, Restricted Project

Aug 30 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

I'm not sure if this has been discussed already

Yes, it has.

Aug 30 2023, 7:36 AM · Restricted Project, Restricted Project
jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

I doubt that's related

Aug 30 2023, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2023

jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

Getting close, the last failure just seems to be due to the path separators '/' vs. '\' being explicitly checked for.

Aug 29 2023, 12:18 PM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rGb6bd9d275f78: [lit] Fix yet another test fail under windows (authored by jdenny).
[lit] Fix yet another test fail under windows
Aug 29 2023, 12:05 PM · Restricted Project, Restricted Project
jdenny committed rG012d844fb856: [lit] Fix c981c533055e's remaining test fails under windows (authored by jdenny).
[lit] Fix c981c533055e's remaining test fails under windows
Aug 29 2023, 11:39 AM · Restricted Project, Restricted Project
jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

@jdenny I am the owner of the llvm-clang-x86_64-sie-win bot, let me know if you need any help to fix the failures from your change.

Aug 29 2023, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rG3db5db92d746: [lit] Fix f254bbf23374 FileCheck patterns (authored by jdenny).
[lit] Fix f254bbf23374 FileCheck patterns
Aug 29 2023, 10:17 AM · Restricted Project, Restricted Project
jdenny committed rGf254bbf23374: [lit] Try to fix c981c533055e test fails under windows (authored by jdenny).
[lit] Try to fix c981c533055e test fails under windows
Aug 29 2023, 10:01 AM · Restricted Project, Restricted Project
jdenny committed rGc981c533055e: [lit] Improve test output from lit's internal shell (authored by jdenny).
[lit] Improve test output from lit's internal shell
Aug 29 2023, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rG09b6e457d91c: [lit] Drop "Script:", make -v and -a imply -vv (authored by jdenny).
[lit] Drop "Script:", make -v and -a imply -vv
Aug 29 2023, 9:01 AM · Restricted Project, Restricted Project
jdenny closed D156954: [lit] Improve test output from lit's internal shell.
Aug 29 2023, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
jdenny closed D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Aug 29 2023, 9:01 AM · Restricted Project, Restricted Project
jdenny updated the summary of D156954: [lit] Improve test output from lit's internal shell.
Aug 29 2023, 8:50 AM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the summary of D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Aug 29 2023, 8:50 AM · Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

@awarzynski Thanks again for reviewing.

Aug 29 2023, 8:49 AM · Restricted Project, Restricted Project

Aug 27 2023

jdenny requested review of D158954: WIP: [lit] Enable debugging lit tests with python's pdb.
Aug 27 2023, 8:42 AM · Restricted Project, Restricted Project
jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Replace <lit test> with the actual test file name when compiling PYTHON lines. This info helps the python interpreter produce more informative diagnostics, including not only the test file name but also sometimes full PYTHON lines quoted from the test file. After a future patch, I expect it to also help when setting breakpoints while using a python debugger on lit test files.

Aug 27 2023, 8:26 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Aug 25 2023, 11:15 AM · Restricted Project, Restricted Project
jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

I saw only one bit of feedback from the RFC that affects this patch. That is, theoretically, a windows user might wish to adjust the shell comment sequence that lit's internal shell uses in its execution trace. This feature might help with copying multiple command lines at once from that trace and pasting them into any of the various shells that people use in windows. However, people seemed fine to wait to do that in a separate patch if an actual user who cares about that use case speaks up.

Aug 25 2023, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

The RFC has been up for a week with no significant activity for several days. The response was very positive. Thanks for all the feedback so far in this review, which led to D156954 and thus helped to make the RFC a success.

Aug 25 2023, 10:56 AM · Restricted Project, Restricted Project

Aug 18 2023

jdenny added a comment to D158164: [FileCheck] Added --match-full-lines-leading and --match-full-lines-trailing option.

--match-full-lines is require to check that nothing trailing is missing. Current approach is to add in 100 lines {{$}}

Okay, I think I see your point. You are simply looking to find a way to apply that regex pattern to every line, much like --match-full-lines adds an implicit {{^}} and {{$}} around each line. Is that correct? And you don't want to use --match-full-lines because of the noisy prefixes (hence I'm not sure @MaskRay's suggestion will work).

I'm not strongly opposed to the new options.

Aug 18 2023, 8:27 AM · Restricted Project, Restricted Project

Aug 17 2023

jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

The requested RFC for D154984 and D156954: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839

Aug 17 2023, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

The requested RFC for D154984 and D156954: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839

Aug 17 2023, 1:21 PM · Restricted Project, Restricted Project

Aug 9 2023

jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Rebase onto recent D156954 changes to address another libcxx pre-commit CI failure.

Aug 9 2023, 8:19 AM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D156954: [lit] Improve test output from lit's internal shell.

D154987's pre-commit CI revealed another issue with libcxx. This update tries to fix that. See changes to the patch summary for details.

Aug 9 2023, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2023

jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

I think it would be worth outlining in this patch why simply calling an external python script (which could actually be embedded within the file) is insufficient for the motivating case.

+1

I just extended TestingGuide.rst. Let me know if it's not what you are looking for.

Thanks. In my case at least, I was just referring to enhancing the commit description or even just posting a review comment with the explanation. Enhancing the documentation works for me though.

Aug 8 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Rebase onto recent D156954 changes to address libcxx pre-commit CI failure.

Aug 8 2023, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D156954: [lit] Improve test output from lit's internal shell.

D154987's pre-commit CI discovered that libcxx's custom lit test format doesn't always use %dbg(...) on commands. Chances are that there are other test suites in the same boat. Eliminate the associated assertion and todo in this patch.

Aug 8 2023, 8:12 AM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2023

jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Rebase onto D156954 and update to its execution trace style.

Aug 7 2023, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

Thank you so much! This fully addresses the concerns that I raised in https://reviews.llvm.org/D154984.

Aug 7 2023, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D156954: [lit] Improve test output from lit's internal shell.

Improve test coverage for new behavior. Fix issues that revealed:

  • Drive-by fix that came up in testing: internal not cmd sometimes produced exit status of True. Fixed that to be 1.
  • Instead of # command line, add # preamble command line before command lines from preamble_commands.
  • When expanding %dbg(...), don't modify the original script. Otherwise, upon every retry (due to ALLOW_RETRIES), we keep prepending the generic # command line to it as if there was no %dbg(...).
  • Assert that %dbg(...) is never missing. ninja check-lit doesn't fail this assert. CI testing will hopefully answer this question for all other uses.
  • If @echo has any unexpected results, instead of failing a generic assertion and losing the specific diagnostic, enable the normal execution trace as if it's echo.
Aug 7 2023, 4:36 PM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2023

jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

This patch will eventually need to be updated for the changes in D156954, but I haven't gotten there yet.

Aug 3 2023, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a reviewer for D154987: [lit] Implement PYTHON directive and config.prologue: Restricted Project.
Aug 3 2023, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

Thanks for the additional comments from everyone.

Aug 3 2023, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Rebased. Extended docs with comparison to using %python, as requested.

Aug 3 2023, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D156954: [lit] Improve test output from lit's internal shell.

Thank you for the nice summary! I just read the internal implementation the other day and glanced at the change. This change is reasonable and the test coverage looks great.

Aug 3 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the summary of D156954: [lit] Improve test output from lit's internal shell.
Aug 3 2023, 1:32 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D156954: [lit] Improve test output from lit's internal shell.

Rebased.

Aug 3 2023, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D154984: [lit] Drop "Script:", make -v and -a imply -vv.

Rebased.

Aug 3 2023, 1:07 PM · Restricted Project, Restricted Project

Aug 2 2023

jdenny requested review of D156954: [lit] Improve test output from lit's internal shell.
Aug 2 2023, 5:29 PM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

Yes, that should work.

Jul 27 2023, 1:33 PM · Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

What if we put the output in shell comments so it has no effect when pasted into a terminal?

Jul 27 2023, 10:49 AM · Restricted Project, Restricted Project

Jul 26 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

If the internal shell can collect Command Output (stdout): and stderr and print them after all RUN commands are dumped, we can remove the prompts.

Jul 26 2023, 4:22 PM · Restricted Project, Restricted Project

Jul 25 2023

jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

I'm expecting we'll end up with some way of writing assertions directly within python, rather than just calling out to shell commands that verify themselves.
(If this isn't added deliberately, then I'd expect it'll turn up anyway via raise or lit.run("false") or something)

Jul 25 2023, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

Could the tests you're targeting be written as actual python files, with an appropriate library of operations? (Some of this library could of course be shared with the shell test implementation).

I think it would accurate to say that the idea this patch implements was born out of use case I have for C++ defect report test suite.

Jul 25 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2023

jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

I have to offer a dissenting voice here...

Jul 24 2023, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
  1. Extend lit's internal shell to print full shell command lines before executing them. Reconfigure tests suites that need this functionality to use lit's internal shell.

Does this mean to print a pipe as one single command instead of two?

Jul 24 2023, 3:48 PM · Restricted Project, Restricted Project

Jul 17 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

@MaskRay and @awarzynski: Thanks for your comments. You both have pointed out that the -vv-style command trace breaks apart commands joined by | (and other command separators) so it's hard to copy-and-paste command lines to a terminal.

Jul 17 2023, 5:22 PM · Restricted Project, Restricted Project
jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

Thank you for coming up with the idea, and then implementing it!
Unfortunately, I can't review your implementation from lit standpoint, but it looks solid judging by documentation.

Jul 17 2023, 3:07 PM · Restricted Project, Restricted Project, Restricted Project
jdenny updated the diff for D154987: [lit] Implement PYTHON directive and config.prologue.

Addressed reviewer comment: make import example clearer.

Jul 17 2023, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
jdenny accepted D153967: [lit] Remove the --no-indirectly-run-check option.

Other than the comment I just requested, LGTM. Thanks for the cleanup.

Jul 17 2023, 2:17 PM · Restricted Project, Restricted Project

Jul 14 2023

jdenny added a comment to D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations.
  1. Extend lit's own test suite to cover it.

I submitted an update with your suggestions #1 and #2 but this #3 is much more difficult because of the nature of %{t:real}.

Jul 14 2023, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

@ldionne: It looks like this patch has revealed an existing bug in libcxx/test/libcxx/selftest/sh.cpp/empty.sh.cpp, but I'm not sure how best to handle it. Can you help?

Jul 14 2023, 8:30 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

jdenny added a reviewer for D153967: [lit] Remove the --no-indirectly-run-check option: thopre.
Jul 13 2023, 3:17 PM · Restricted Project, Restricted Project

Jul 12 2023

jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
  1. They take a long time to run. I don't know how to address that in the -vv trace. Indeed it seems you would need something like the "Script:" section.
Jul 12 2023, 11:49 AM · Restricted Project, Restricted Project
jdenny updated the summary of D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Jul 12 2023, 9:51 AM · Restricted Project, Restricted Project
jdenny added inline comments to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Jul 12 2023, 9:19 AM · Restricted Project, Restricted Project
jdenny added inline comments to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Jul 12 2023, 9:16 AM · Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

If a RUN line fails, you don't see the remaining RUN lines that didn't execute. Are you saying you would like to see those too?

I meant something slightly different. Some RUN get very complicated - especially when adding {RE}DEFINE to the mix and e.g. emulators to run tests on. I would like to be able to simply check that LIT correctly interprets my RUN lines without running the tests (which can take some time to run and generate a lot of output). I think that that would be very useful.

Jul 12 2023, 9:01 AM · Restricted Project, Restricted Project
jdenny added a comment to D154987: [lit] Implement PYTHON directive and config.prologue.

Are you also planning to adjust the update_tests.py scripts to support this syntax?

Jul 12 2023, 8:20 AM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

LGTM, but I'd wait for more approvals

Jul 12 2023, 7:46 AM · Restricted Project, Restricted Project

Jul 11 2023

jdenny added inline comments to D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Jul 11 2023, 3:04 PM · Restricted Project, Restricted Project
jdenny added a comment to D154984: [lit] Drop "Script:", make -v and -a imply -vv.

This is a very nice clean-up, thanks!

I've only skimmed through so far and just wanted to post a quick question about this:

Jul 11 2023, 2:50 PM · Restricted Project, Restricted Project
jdenny added a comment to D154594: Add version comparison in BooleanExpression for lit testing.

REQUIRES etc are global - whereas substitutions are not - and can be changed as the script runs. What version of the substitution should apply, I guess it could be the context of the actual REQUIRES/UNSUPPORTED (this would require more significant changes to the file though as these would require tracking in the same way as RUN and DEFINE/REDEFINE etc).

Jul 11 2023, 11:06 AM · Restricted Project, Restricted Project
jdenny requested review of D154987: [lit] Implement PYTHON directive and config.prologue.
Jul 11 2023, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
jdenny requested review of D154984: [lit] Drop "Script:", make -v and -a imply -vv.
Jul 11 2023, 9:52 AM · Restricted Project, Restricted Project

Jul 10 2023

jdenny added a comment to D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations.
  1. Extend lit's own test suite to cover it.
Jul 10 2023, 4:51 PM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations.

If the %> feature is going to remain (depending on, for example, the answer to @tahonermann's question about modulemap), please:

Jul 10 2023, 4:46 PM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2023

jdenny added a comment to D149685: [OpenMP] libomptarget: Don't map alignment padding to host.

OK, thanks! I'll take a look then.

Jul 7 2023, 8:04 AM · Restricted Project, Restricted Project

Jul 5 2023

jdenny added a comment to D149685: [OpenMP] libomptarget: Don't map alignment padding to host.

I think there's a corner case you may have missed. I'm still seeing this on aarch64:

/llvm-project/openmp/libomptarget/test/mapping/target_derefence_array_pointrs.cpp:28:12: error: CHECK: expected string not found in input
 // CHECK: 3
           ^
<stdin>:1:103: note: scanning from here
Libomptarget message: explicit extension not allowed: host address specified is 0x0000ffffd26ff7c0 (12 bytes), but device allocation maps to host at 0x0000ffffd26ff7c0 (8 bytes)
                                                                                                      ^
<stdin>:1:104: note: possible intended match here
Libomptarget message: explicit extension not allowed: host address specified is 0x0000ffffd26ff7c0 (12 bytes), but device allocation maps to host at 0x0000ffffd26ff7c0 (8 bytes)

Your patch fixes most failures, except this one. Fails with and without LTO enabled. Could you please check?

Jul 5 2023, 11:02 AM · Restricted Project, Restricted Project
jdenny added a comment to D150856: [lit] Add %{for-each-file} substitution.
Jul 5 2023, 9:16 AM · Restricted Project, Restricted Project

Jul 3 2023

jdenny added a comment to D149685: [OpenMP] libomptarget: Don't map alignment padding to host.

Thanks for the review.

Jul 3 2023, 7:25 AM · Restricted Project, Restricted Project
jdenny committed rG6e127c6f2947: [OpenMP] libomptarget: Don't map alignment padding to host (authored by jdenny).
[OpenMP] libomptarget: Don't map alignment padding to host
Jul 3 2023, 7:25 AM · Restricted Project, Restricted Project