Page MenuHomePhabricator

jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (89 w, 3 d)

Recent Activity

Tue, Jul 16

jdenny added a comment to D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.

Ping.

Tue, Jul 16, 7:07 AM · Restricted Project

Tue, Jul 9

jdenny updated the diff for D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.

Rebase, and add a unit test to demonstrate the bug.

Tue, Jul 9, 1:29 PM · Restricted Project
jdenny added inline comments to D61467: [Rewrite] Extend to further accept CharSourceRange.
Tue, Jul 9, 8:51 AM · Restricted Project, Restricted Project

Mon, Jul 8

jdenny committed rG1602058c0454: [lit] Parse command-line options from LIT_OPTS (authored by jdenny).
[lit] Parse command-line options from LIT_OPTS
Mon, Jul 8, 5:21 AM
jdenny committed rL365313: [lit] Parse command-line options from LIT_OPTS.
[lit] Parse command-line options from LIT_OPTS
Mon, Jul 8, 5:20 AM
jdenny closed D64135: [lit] Parse command-line options from LIT_OPTS.
Mon, Jul 8, 5:20 AM · Restricted Project

Sun, Jul 7

jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 10:52 AM · Restricted Project
jdenny abandoned D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 9:12 AM · Restricted Project
jdenny added inline comments to D61467: [Rewrite] Extend to further accept CharSourceRange.
Sun, Jul 7, 9:04 AM · Restricted Project, Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 8:38 AM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 7:00 AM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 6:46 AM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sun, Jul 7, 6:05 AM · Restricted Project

Sat, Jul 6

jdenny updated the diff for D64289: [OpenMP] Fix 128-bit long double support on target.

This incorporates all the improvements I think we've discussed so far:

Sat, Jul 6, 9:24 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 7:46 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 7:13 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 5:22 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 5:06 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 4:30 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 2:22 PM · Restricted Project
jdenny added inline comments to D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 2:02 PM · Restricted Project
jdenny created D64289: [OpenMP] Fix 128-bit long double support on target.
Sat, Jul 6, 12:50 PM · Restricted Project
jdenny committed rG87856e739c8e: [Rewrite] Try to fix buildbot link fail left by r365263 (authored by jdenny).
[Rewrite] Try to fix buildbot link fail left by r365263
Sat, Jul 6, 9:32 AM
jdenny committed rL365264: [Rewrite] Try to fix buildbot link fail left by r365263.
[Rewrite] Try to fix buildbot link fail left by r365263
Sat, Jul 6, 9:32 AM
jdenny committed rG7770f83d614c: [Rewrite] Try to fix buildbot link fail caused by r365258 (authored by jdenny).
[Rewrite] Try to fix buildbot link fail caused by r365258
Sat, Jul 6, 6:47 AM
jdenny committed rL365263: [Rewrite] Try to fix buildbot link fail caused by r365258.
[Rewrite] Try to fix buildbot link fail caused by r365258
Sat, Jul 6, 6:47 AM

Fri, Jul 5

jdenny committed rGadeb5ac2d643: [Rewrite] Extend to further accept CharSourceRange (authored by jdenny).
[Rewrite] Extend to further accept CharSourceRange
Fri, Jul 5, 7:56 PM
jdenny committed rL365258: [Rewrite] Extend to further accept CharSourceRange.
[Rewrite] Extend to further accept CharSourceRange
Fri, Jul 5, 7:55 PM
jdenny closed D61467: [Rewrite] Extend to further accept CharSourceRange.
Fri, Jul 5, 7:55 PM · Restricted Project, Restricted Project
jdenny updated the diff for D61467: [Rewrite] Extend to further accept CharSourceRange.

@jdoerfert Thanks for your reply. I added some comments to the tests. Let me know whether that's what you're looking for.

Fri, Jul 5, 5:55 PM · Restricted Project, Restricted Project

Thu, Jul 4

jdenny updated the diff for D64135: [lit] Parse command-line options from LIT_OPTS.

Simplify test as discussed with @probinson. Improve wording in docs slightly.

Thu, Jul 4, 10:11 AM · Restricted Project

Wed, Jul 3

jdenny added a comment to D64135: [lit] Parse command-line options from LIT_OPTS.

lit has options?

Wed, Jul 3, 3:46 PM · Restricted Project
jdenny updated subscribers of D64135: [lit] Parse command-line options from LIT_OPTS.
Wed, Jul 3, 2:27 PM · Restricted Project
jdenny updated subscribers of D64135: [lit] Parse command-line options from LIT_OPTS.
In D64135#1569174, @rnk wrote:

I think it would be preferable to standardize on llvm-lit as the way to re-run particular tests with some options.

Wed, Jul 3, 2:05 PM · Restricted Project
jdenny committed rG4e8b99a5c375: [Bitcode] Update CHECK-DAG usage in tests (authored by jdenny).
[Bitcode] Update CHECK-DAG usage in tests
Wed, Jul 3, 10:33 AM
jdenny committed rL365060: [Bitcode] Update CHECK-DAG usage in tests.
[Bitcode] Update CHECK-DAG usage in tests
Wed, Jul 3, 10:32 AM
jdenny closed D64036: [Bitcode] Update CHECK-DAG usage in tests.
Wed, Jul 3, 10:32 AM · Restricted Project
jdenny created D64135: [lit] Parse command-line options from LIT_OPTS.
Wed, Jul 3, 7:59 AM · Restricted Project

Tue, Jul 2

jdenny updated the diff for D64036: [Bitcode] Update CHECK-DAG usage in tests.

Fix minor problems in the summary and a test.

Tue, Jul 2, 7:11 AM · Restricted Project

Mon, Jul 1

jdenny added inline comments to D64036: [Bitcode] Update CHECK-DAG usage in tests.
Mon, Jul 1, 4:42 PM · Restricted Project
jdenny created D64036: [Bitcode] Update CHECK-DAG usage in tests.
Mon, Jul 1, 2:25 PM · Restricted Project
jdenny added reviewers for D61467: [Rewrite] Extend to further accept CharSourceRange: jdoerfert, hfinkel.
Mon, Jul 1, 7:32 AM · Restricted Project, Restricted Project
jdenny updated the diff for D61467: [Rewrite] Extend to further accept CharSourceRange.

Rebased, fixed a comment, and applied a clang-format suggestion.

Mon, Jul 1, 7:30 AM · Restricted Project, Restricted Project

Jun 7 2019

jdenny added inline comments to D62882: Use raw strings to avoid deprecation warnings in regexp patterns.
Jun 7 2019, 5:38 PM · Restricted Project

Jun 4 2019

jdenny added a comment to D61467: [Rewrite] Extend to further accept CharSourceRange.

Ping.

Jun 4 2019, 5:38 PM · Restricted Project, Restricted Project
jdenny accepted D62882: Use raw strings to avoid deprecation warnings in regexp patterns.

Never mind. I see it now. LGTM.

Jun 4 2019, 5:18 PM · Restricted Project
jdenny added a comment to D62882: Use raw strings to avoid deprecation warnings in regexp patterns.

This looks equivalent to me.

Jun 4 2019, 4:52 PM · Restricted Project

May 28 2019

jdenny committed rG91f8066d1de5: [OpenMP] Set pragma start loc to `#pragma` loc (authored by jdenny).
[OpenMP] Set pragma start loc to `#pragma` loc
May 28 2019, 12:28 PM
jdenny committed rC361867: [OpenMP] Set pragma start loc to `#pragma` loc.
[OpenMP] Set pragma start loc to `#pragma` loc
May 28 2019, 12:28 PM
jdenny committed rCTE361867: [OpenMP] Set pragma start loc to `#pragma` loc.
[OpenMP] Set pragma start loc to `#pragma` loc
May 28 2019, 12:27 PM
jdenny committed rL361867: [OpenMP] Set pragma start loc to `#pragma` loc.
[OpenMP] Set pragma start loc to `#pragma` loc
May 28 2019, 12:27 PM
jdenny closed D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
May 28 2019, 12:27 PM · Restricted Project, Restricted Project
jdenny added a comment to D61467: [Rewrite] Extend to further accept CharSourceRange.

Ping.

May 28 2019, 7:46 AM · Restricted Project, Restricted Project

May 22 2019

jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

I would think different people would want to review different pragmas, so separate patches would be better, but I'm happy to be corrected as I haven't explored who owns what here.

AFICS it is changing Tok.setLocation(FirstTok.getLocation()); to Tok.setLocation(Introducer.Loc); for most PragmaHandlers that emit an annotation token.

May 22 2019, 1:09 PM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

These changes LGTM!

May 22 2019, 12:13 PM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

Now that D61643 is pushed, we're back to this patch. My recollection is there are two remaining issues:

  1. Should we store both the #pragma location and the omp location in the AST, or is it fine to just replace the latter location with the former? If we choose to store both, we still haven't settled on an implementation, which likely will involve non-trivial changes in the parser and the AST. For OpenMP, @ABataev said replacing should be fine.

Storing both would be nice, but not required, IMO. Storing the location of the pragma "namespace" would be useful for third-party tooling purposes, but I don't think we have a need for it in the frontend otherwise.

May 22 2019, 11:39 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
  1. I too think it likely makes sense to adjust them all eventually. But do people think it's important to write patches adjusting all pragmas before pushing the adjustment for any of them?

I am not sure I understand. Do you mean whether you need all patches for each pragma to be accepted before you can commit the first? This is not that case.

May 22 2019, 9:41 AM · Restricted Project, Restricted Project
jdenny added a comment to D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.

I tried at r361335, where the original reproducer failed this assert consistently quickly for me today. After applying your patch there and running each reproducer from my bug report in a shell while loop for about an hour, I saw no failures. Thanks!

May 22 2019, 9:31 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
  1. Is there a diagnostic that would point to the omp token? As much as I like complete info (such as SourceLoc of semicolons), I cannot think of a use case for it.
  2. I would like to see all of them all adjusted. There is an immediate improvement in that improves the diagnostic output.
  1. Nope, there is no omp specific diagnostics
May 22 2019, 9:21 AM · Restricted Project, Restricted Project
jdenny updated subscribers of D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

Now that D61643 is pushed, we're back to this patch. My recollection is there are two remaining issues:

May 22 2019, 7:58 AM · Restricted Project, Restricted Project

May 21 2019

jdenny committed rGddde0ec1e47b: [PragmaHandler] Expose `#pragma` location (authored by jdenny).
[PragmaHandler] Expose `#pragma` location
May 21 2019, 4:50 PM
jdenny committed rC361335: [PragmaHandler] Expose `#pragma` location.
[PragmaHandler] Expose `#pragma` location
May 21 2019, 4:50 PM
jdenny committed rL361335: [PragmaHandler] Expose `#pragma` location.
[PragmaHandler] Expose `#pragma` location
May 21 2019, 4:50 PM
jdenny closed D61643: [PragmaHandler] Expose `#pragma` location.
May 21 2019, 4:50 PM · Restricted Project
jdenny added a comment to D61643: [PragmaHandler] Expose `#pragma` location.

+1

Such a solution also came up in https://bugs.llvm.org/show_bug.cgi?id=41514#c1

May 21 2019, 4:50 PM · Restricted Project
jdenny retitled D61643: [PragmaHandler] Expose `#pragma` location from [PragmaHandler][NFC] Expose `#pragma` location to [PragmaHandler] Expose `#pragma` location.
May 21 2019, 8:45 AM · Restricted Project
jdenny added inline comments to D61643: [PragmaHandler] Expose `#pragma` location.
May 21 2019, 8:35 AM · Restricted Project
jdenny added inline comments to D61643: [PragmaHandler] Expose `#pragma` location.
May 21 2019, 7:30 AM · Restricted Project
jdenny added inline comments to D61643: [PragmaHandler] Expose `#pragma` location.
May 21 2019, 7:24 AM · Restricted Project

May 15 2019

jdenny added a comment to D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.

Thanks, Joel.

I actually was not able to reproduce your first problem. But I hope the patch should fix both.

May 15 2019, 10:10 AM · Restricted Project
jdenny added a comment to D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.

For me, this appears to fix my bug report's second reproducer, the one without the num_teams(3). Thanks!

May 15 2019, 8:10 AM · Restricted Project

May 9 2019

jdenny added inline comments to D61467: [Rewrite] Extend to further accept CharSourceRange.
May 9 2019, 3:59 PM · Restricted Project, Restricted Project
jdenny added a comment to D61467: [Rewrite] Extend to further accept CharSourceRange.

Ping. This seems like a straight-forward extension to the Rewriter API.

May 9 2019, 3:51 PM · Restricted Project, Restricted Project

May 7 2019

jdenny added inline comments to D61643: [PragmaHandler] Expose `#pragma` location.
May 7 2019, 10:42 AM · Restricted Project
jdenny added a parent revision for D61509: [OpenMP] Set pragma start loc to `#pragma` loc: D61643: [PragmaHandler] Expose `#pragma` location.
May 7 2019, 9:52 AM · Restricted Project, Restricted Project
jdenny added a child revision for D61643: [PragmaHandler] Expose `#pragma` location: D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
May 7 2019, 9:52 AM · Restricted Project
jdenny updated the diff for D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

As requested, replace this patch with just the OpenMP changes.

May 7 2019, 9:46 AM · Restricted Project, Restricted Project
jdenny created D61643: [PragmaHandler] Expose `#pragma` location.
May 7 2019, 9:41 AM · Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

I don't see why this differential can't be updated to only contain the remaining part
of the diff (for the actual OpenMP change), after splitting the NFC refactoring part.

May 7 2019, 9:28 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

It would have been better to submit this refactor as a new patch..

Sorry, I didn't realize that was the norm. I can do that now if it would help. I can also revert changes to this patch if the goal is to make it easier to reference the old version.

I think that would be good. This current diff would be a simple NFC cleanup, i think i will signoff it even.

May 7 2019, 9:23 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

It would have been better to submit this refactor as a new patch..

May 7 2019, 9:15 AM · Restricted Project, Restricted Project
jdenny updated the diff for D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

As suggested, I've created a struct PragmaIntroducer and I've reduced this patch not to include the OpenMP changes. I'll add a new patch with the OpenMP changes soon.

May 7 2019, 9:04 AM · Restricted Project, Restricted Project
jdenny accepted D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions.

LGTM except for nits in the tests. I'm not close to C++ support in Clang, so please give other reviewers a few days to comment just in case. I've added a couple who have reviewed my patches in this area in the past.

May 7 2019, 8:13 AM · Restricted Project

May 6 2019

jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

Thanks for everyone's responses so far.

May 6 2019, 10:37 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

Again, I don't see a single point why would we need this. I don't think there is a big difference between the location of pragma keyword and omp keyword.

May 6 2019, 7:56 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

I recommend to split this into two parts - changing PragmaIntroducerKind Introducer to
struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};, and the actual openmp change.

Sure, I'll work on that. What about NameMe = PragmaIntroducer?

Could work. And then move PragmaIntroducerKind into it.
I believe this part of the refactoring is completely uncontroversial.

For that change, just basing off the clang-tidy diff, neither variant is ideal,

Do you mean that it's better for diagnostics that point to a pragma not to include the #pragma in their locations? If so, why is that?

I'm not sure either one is better than the other one.

I have two concerns:

  • I fear this would result in inconsistency with other pragmas, since this will only change openmp-ones. I don't know if it will be accepted to migrate the rest of them in the same way.
  • This use-case requires having the location of #pragma, so the entire AST is migrating to store it. But the current location will no longer be accessible from AST.

    I see two paths forward:
  • Mail cfe-dev, and suggest to do this change for *all* pragmas. Either this is ok for all of them, or none of them.
  • Moar abstractions - how about not changing the startloc of openmp directives,

My alternative proposal was exactly that. A difficulty is how to pass the #pragma location to the OpenMP AST node constructors. PragmaOpenMPHandler::HandlePragma passes locations via the tok::annot_pragma_openmp and tok::annot_pragma_openmp_end tokens, so where do we pass this new location? I proposed creating a third token, and Alexey was concerned over the parsing problems that would create.

but instead add some baseclass to `OMPDirective` class (& every other class that is created from pragma), that would record the `PragmaIntroducer`?

I agree that a base class would be a nice way to extend all pragma classes with the PragmaIntroducer.

I'm against this solution. I don't see any reasons why we should do this. Instead, we're getting a lot of pain with parsing and maintenance.

One way to avoid creating an extra token would be to widen the Token class to store the additional location. The Token documentation says it's not intended to be space efficient. How does that sound to people?

That was my proposal, yes.

May 6 2019, 6:51 AM · Restricted Project, Restricted Project

May 5 2019

jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

I recommend to split this into two parts - changing PragmaIntroducerKind Introducer to
struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};, and the actual openmp change.

Sure, I'll work on that. What about NameMe = PragmaIntroducer?

Could work. And then move PragmaIntroducerKind into it.
I believe this part of the refactoring is completely uncontroversial.

For that change, just basing off the clang-tidy diff, neither variant is ideal,

Do you mean that it's better for diagnostics that point to a pragma not to include the #pragma in their locations? If so, why is that?

I'm not sure either one is better than the other one.

I have two concerns:

  • I fear this would result in inconsistency with other pragmas, since this will only change openmp-ones. I don't know if it will be accepted to migrate the rest of them in the same way.
  • This use-case requires having the location of #pragma, so the entire AST is migrating to store it. But the current location will no longer be accessible from AST.

    I see two paths forward:
  • Mail cfe-dev, and suggest to do this change for *all* pragmas. Either this is ok for all of them, or none of them.
  • Moar abstractions - how about not changing the startloc of openmp directives,
May 5 2019, 4:53 PM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

I recommend to split this into two parts - changing PragmaIntroducerKind Introducer to
struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};, and the actual openmp change.

May 5 2019, 8:05 AM · Restricted Project, Restricted Project

May 3 2019

jdenny updated the diff for D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

As discussed, implement OpenMP solution #1 (one-line change in PragmaOpenMPHandler::HandlePragma in ParsePragma.cpp), and update tests.

May 3 2019, 10:59 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

Thanks for explaining. I'll proceed with solution #1.

May 3 2019, 9:09 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

If the patch is going to be accepted, then definitely it must be solution #1.

I certainly have no objection to that and will be happy to implement it, but can you help me to understand the rationale? (Thanks for your quick response!)

Another one annotation token may significantly change the parsing process. It will require a lot of rework in the parsing of OpenMP pragmas plus may lead to some unpredictable results like endless parsing in some cases etc.

May 3 2019, 8:33 AM · Restricted Project, Restricted Project
jdenny added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.

If the patch is going to be accepted, then definitely it must be solution #1.

May 3 2019, 7:52 AM · Restricted Project, Restricted Project
jdenny created D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
May 3 2019, 7:40 AM · Restricted Project, Restricted Project

May 2 2019

jdenny created D61467: [Rewrite] Extend to further accept CharSourceRange.
May 2 2019, 2:27 PM · Restricted Project, Restricted Project
jdenny created D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.
May 2 2019, 2:06 PM · Restricted Project

Apr 30 2019

jdenny added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.
Apr 30 2019, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.

It seems we have roughly the same situation for their ABIs. That is, for .so files, someone noted that libc++ and libunwind have always used the same version, .1, and openmp doesn't use a version (except in Debian packages). In other words, for each of these three, a change in ABI compatibility has never been indicated. For openmp only, it's apparently assumed a change never will need to be indicated (except in Debian packages).

They already use .2 for ABI v2 which is currently considered unstable but some project like Fuchsia already use. There's also an ongoing discussion to stabilize v2.

Apr 30 2019, 9:27 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2019

jdenny added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.

Does the following match what you have in mind?

$prefix/
  include/
    c++/
      v1/
        limits.h
        ...
    openmp/
      v1/ <------ I don't think openmp has anything like this now

Iibc++ uses this scheme to allow the possibility of evolving the API but I'm not sure if it's necessary for openmp.

Apr 26 2019, 7:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2019

jdenny committed rL359012: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types.
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Apr 23 2019, 10:05 AM
jdenny committed rG3234887fe2ea: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types (authored by jdenny).
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Apr 23 2019, 10:05 AM