User Details
- User Since
- Nov 2 2017, 3:15 PM (308 w, 1 d)
Tue, Sep 19
Sun, Sep 17
Rebased onto the current D154987. See its summary for how to apply it successfully first.
Rebased onto PR #66408, which includes recent changes from main. Within TestRunner.py, this rebase required moving runShScript and PythonDirectiveLitAPI into runOnce to make the per-run --per-test-coverage file index visible to lit.run(cmd) calls. Extended tests to cover that case.
Thu, Sep 14
Rebased onto the most recent version of D154984.
Rebased onto today's main. This brings in PR #65242, which included some code to accommodate the Script: section. The current patch eliminates the Script: section, so this update cleans up that code. Otherwise, the current patch hasn't changed much.
Thu, Sep 7
Tue, Sep 5
Aug 30 2023
Aug 29 2023
@awarzynski Thanks again for reviewing.
Aug 27 2023
Replace <lit test> with the actual test file name when compiling PYTHON lines. This info helps the python interpreter produce more informative diagnostics, including not only the test file name but also sometimes full PYTHON lines quoted from the test file. After a future patch, I expect it to also help when setting breakpoints while using a python debugger on lit test files.
Aug 25 2023
I saw only one bit of feedback from the RFC that affects this patch. That is, theoretically, a windows user might wish to adjust the shell comment sequence that lit's internal shell uses in its execution trace. This feature might help with copying multiple command lines at once from that trace and pasting them into any of the various shells that people use in windows. However, people seemed fine to wait to do that in a separate patch if an actual user who cares about that use case speaks up.
The RFC has been up for a week with no significant activity for several days. The response was very positive. Thanks for all the feedback so far in this review, which led to D156954 and thus helped to make the RFC a success.
Aug 18 2023
Aug 17 2023
The requested RFC for D154984 and D156954: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839
The requested RFC for D154984 and D156954: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839
Aug 9 2023
Rebase onto recent D156954 changes to address another libcxx pre-commit CI failure.
D154987's pre-commit CI revealed another issue with libcxx. This update tries to fix that. See changes to the patch summary for details.
Aug 8 2023
Rebase onto recent D156954 changes to address libcxx pre-commit CI failure.
D154987's pre-commit CI discovered that libcxx's custom lit test format doesn't always use %dbg(...) on commands. Chances are that there are other test suites in the same boat. Eliminate the associated assertion and todo in this patch.
Aug 7 2023
Rebase onto D156954 and update to its execution trace style.
Improve test coverage for new behavior. Fix issues that revealed:
- Drive-by fix that came up in testing: internal not cmd sometimes produced exit status of True. Fixed that to be 1.
- Instead of # command line, add # preamble command line before command lines from preamble_commands.
- When expanding %dbg(...), don't modify the original script. Otherwise, upon every retry (due to ALLOW_RETRIES), we keep prepending the generic # command line to it as if there was no %dbg(...).
- Assert that %dbg(...) is never missing. ninja check-lit doesn't fail this assert. CI testing will hopefully answer this question for all other uses.
- If @echo has any unexpected results, instead of failing a generic assertion and losing the specific diagnostic, enable the normal execution trace as if it's echo.
Aug 3 2023
This patch will eventually need to be updated for the changes in D156954, but I haven't gotten there yet.
Thanks for the additional comments from everyone.
Rebased. Extended docs with comparison to using %python, as requested.
Rebased.
Rebased.
Aug 2 2023
Jul 27 2023
Jul 26 2023
Jul 25 2023
Jul 24 2023
Jul 17 2023
@MaskRay and @awarzynski: Thanks for your comments. You both have pointed out that the -vv-style command trace breaks apart commands joined by | (and other command separators) so it's hard to copy-and-paste command lines to a terminal.
Addressed reviewer comment: make import example clearer.
Other than the comment I just requested, LGTM. Thanks for the cleanup.
Jul 14 2023
@ldionne: It looks like this patch has revealed an existing bug in libcxx/test/libcxx/selftest/sh.cpp/empty.sh.cpp, but I'm not sure how best to handle it. Can you help?
Jul 13 2023
Jul 12 2023
Jul 11 2023
Jul 10 2023
- Extend lit's own test suite to cover it.
If the %> feature is going to remain (depending on, for example, the answer to @tahonermann's question about modulemap), please:
Jul 7 2023
Jul 5 2023
Jul 3 2023
Thanks for the review.