- User Since
- Nov 2 2017, 3:15 PM (98 w, 3 d)
Fri, Sep 20
Mon, Sep 16
I had to revert this because it broke a Windows bot. I didn't consider that this patch not only enables internal diff to function in pipelines but also causes it to be used instead of external diffs when in pipelines. Thus, it cannot be pushed without additional patches that add features like -, which are sometimes used in the test suite when diff appears in pipelines.
Wed, Sep 11
Tue, Sep 10
Mon, Sep 2
Sun, Aug 25
Aug 23 2019
I made several changes:
Aug 22 2019
Aug 21 2019
Make suggested changes to default arguments, comments on literals, and parameter names.
Make suggested changes for passing around the capture level.
Restore previous version of patch, and rebase.
I want to be sure we're on the same page. Due to the changes I just backed out, the following two examples now generate different code:
As requested, backed out the changes related to firstprivate scalars, and updated tests.
As discussed, moved relevant tests and parts of summary to D66506.
As discussed, moved relevant tests from D65697 to this patch, and rewrote summary to describe the non-NFC parts of this change.
Aug 20 2019
Rebase onto D66506.
Replace ValueError with InternalShellError.
Replace ValueError with InternalShellError as just discussed in D65697. I'll wait a little while to push in case someone wants to comment on this.
Rebased onto D66482, and added a new test here for nested env without arguments.
- Renamed %TestFileCheckOut to %ProtectFileCheckOutput.
- Added documentation to llvm/docs/TestingGuide.rst.
Aug 19 2019
Aug 16 2019
Aug 15 2019
Rebase. Remove checking for accidental external command calls. I'll put that in a separate patch.
Aug 14 2019
I think you're referring to stuff like OpenMPCaptureLevel in ScopeInfo.h. I wrote those changes for this patch first, as can be seen in phabricator history. I needed them for the other patch too, and I thought we were going to end up applying that patch first, so I was going to strip them out here. Of course, as I understand it, the plan now is to apply only this patch.
Rebase. Add more tests, as requested at D66247#1630441.