- User Since
- Nov 2 2017, 3:15 PM (89 w, 3 d)
Tue, Jul 16
Tue, Jul 9
Rebase, and add a unit test to demonstrate the bug.
Mon, Jul 8
Sun, Jul 7
Sat, Jul 6
This incorporates all the improvements I think we've discussed so far:
Fri, Jul 5
@jdoerfert Thanks for your reply. I added some comments to the tests. Let me know whether that's what you're looking for.
Thu, Jul 4
Simplify test as discussed with @probinson. Improve wording in docs slightly.
Wed, Jul 3
Tue, Jul 2
Fix minor problems in the summary and a test.
Mon, Jul 1
Rebased, fixed a comment, and applied a clang-format suggestion.
Jun 7 2019
Jun 4 2019
Never mind. I see it now. LGTM.
This looks equivalent to me.
May 28 2019
May 22 2019
I tried at r361335, where the original reproducer failed this assert consistently quickly for me today. After applying your patch there and running each reproducer from my bug report in a shell while loop for about an hour, I saw no failures. Thanks!
Now that D61643 is pushed, we're back to this patch. My recollection is there are two remaining issues:
May 21 2019
May 15 2019
For me, this appears to fix my bug report's second reproducer, the one without the num_teams(3). Thanks!
May 9 2019
Ping. This seems like a straight-forward extension to the Rewriter API.
May 7 2019
As requested, replace this patch with just the OpenMP changes.
As suggested, I've created a struct PragmaIntroducer and I've reduced this patch not to include the OpenMP changes. I'll add a new patch with the OpenMP changes soon.
LGTM except for nits in the tests. I'm not close to C++ support in Clang, so please give other reviewers a few days to comment just in case. I've added a couple who have reviewed my patches in this area in the past.
May 6 2019
Thanks for everyone's responses so far.
May 5 2019
May 3 2019
As discussed, implement OpenMP solution #1 (one-line change in PragmaOpenMPHandler::HandlePragma in ParsePragma.cpp), and update tests.
Thanks for explaining. I'll proceed with solution #1.