jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (29 w, 1 d)

Recent Activity

Thu, May 24

jdenny set the repository for D44598: [lit] Report line number for failed RUN command to rL LLVM.
Thu, May 24, 12:36 PM
jdenny set the repository for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition to rC Clang.
Thu, May 24, 12:35 PM
jdenny set the repository for D46846: [AST] Fix loss of enum forward decl from decl context to rC Clang.
Thu, May 24, 12:35 PM
jdenny set the repository for D47106: [FileCheck] Make CHECK-DAG non-overlapping to rL LLVM.
Thu, May 24, 12:34 PM
jdenny set the repository for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests to rL LLVM.
Thu, May 24, 12:33 PM
jdenny set the repository for D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests to rC Clang.
Thu, May 24, 12:33 PM
jdenny set the repository for D47114: [FileCheck] Implement -v and -vv for tracing matches to rL LLVM.
Thu, May 24, 12:32 PM
jdenny set the repository for D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests to rCRT Compiler Runtime.
Thu, May 24, 7:17 AM
jdenny added a dependent revision for D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests: D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Thu, May 24, 7:09 AM
jdenny added a dependency for D47106: [FileCheck] Make CHECK-DAG non-overlapping: D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
Thu, May 24, 7:09 AM
jdenny created D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
Thu, May 24, 7:09 AM

Wed, May 23

jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

(Replying here instead of inline as the thread is getting kind of long.)

Sorry, I didn't realize FileCheck would try to detect and explicitly diagnose reordering DAG across NOT. That seems like more trouble than it's worth. NOT is documented to enforce ordering, and we can make it just do that, and if you mess up then your test fails by not matching rather than telling you something is in the wrong order. (Then you can use -v or -vv to work out what happened, if you need to.)

Once we define the DAGs as separated into distinct groups by a NOT, I think it's conceptually straightforward to say each DAG group has a "matching range" from the start of the earliest match to the end of the latest match. Two DAG groups can't have overlapping match ranges (just like you are making individual DAG matches not overlap).

Wed, May 23, 3:45 PM
jdenny updated the diff for D47106: [FileCheck] Make CHECK-DAG non-overlapping.

This splits the test case, as requested.

Wed, May 23, 2:08 PM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Wed, May 23, 12:46 PM
jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

LGTM

Wed, May 23, 10:47 AM
jdenny updated the diff for D47114: [FileCheck] Implement -v and -vv for tracing matches.

If this doesn't accomplish the changes you had in mind, please let me know.

Wed, May 23, 10:11 AM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Wed, May 23, 10:00 AM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Wed, May 23, 8:34 AM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Wed, May 23, 7:25 AM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Wed, May 23, 5:25 AM

Tue, May 22

jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Tue, May 22, 3:26 PM
jdenny added inline comments to D47114: [FileCheck] Implement -v and -vv for tracing matches.
Tue, May 22, 2:13 PM

Mon, May 21

jdenny added dependencies for D47106: [FileCheck] Make CHECK-DAG non-overlapping: D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests, D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.
Mon, May 21, 5:45 PM
jdenny added a dependent revision for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests: D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Mon, May 21, 5:45 PM
jdenny created D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.
Mon, May 21, 5:44 PM
jdenny created D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.
Mon, May 21, 5:39 PM
jdenny added a comment to D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

The deprecated enumerator is also referenced by tools/c-index-test/c-index-test.c

This test prompted me to keep the IncludeTagDefinition member in PrintingPolicy so that clang_PrintingPolicy_getProperty would return the previous value set by clang_PrintingPolicy_setProperty. Otherwise, the value doesn't have any effect. Is that self-consistency not worth worrying about? If so, I'll remove both.

I don't think it's worth worrying about. We don't guarantee that the values round-trip in general (most of them are unsigneds being written to a bool, so we don't preserve values that are neither 0 nor 1).

Mon, May 21, 5:28 PM
jdenny updated the diff for D47106: [FileCheck] Make CHECK-DAG non-overlapping.

Fixed some minor typos.

Mon, May 21, 5:19 PM
jdenny added a comment to D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

The deprecated enumerator is also referenced by tools/c-index-test/c-index-test.c

This test prompted me to keep the IncludeTagDefinition member in PrintingPolicy so that clang_PrintingPolicy_getProperty would return the previous value set by clang_PrintingPolicy_setProperty. Otherwise, the value doesn't have any effect. Is that self-consistency not worth worrying about? If so, I'll remove both.

Mon, May 21, 3:33 PM
jdenny updated the diff for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

Made a stab at the suggested changes.

Mon, May 21, 3:32 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Ping.

Mon, May 21, 9:46 AM

Sat, May 19

jdenny added a dependency for D47114: [FileCheck] Implement -v and -vv for tracing matches: D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Sat, May 19, 4:58 PM
jdenny added a dependent revision for D47106: [FileCheck] Make CHECK-DAG non-overlapping: D47114: [FileCheck] Implement -v and -vv for tracing matches.
Sat, May 19, 4:58 PM
jdenny created D47114: [FileCheck] Implement -v and -vv for tracing matches.
Sat, May 19, 4:57 PM
jdenny updated the summary of D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Sat, May 19, 12:07 PM
jdenny created D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Sat, May 19, 8:29 AM

Wed, May 16

jdenny retitled D46846: [AST] Fix loss of enum forward decl from decl context from [Attr] Fix loss of enum forward decl from decl context to [AST] Fix loss of enum forward decl from decl context.
Wed, May 16, 11:04 AM
jdenny updated the diff for D46846: [AST] Fix loss of enum forward decl from decl context.

Made the suggested change. Thanks!

Wed, May 16, 10:58 AM
jdenny committed rC332481: [Attr] Don't print fake MSInheritance argument.
[Attr] Don't print fake MSInheritance argument
Wed, May 16, 8:22 AM
jdenny committed rC332480: Revert r332474: [Attr] Don't print fake MSInheritance argument.
Revert r332474: [Attr] Don't print fake MSInheritance argument
Wed, May 16, 8:22 AM
jdenny committed rL332481: [Attr] Don't print fake MSInheritance argument.
[Attr] Don't print fake MSInheritance argument
Wed, May 16, 8:22 AM
jdenny closed D46905: [Attr] Don't print fake MSInheritance argument.
Wed, May 16, 8:22 AM
jdenny committed rL332480: Revert r332474: [Attr] Don't print fake MSInheritance argument.
Revert r332474: [Attr] Don't print fake MSInheritance argument
Wed, May 16, 8:22 AM
jdenny committed rL332474: [Attr] Don't print fake MSInheritance argument.
[Attr] Don't print fake MSInheritance argument
Wed, May 16, 7:55 AM
jdenny committed rC332474: [Attr] Don't print fake MSInheritance argument.
[Attr] Don't print fake MSInheritance argument
Wed, May 16, 7:55 AM
jdenny added a comment to D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

The deprecated enumerator is also referenced by tools/c-index-test/c-index-test.c

Wed, May 16, 7:49 AM

Tue, May 15

jdenny created D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.
Tue, May 15, 5:22 PM
jdenny committed rL332411: [Attr] Don't print implicit attributes.
[Attr] Don't print implicit attributes
Tue, May 15, 3:21 PM
jdenny committed rC332411: [Attr] Don't print implicit attributes.
[Attr] Don't print implicit attributes
Tue, May 15, 3:21 PM
jdenny closed D46894: [Attr] Don't print implicit attributes.
Tue, May 15, 3:21 PM
jdenny created D46905: [Attr] Don't print fake MSInheritance argument.
Tue, May 15, 2:52 PM
jdenny abandoned D46903: [Attr] Don't print attr arg with default value.

After further thought, this patch doesn't seem worthwhile. Sorry for all the noise.

Tue, May 15, 2:52 PM
jdenny added a comment to D46903: [Attr] Don't print attr arg with default value.

I occurs to me now that I could have fixed __single_inheritance by declaring its argument "fake". However, I still prefer the above solution because (1) it should help with any other attributes where arguments should have been declared fake (but no, I haven't identified any yet), and (2) it generally makes attribute printing more succinct, including cases where originally implicit values were printing as explicit. Again, the sacrifice is that some explicit values now print as implicit, but at least the semantics don't change.

Tue, May 15, 2:06 PM
jdenny created D46903: [Attr] Don't print attr arg with default value.
Tue, May 15, 1:31 PM
jdenny created D46894: [Attr] Don't print implicit attributes.
Tue, May 15, 10:26 AM

Mon, May 14

jdenny committed rC332314: [AST] Fix printing tag decl groups in decl contexts.
[AST] Fix printing tag decl groups in decl contexts
Mon, May 14, 5:48 PM
jdenny committed rL332314: [AST] Fix printing tag decl groups in decl contexts.
[AST] Fix printing tag decl groups in decl contexts
Mon, May 14, 5:48 PM
jdenny closed D45465: [AST] Fix printing tag decl groups in decl contexts.
Mon, May 14, 5:48 PM
jdenny added a comment to D45465: [AST] Fix printing tag decl groups in decl contexts.

Looks good, thanks.

Mon, May 14, 5:34 PM
jdenny updated the diff for D45465: [AST] Fix printing tag decl groups in decl contexts.

Made the suggested change. Thanks!

Mon, May 14, 3:49 PM
jdenny committed rC332294: Fix test fail on some buildbots, caused by r332281..
Fix test fail on some buildbots, caused by r332281.
Mon, May 14, 2:09 PM
jdenny committed rL332294: Fix test fail on some buildbots, caused by r332281..
Fix test fail on some buildbots, caused by r332281.
Mon, May 14, 2:09 PM
jdenny added a dependency for D46846: [AST] Fix loss of enum forward decl from decl context: D45465: [AST] Fix printing tag decl groups in decl contexts.
Mon, May 14, 1:42 PM
jdenny added a dependent revision for D45465: [AST] Fix printing tag decl groups in decl contexts: D46846: [AST] Fix loss of enum forward decl from decl context.
Mon, May 14, 1:42 PM
jdenny created D46846: [AST] Fix loss of enum forward decl from decl context.
Mon, May 14, 1:39 PM
jdenny updated the diff for D45465: [AST] Fix printing tag decl groups in decl contexts.

Rebased. Ping.

Mon, May 14, 1:13 PM
jdenny committed rC332281: [AST] Print correct tag decl for tag specifier.
[AST] Print correct tag decl for tag specifier
Mon, May 14, 12:41 PM
jdenny committed rL332281: [AST] Print correct tag decl for tag specifier.
[AST] Print correct tag decl for tag specifier
Mon, May 14, 12:41 PM
jdenny closed D45463: [AST] Print correct tag decl for tag specifier.
Mon, May 14, 12:41 PM
jdenny closed D45463: [AST] Print correct tag decl for tag specifier.
Mon, May 14, 12:41 PM
jdenny committed rL332275: [AST] Fix -ast-print for _Bool when have diagnostics.
[AST] Fix -ast-print for _Bool when have diagnostics
Mon, May 14, 11:45 AM
jdenny committed rC332275: [AST] Fix -ast-print for _Bool when have diagnostics.
[AST] Fix -ast-print for _Bool when have diagnostics
Mon, May 14, 11:45 AM
jdenny closed D45093: [AST] Fix -ast-print for _Bool when have diagnostics.
Mon, May 14, 11:45 AM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Ping.

Mon, May 14, 9:54 AM

Fri, May 11

jdenny added a comment to D45463: [AST] Print correct tag decl for tag specifier.

A few comments ago, I mentioned that IncludeTagDefinition's documentation and name is drifting farther from its functionality. Should we do something about that?

I think we should deprecate that flag, and change it to have no effect. It is an implementation detail of the AST printer and should never have been exposed by libclang in the first place.

Fri, May 11, 4:06 PM
jdenny added a comment to D45463: [AST] Print correct tag decl for tag specifier.

LGTM, thanks!

Fri, May 11, 1:48 PM
jdenny added inline comments to D45463: [AST] Print correct tag decl for tag specifier.
Fri, May 11, 10:35 AM
jdenny updated the diff for D45463: [AST] Print correct tag decl for tag specifier.

Made the suggested changes. Thanks.

Fri, May 11, 10:30 AM

Thu, May 10

jdenny updated the diff for D45463: [AST] Print correct tag decl for tag specifier.

I've implemented the suggestion to use ElaboratedType. See the last paragraph of the revised summary for details.

Thu, May 10, 9:26 AM

Tue, May 8

jdenny updated the diff for D45093: [AST] Fix -ast-print for _Bool when have diagnostics.

Made the suggested changes.

Tue, May 8, 9:45 AM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Works perfectly for me on Win10 / cmd.exe, many thanks for getting that working!

Tue, May 8, 6:46 AM

Mon, May 7

jdenny updated the diff for D44598: [lit] Report line number for failed RUN command.

This fixes windows 10 with cmd.exe for me. If anyone else wants to try it out, that would be great, but it should be ready for a patch review.

Mon, May 7, 7:56 PM
jdenny added a comment to D45093: [AST] Fix -ast-print for _Bool when have diagnostics.

If you want to force a particular printing policy to be used for -ast-print, I think it would be better to change the print call in lib/Frontend/ASTConsumers.cpp to pass your desired printing policy, rather than changing other components to prevent them from changing the ASTContext's default printing policy.

Mon, May 7, 2:07 PM
jdenny added a comment to D45093: [AST] Fix -ast-print for _Bool when have diagnostics.

This approach generally looks good to me, but I'd like @rsmith's opinion on whether we should be trying to make -ast-print have good source fidelity or not. I was under the impression we wanted -ast-print to faithfully reproduce code at least as a low priority desire, but it sounds like it may only be intended as an approximation of the user's source code, so adding extra machinery to support better fidelity may be more maintenance burden than it's worth.

Mon, May 7, 12:18 PM

Thu, May 3

jdenny added inline comments to D45463: [AST] Print correct tag decl for tag specifier.
Thu, May 3, 9:06 PM
jdenny added a comment to D45463: [AST] Print correct tag decl for tag specifier.

TagSpecifierAs expands sizeof(PrintingPolicy) from 8 to 16 bytes. My concern is the comments on PrintingPolicy about how PrintingPolicy is intended to be small. My guess it that 16 bytes is still small enough, but perhaps Richard Smith, who wrote that comment, knows better.

This seems fine. See r270009 for some background for that comment -- we used to store a copy of the LangOptions in the PrintingPolicy (among other things), and copying these objects (including the potentially-large vectors within the LangOptions) was a double-digit percentage of the compile time of some compilations. That's a very different ball park from a change from 8 bytes to 16 bytes.

Thu, May 3, 6:43 PM
jdenny updated the diff for D45463: [AST] Print correct tag decl for tag specifier.

Rebased. Ping.

Thu, May 3, 2:07 PM
jdenny updated the diff for D45093: [AST] Fix -ast-print for _Bool when have diagnostics.

Rebased. Added example to summary. Ping.

Thu, May 3, 1:03 PM
jdenny committed rL331469: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
[OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG
Thu, May 3, 10:26 AM
jdenny committed rL331468: Revert r331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG".
Revert r331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG"
Thu, May 3, 10:26 AM
jdenny committed rC331469: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
[OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG
Thu, May 3, 10:26 AM
jdenny closed D46370: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
Thu, May 3, 10:25 AM
jdenny committed rC331468: Revert r331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG".
Revert r331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG"
Thu, May 3, 10:25 AM
jdenny committed rL331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
[OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG
Thu, May 3, 10:21 AM
jdenny committed rC331466: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
[OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG
Thu, May 3, 10:21 AM

Wed, May 2

jdenny created D46370: [OPENMP] Fix test typos: CHECK-DAG-N -> CHECK-N-DAG.
Wed, May 2, 4:02 PM
jdenny updated the diff for D44598: [lit] Report line number for failed RUN command.

Fixed test failures for windows cmd.exe, hopefully....

Wed, May 2, 2:01 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

I've attempted to replace the ":" command with "echo > null" in the case of windows cmd.exe. I don't build on windows, so someone else will have to try it, or we can let the buildbots tell us if windows is happy now.

The tests work correctly on our setup (Windows 10/Python 3).

Wed, May 2, 7:06 AM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Aaannnddd, I didn't hit save in phabricator sorry, so here are those inline comments.

Wed, May 2, 6:42 AM

Tue, May 1

jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

I've attempted to replace the ":" command with "echo > null" in the case of windows cmd.exe. I don't build on windows, so someone else will have to try it, or we can let the buildbots tell us if windows is happy now.

Tue, May 1, 12:29 PM