Page MenuHomePhabricator

jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (243 w, 19 h)

Recent Activity

Mon, Jun 27

jdenny committed rG0103d4da740c: [Clang][OpenMP] Don't overload "extension" in status doc (authored by jdenny).
[Clang][OpenMP] Don't overload "extension" in status doc
Mon, Jun 27, 3:42 PM · Restricted Project, Restricted Project
jdenny closed D126549: [Clang][OpenMP] Don't overload "extension" in status doc.
Mon, Jun 27, 3:41 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added a comment to D126549: [Clang][OpenMP] Don't overload "extension" in status doc.

Thanks!

Mon, Jun 27, 3:41 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added a comment to D126549: [Clang][OpenMP] Don't overload "extension" in status doc.

Ping.

Mon, Jun 27, 1:06 PM · Restricted Project, Restricted Project, Unknown Object (Project)

May 31 2022

jdenny abandoned D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error.
May 31 2022, 7:35 AM · Restricted Project, Restricted Project

May 30 2022

jdenny committed rG0dbaff2a4922: [FileCheck] Use %ProtectFileCheckOutput in recently added test (authored by jdenny).
[FileCheck] Use %ProtectFileCheckOutput in recently added test
May 30 2022, 1:29 PM · Restricted Project, Restricted Project
jdenny updated the summary of D126673: [FileCheck][NFC] Refactor FileCheckDiag into class hierarchy.
May 30 2022, 12:09 PM · Restricted Project, Restricted Project
jdenny updated the summary of D126673: [FileCheck][NFC] Refactor FileCheckDiag into class hierarchy.
May 30 2022, 12:09 PM · Restricted Project, Restricted Project
jdenny added a comment to D126673: [FileCheck][NFC] Refactor FileCheckDiag into class hierarchy.

Below are some more details that seem worthwhile to capture somewhere
but that seem like too much for the review summary.

May 30 2022, 12:06 PM · Restricted Project, Restricted Project
jdenny requested review of D126673: [FileCheck][NFC] Refactor FileCheckDiag into class hierarchy.
May 30 2022, 12:04 PM · Restricted Project, Restricted Project
jdenny added a comment to D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned.

Thanks for the quick review.

May 30 2022, 8:06 AM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny committed rGd2e3cb737417: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned (authored by jdenny).
[OpenMP][Clang] Fix atomic compare for signed vs. unsigned
May 30 2022, 8:03 AM · Restricted Project, Unknown Object (Project), Restricted Project
jdenny closed D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned.
May 30 2022, 8:03 AM · Restricted Project, Restricted Project, Unknown Object (Project)

May 29 2022

jdenny requested review of D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned.
May 29 2022, 4:22 PM · Restricted Project, Restricted Project, Unknown Object (Project)

May 27 2022

jdenny added a comment to D126547: [OpenACC][OpenMP] Document atomic-in-teams extension.

Thanks for the quick review.

May 27 2022, 3:55 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
jdenny committed rG4a368136693b: [OpenACC][OpenMP] Document atomic-in-teams extension (authored by jdenny).
[OpenACC][OpenMP] Document atomic-in-teams extension
May 27 2022, 3:55 PM · Restricted Project, Unknown Object (Project), Restricted Project
jdenny closed D126547: [OpenACC][OpenMP] Document atomic-in-teams extension.
May 27 2022, 3:54 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
jdenny requested review of D126549: [Clang][OpenMP] Don't overload "extension" in status doc.
May 27 2022, 8:09 AM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny requested review of D126547: [OpenACC][OpenMP] Document atomic-in-teams extension.
May 27 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

May 26 2022

jdenny committed rG48ca3a5ebb15: [OpenMP] Extend omp teams to permit nested omp atomic (authored by jdenny).
[OpenMP] Extend omp teams to permit nested omp atomic
May 26 2022, 11:59 AM · Restricted Project, Unknown Object (Project), Restricted Project
jdenny closed D126323: [OpenMP] Extend omp teams to permit nested omp atomic.
May 26 2022, 11:59 AM · Restricted Project, Restricted Project, Unknown Object (Project)

May 24 2022

jdenny added a comment to D126323: [OpenMP] Extend omp teams to permit nested omp atomic.

Thanks. Will try to push tomorrow.

May 24 2022, 2:50 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny updated the diff for D126323: [OpenMP] Extend omp teams to permit nested omp atomic.

Fixed a bug in the new tests.

May 24 2022, 2:49 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added inline comments to D126323: [OpenMP] Extend omp teams to permit nested omp atomic.
May 24 2022, 2:23 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added inline comments to D126323: [OpenMP] Extend omp teams to permit nested omp atomic.
May 24 2022, 2:03 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny requested review of D126323: [OpenMP] Extend omp teams to permit nested omp atomic.
May 24 2022, 1:35 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 19 2022

jdenny accepted D122569: [lit] Support %if ... %else syntax for RUN lines.

I've made a few requests for minor test and doc extensions, but otherwise this LGTM.

Apr 19 2022, 3:47 PM · Restricted Project, Restricted Project
jdenny added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

While this is not a huge amount of code to be added to lit, I do wonder if we really need it. Wouldn't something like %feature{foo} that expands to 0 or 1 be sufficient? You could then use shell conditionals/test to avoid running lines.
Looking at the examples from D121727, you could do the following:

RUN: if [ %feature{ptxas} -ne 0 ]; then ptxas -c %t-nvptx.ptx -o /dev/null; fi
RUN: test %feature{ptxas} -ne 0 && ptxas -c %t-nvptx.ptx -o /dev/null

The variant with if is probably not going to work on windows.

Apr 19 2022, 3:44 PM · Restricted Project, Restricted Project

Apr 16 2022

jdenny accepted D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array..

LGTM based on your discussion so far with the language committee, but please give Ravi some time to comment.

Apr 16 2022, 6:53 AM · Restricted Project, Unknown Object (Project)

Apr 12 2022

jdenny added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

@asavonic: Thanks for continuing to work on this feature!

Apr 12 2022, 10:47 AM · Restricted Project, Restricted Project

Apr 4 2022

jdenny requested changes to D122569: [lit] Support %if ... %else syntax for RUN lines.

@asavonic: Thanks for working on this. I've pointed out a few issues that need to be discussed before this lands. I also need to make another pass before I'm ready.

Apr 4 2022, 5:18 PM · Restricted Project, Restricted Project

Mar 24 2022

jdenny updated subscribers of D121647: [runtimes] Detect changes to Tests.cmake.

The version of this patch that landed did not fix the openmp problem caused by D121276. I backed it out (locally) and applied the version that I originally tested on 3/15, and all seems fine (that is, check-all includes openmp tests). I'm testing at 3edec279dfa7.

Mar 24 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

jdenny added a comment to D121647: [runtimes] Detect changes to Tests.cmake.

The version of this patch that landed did not fix the openmp problem caused by D121276. I backed it out (locally) and applied the version that I originally tested on 3/15, and all seems fine (that is, check-all includes openmp tests). I'm testing at 3edec279dfa7.

Mar 21 2022, 7:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

I believe that the whole "RUN" line must be handled atomically.

Mar 18 2022, 3:14 PM · Restricted Project, Restricted Project
jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

Of course, this above has a lot of duplicated code, so it might be nice to make the if an if/else ternary-style. Spitball idea:

RUN: ... | FileCheck %s --check-prefix={%if windows {WINDOWS} else {NON-WINDOWS}}

I like this direction as it seems more flexible. Why do we need the outermost braces?

Because the else might be optional, so it clearly delineates the if/else block, as opposed to something using the term "else" immediately after the if part. I'm open to other suggestions on this though.

Mar 18 2022, 3:00 PM · Restricted Project, Restricted Project
jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

Of course, this above has a lot of duplicated code, so it might be nice to make the if an if/else ternary-style. Spitball idea:

RUN: ... | FileCheck %s --check-prefix={%if windows {WINDOWS} else {NON-WINDOWS}}
Mar 18 2022, 2:17 PM · Restricted Project, Restricted Project
jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

when an existing construct (lit substitution) would work easily.

Could you elaborate? Do you mean the substitution of %ptxas with true if it's not available? Something else?

Mar 18 2022, 1:17 PM · Restricted Project, Restricted Project
jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

I've added a few other subscribers that have participated in lit discussions in the past.

Mar 18 2022, 11:03 AM · Restricted Project, Restricted Project
jdenny updated subscribers of D121727: [NVPTX] Integrate ptxas to LIT tests.
Mar 18 2022, 11:02 AM · Restricted Project, Restricted Project
jdenny added a comment to D121276: [CMake] Include runtimes test suites in check-all.

I need LGTM on D121647, would one of you be willing to accept it?

Mar 18 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jdenny added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

I think @jdenny is code owner (or the closest thing) for lit,

Mar 18 2022, 8:57 AM · Restricted Project, Restricted Project

Mar 15 2022

jdenny added a comment to D121276: [CMake] Include runtimes test suites in check-all.

Can you test D121647 to see if it resolves the issue for you?

Mar 15 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

jdenny added a comment to D121276: [CMake] Include runtimes test suites in check-all.

I tested this a bit more and it seems like changes to Tests.cmake aren't picked up by Ninja for some reason. It's not specific only to OpenMP, it seems to be affecting all other runtimes as well. If I manually rerun CMake, the tests are picked up but this should happen automatically.

Mar 14 2022, 1:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

jdenny added a comment to D121276: [CMake] Include runtimes test suites in check-all.

IMHO, check-all should include openmp runtime tests, and this should be fixed. I'm not sure how openmp developers feel.

Mar 11 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jdenny updated subscribers of D121276: [CMake] Include runtimes test suites in check-all.

When building with -DLLVM_ENABLE_RUNTIMES=openmp, this patch causes openmp runtime tests to no longer be included by check-all.

Mar 11 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 13 2021

jdenny added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Regarding the CHECK-ASSERT suggestion, do we need it? I was under the impression one of the earlier patches added a syntax like [[#VAR2, VAR1 + 3:]] or something to that effect, which achieves the same thing, right? Maybe I'm missing something though.

You mean [[#VAR2:VAR1+3]]? Why does that prevent the need for something like CHECK-ASSERT? You still can only refer to a variable defined in an earlier line.

Looking back at the example, I guess it doesn't, although you could use CHECK-SAME to achieve the same effect, I think. More generally, I'm not sure how much I like the idea of checks that don't actually match anything, but I could be persuaded, especially if we can leverage the same functionality to support the CHECK-DEFINE concept I proposed previously (but never got as far as finishing off).

Dec 13 2021, 1:04 PM · Restricted Project

Dec 10 2021

jdenny committed rG51168ce8d574: [OpenMP] Add test for custom state machine if have reduction (authored by jdenny).
[OpenMP] Add test for custom state machine if have reduction
Dec 10 2021, 9:56 AM
jdenny closed D113824: [OpenMP] Add test for custom state machine if have reduction.
Dec 10 2021, 9:56 AM · Restricted Project, Unknown Object (Project)

Dec 9 2021

jdenny added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Hi Joel,

Dec 9 2021, 3:17 PM · Restricted Project
jdenny accepted D115454: [OpenMP] Add "not" to test dependencies..

Other than the question I added inline, LGTM.

Dec 9 2021, 11:11 AM · Unknown Object (Project)

Dec 8 2021

jdenny added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Or maybe a CHECK-ASSERT would be clearer and more generally useful:

Dec 8 2021, 9:47 PM · Restricted Project
jdenny added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

I understand the desire to be able to define and reference a variable within the same directive. However, as I understand it, this patch adds that ability in a way that introduces a new subtlety to FileCheck: the semantics of numeric variable references are then not always consistent. If you assume the wrong semantics, you can end up with a false pass of a test. I understand you've disabled the case of CHECK-NOT, but it does not appear to be the only case that can lead to false passes.

Dec 8 2021, 7:30 PM · Restricted Project

Dec 3 2021

jdenny added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

I've not looked at the testing in depth yet, and I'm a little concerned that I'm very cold on the surrounding code. I think it would be useful if someone else could take a look too (@jdenny maybe?).

Dec 3 2021, 9:57 AM · Restricted Project

Dec 2 2021

jdenny updated the diff for D113824: [OpenMP] Add test for custom state machine if have reduction.

Removed incorrect fix, but kept other changes, as discussed.

Dec 2 2021, 10:50 AM · Restricted Project, Unknown Object (Project)
jdenny added a comment to D113824: [OpenMP] Add test for custom state machine if have reduction.

I didn't see this patch before, sorry.

D114802 was the right fix.

Dec 2 2021, 8:39 AM · Restricted Project, Unknown Object (Project)

Nov 12 2021

jdenny requested review of D113824: [OpenMP] Add test for custom state machine if have reduction.
Nov 12 2021, 9:43 PM · Restricted Project, Unknown Object (Project)
jdenny committed rGc9dfe322eefc: [OpenMP] Fix main thread barrier for Pascal and amdgpu (authored by jdenny).
[OpenMP] Fix main thread barrier for Pascal and amdgpu
Nov 12 2021, 8:20 AM
jdenny closed D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.
Nov 12 2021, 8:19 AM · Restricted Project, Unknown Object (Project)
jdenny retitled D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu from [OpenMP] Fix master thread barrier for Pascal and amdgpu to [OpenMP] Fix main thread barrier for Pascal and amdgpu.
Nov 12 2021, 7:32 AM · Restricted Project, Unknown Object (Project)

Nov 11 2021

jdenny added inline comments to D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.
Nov 11 2021, 8:07 PM · Restricted Project, Unknown Object (Project)
jdenny updated the diff for D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.
  • Addressed @jdoerfert's comments.
  • Updated LLVM :: Transforms/OpenMP tests.
Nov 11 2021, 8:06 PM · Restricted Project, Unknown Object (Project)
jdenny added a comment to D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.

I just noticed that a few LLVM :: Transforms/OpenMP test need to be updated. I'll do that soon.

Nov 11 2021, 4:54 PM · Restricted Project, Unknown Object (Project)
jdenny updated the diff for D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.
  • Applied the same fix to the custom state machine, as suggested by @jdoerfert privately, and extended the new test to cover it. For that test on the NVIDIA Pascals I tried, fixing the custom state machine didn't appear to be needed. Perhaps in that version, the master thread manages to be selected for execution before other threads in its warp. However, fixing the custom state machine did prove important for that test on an AMD GPU I tried. Maybe another test would prove it's important for Pascals too, but I haven't looked for one.
  • Moved fix to callers of generic state machine functions, as suggested by @tianshilei1992.
  • Pointed out this fix is also relevant to AMD GPUs, as suggested by @JonChesterfield.
Nov 11 2021, 4:51 PM · Restricted Project, Unknown Object (Project)

Nov 10 2021

jdenny set the repository for D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu to rG LLVM Github Monorepo.
Nov 10 2021, 12:39 PM · Restricted Project, Unknown Object (Project)
jdenny added a project to D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu: Unknown Object (Project).
Nov 10 2021, 12:38 PM · Restricted Project, Unknown Object (Project)
jdenny requested review of D113602: [OpenMP] Fix main thread barrier for Pascal and amdgpu.
Nov 10 2021, 12:25 PM · Restricted Project, Unknown Object (Project)

Sep 3 2021

jdenny accepted D109255: [NFC][OpenMP] Use clang_cc1 to driver tests.

LGTM. Thanks for the fix.

Sep 3 2021, 1:30 PM · Restricted Project
jdenny added a comment to D109255: [NFC][OpenMP] Use clang_cc1 to driver tests.

This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option.

Better not to do such checks, just need to check that driver correctly translates driver options to the frontend options (using -###), better to use -verify only with the frontend tests. Suggest to rework this test.

Make sense to me. How about we use _cc1 as Alexey suggested here (and rename the file to remove driver- prefix).

Sep 3 2021, 1:26 PM · Restricted Project
jdenny added a comment to D109255: [NFC][OpenMP] Use clang_cc1 to driver tests.

This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option.

OK, I can revert to driver + fsyntax-only if that is preferred?

Sep 3 2021, 12:59 PM · Restricted Project
jdenny added a comment to D109255: [NFC][OpenMP] Use clang_cc1 to driver tests.

This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option.

Sep 3 2021, 12:55 PM · Restricted Project

Sep 1 2021

jdenny committed rG1f9e437065ae: [OpenMP][AMDGPU] Remove unneeded XFAILs (authored by jdenny).
[OpenMP][AMDGPU] Remove unneeded XFAILs
Sep 1 2021, 3:01 PM
jdenny added inline comments to D107925: [OpenMP] Use IsHostPtr where needed for targetDataEnd.
Sep 1 2021, 2:42 PM · Unknown Object (Project)
jdenny committed rG786a14065099: [OpenMP] Use IsHostPtr where needed in rest of omptarget.cpp (authored by jdenny).
[OpenMP] Use IsHostPtr where needed in rest of omptarget.cpp
Sep 1 2021, 2:38 PM
jdenny committed rGd11bab0b73ec: [OpenMP] Use IsHostPtr where needed for targetDataBegin (authored by jdenny).
[OpenMP] Use IsHostPtr where needed for targetDataBegin
Sep 1 2021, 2:38 PM
jdenny committed rGfa6c27550563: [OpenMP][NFC] Eliminate CopyMember from targetDataEnd (authored by jdenny).
[OpenMP][NFC] Eliminate CopyMember from targetDataEnd
Sep 1 2021, 2:38 PM
jdenny committed rG8e4836b2a296: [OpenMP] Use IsHostPtr where needed for targetDataEnd (authored by jdenny).
[OpenMP] Use IsHostPtr where needed for targetDataEnd
Sep 1 2021, 2:38 PM
jdenny closed D107928: [OpenMP] Use IsHostPtr where needed in rest of omptarget.cpp.
Sep 1 2021, 2:38 PM · Unknown Object (Project)
jdenny closed D107927: [OpenMP] Use IsHostPtr where needed for targetDataBegin.
Sep 1 2021, 2:38 PM · Unknown Object (Project)
jdenny closed D107926: [OpenMP][NFC] Eliminate CopyMember from targetDataEnd.
Sep 1 2021, 2:38 PM · Unknown Object (Project)
jdenny closed D107925: [OpenMP] Use IsHostPtr where needed for targetDataEnd.
Sep 1 2021, 2:38 PM · Unknown Object (Project)
jdenny added a comment to D107925: [OpenMP] Use IsHostPtr where needed for targetDataEnd.

Sounds good. I'll work on this today.

Sep 1 2021, 9:11 AM · Unknown Object (Project)
jdenny added a comment to D107925: [OpenMP] Use IsHostPtr where needed for targetDataEnd.

@grokos: Thanks for the reviews. Should I go ahead and land this patch series (D107925, D107926, D107927, D107928) after applying your suggestions, or do you think it would be better to wait for the discussion in D108569 to settle?

Sep 1 2021, 8:56 AM · Unknown Object (Project)

Aug 31 2021

jdenny committed rG1688b4cf8ec3: [OpenMP][AMDGPU] XFAIL test where kernels call printf (authored by jdenny).
[OpenMP][AMDGPU] XFAIL test where kernels call printf
Aug 31 2021, 7:13 PM
jdenny committed rG83ddfa0d2247: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang… (authored by jdenny).
[OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang…
Aug 31 2021, 1:15 PM
jdenny committed rGec1ebcd30258: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime… (authored by jdenny).
[OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime…
Aug 31 2021, 1:15 PM
jdenny closed D106510: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime (2/2).
Aug 31 2021, 1:15 PM · Restricted Project, Unknown Object (Project)
jdenny closed D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).
Aug 31 2021, 1:15 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 27 2021

jdenny accepted D107695: [llvm] [lit] Support forcing lexical test order.

LGTM. Thanks.

Aug 27 2021, 11:28 AM · Restricted Project, Restricted Project
jdenny added a comment to D106510: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime (2/2).

I'll have to work on landing next week when I can watch the bots.

Aug 27 2021, 10:00 AM · Restricted Project, Unknown Object (Project)
jdenny added a comment to D106510: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime (2/2).

Thanks for reviewing.

Aug 27 2021, 9:20 AM · Restricted Project, Unknown Object (Project)

Aug 20 2021

jdenny updated the diff for D106510: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime (2/2).

Rebased. Ping.

Aug 20 2021, 3:14 PM · Restricted Project, Unknown Object (Project)
jdenny updated the diff for D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).

Rebased.

Aug 20 2021, 3:13 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 17 2021

jdenny added inline comments to D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location..
Aug 17 2021, 7:48 PM · Restricted Project
jdenny added a comment to D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location..

Thanks for working on this. I agree there's a bug. However, this patch doesn't fix the bug. It provides a workaround.

Aug 17 2021, 4:23 PM · Restricted Project

Aug 13 2021

jdenny added a comment to D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).

Thanks! I'll wait for the D106510 review before trying to land.

Aug 13 2021, 10:37 AM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny updated the diff for D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).

Updated patch summary to reflect that extensions are now enabled by default.

Aug 13 2021, 8:01 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 12 2021

jdenny added inline comments to D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).
Aug 12 2021, 2:50 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny updated the diff for D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).

Addressed @ABataev's suggestions:

Aug 12 2021, 2:48 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added inline comments to D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2).
Aug 12 2021, 1:20 PM · Restricted Project, Restricted Project, Unknown Object (Project)
jdenny added a comment to D107695: [llvm] [lit] Support forcing lexical test order.

--order is nice.

Aug 12 2021, 12:52 PM · Restricted Project, Restricted Project