Page MenuHomePhabricator

jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (115 w, 1 d)

Recent Activity

Dec 17 2019

jdenny added a comment to D71408: [lit] Remove lit's REQUIRES-ANY directive.

This is embarrassing.

Dec 17 2019, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
jdenny committed rG9658e77e27fa: [lit] Fix internal diff newlines for -w/-b (authored by jdenny).
[lit] Fix internal diff newlines for -w/-b
Dec 17 2019, 7:52 AM
jdenny closed D71577: [lit] Fix internal diff newlines for -w/-b.
Dec 17 2019, 7:52 AM · Restricted Project
jdenny added a comment to D71408: [lit] Remove lit's REQUIRES-ANY directive.

This breaks the lit test suite. llvm/utils/lit/tests/shtest-format.py needs to be updated for the removed tests.

Dec 17 2019, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2019

jdenny added a comment to D71577: [lit] Fix internal diff newlines for -w/-b.

Thanks for the quick review. Will push hopefully tomorrow.

Dec 16 2019, 5:49 PM · Restricted Project
jdenny created D71577: [lit] Fix internal diff newlines for -w/-b.
Dec 16 2019, 3:38 PM · Restricted Project

Dec 12 2019

jdenny added a comment to D71408: [lit] Remove lit's REQUIRES-ANY directive.

I have little experience with REQUIRES, etc., but a quick git grep suggests Paul's suggestion is a reasonable path forward.

Dec 12 2019, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2019

jdenny committed rGfdde18a7c3e5: [FileCheck] Given multiple -dump-input, prefer most verbose (authored by jdenny).
[FileCheck] Given multiple -dump-input, prefer most verbose
Dec 3 2019, 11:29 AM
jdenny closed D70784: [FileCheck] Given multiple -dump-input, prefer most verbose.
Dec 3 2019, 11:29 AM · Restricted Project

Nov 27 2019

jdenny updated the diff for D70784: [FileCheck] Given multiple -dump-input, prefer most verbose.

@probinson : I followed your testing strategy, which I agree is better. Thanks for the quick review!

Nov 27 2019, 3:04 PM · Restricted Project
jdenny created D70784: [FileCheck] Given multiple -dump-input, prefer most verbose.
Nov 27 2019, 7:31 AM · Restricted Project

Nov 21 2019

jdenny committed rGf471eb8e99b5: [FileCheck] Make FILECHECK_OPTS useful for its test suite (authored by jdenny).
[FileCheck] Make FILECHECK_OPTS useful for its test suite
Nov 21 2019, 3:06 PM
jdenny closed D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.
Nov 21 2019, 3:06 PM · Restricted Project
jdenny added a comment to D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc.

This patch handles libgcc_s.so, but what about libatomic.so? It's also not provided by x86_64-linux-gnu, at least on CentOS Linux release 7.7.1908.

Nov 21 2019, 10:04 AM · Restricted Project
jdenny added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

Before proceeding, keep in mind that D54769 is closely related and was reviewed at the same time, so the discussion there should be considered too.

Nov 21 2019, 7:30 AM

Nov 20 2019

Herald added a project to D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc: Restricted Project.
Nov 20 2019, 11:16 AM · Restricted Project

Nov 19 2019

jdenny committed rG6e418decd936: [FileCheck] Use lit's internal shell for the test suite (authored by jdenny).
[FileCheck] Use lit's internal shell for the test suite
Nov 19 2019, 9:20 AM
jdenny closed D70278: [FileCheck] Use lit's internal shell for the test suite.
Nov 19 2019, 9:20 AM · Restricted Project

Nov 18 2019

jdenny committed rGc85fa79d3663: [Attr] Fix `-ast-print` for `asm` attribute (authored by jdenny).
[Attr] Fix `-ast-print` for `asm` attribute
Nov 18 2019, 9:03 AM
jdenny closed D70349: [Attr] Fix `-ast-print` for `asm` attribute.
Nov 18 2019, 9:02 AM · Restricted Project

Nov 17 2019

jdenny updated the summary of D70278: [FileCheck] Use lit's internal shell for the test suite.
Nov 17 2019, 7:10 AM · Restricted Project

Nov 15 2019

jdenny created D70349: [Attr] Fix `-ast-print` for `asm` attribute.
Nov 15 2019, 3:51 PM · Restricted Project

Nov 14 2019

jdenny added a child revision for D70278: [FileCheck] Use lit's internal shell for the test suite: D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.
Nov 14 2019, 2:55 PM · Restricted Project
jdenny added a parent revision for D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite: D70278: [FileCheck] Use lit's internal shell for the test suite.
Nov 14 2019, 2:54 PM · Restricted Project
jdenny created D70278: [FileCheck] Use lit's internal shell for the test suite.
Nov 14 2019, 2:54 PM · Restricted Project
jdenny accepted D70239: Fix up lit's tests to run in a multi-config environment.

LGTM. Thanks!

Nov 14 2019, 9:38 AM · Restricted Project
jdenny added a comment to D70105: [lit] Better/earlier errors for empty runs.

I think it's using utils\lit\tests\lit.site.cfg, which produces the error, when it would normally use utils/lit/tests/Inputs/nonexistent/lit.cfg. Creating even an empty version of that file would probably fix this.

Hmmm then the directory wouldn't be nonexistent...

Nov 14 2019, 7:21 AM · Restricted Project
jdenny added a comment to D70239: Fix up lit's tests to run in a multi-config environment.

What do you think of placing that empty lit.cfg directly within Inputs instead? I think this would generally isolate all Inputs/* test suites from lit/tests/lit.site.cfg and thus avoid such confusion for future tests.

Nov 14 2019, 7:21 AM · Restricted Project

Nov 13 2019

jdenny added a comment to D70105: [lit] Better/earlier errors for empty runs.

I think it's using utils\lit\tests\lit.site.cfg, which produces the error, when it would normally use utils/lit/tests/Inputs/nonexistent/lit.cfg. Creating even an empty version of that file would probably fix this.

Nov 13 2019, 7:06 PM · Restricted Project

Nov 12 2019

jdenny accepted D70105: [lit] Better/earlier errors for empty runs.
Nov 12 2019, 9:04 AM · Restricted Project
jdenny added inline comments to D70105: [lit] Better/earlier errors for empty runs.
Nov 12 2019, 9:04 AM · Restricted Project
jdenny added a comment to D70105: [lit] Better/earlier errors for empty runs.

The number of shards is greater than the number of tests. Currently, this is never an error. Personally, I think we should consider making this an error by default; if this happens, you are doing something wrong. I added a warning but did not change the behavior, since this warrants more discussion.

Nov 12 2019, 8:55 AM · Restricted Project
jdenny added a comment to D70105: [lit] Better/earlier errors for empty runs.
Nov 12 2019, 7:41 AM · Restricted Project

Nov 8 2019

jdenny updated the diff for D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.

Now that D65156 and its many dependencies seem to have survived the bots, I'm finally returning to this patch.

Nov 8 2019, 8:54 AM · Restricted Project
jdenny added a comment to D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.

It appears the last update before today did not add documentation to llvm/docs/TestingGuide.rst as I intended, but today's update did, so that's another new change to look at.

Nov 8 2019, 8:54 AM · Restricted Project
jdenny updated the summary of D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite.
Nov 8 2019, 8:54 AM · Restricted Project

Nov 6 2019

jdenny committed rG6cecd3c3dbef: [lit] Protect full test suite from FILECHECK_OPTS (authored by jdenny).
[lit] Protect full test suite from FILECHECK_OPTS
Nov 6 2019, 1:28 PM

Nov 5 2019

jdenny committed rGf1b4c4bfd0b5: [lit] Fix `not` calling internal commands (authored by jdenny).
[lit] Fix `not` calling internal commands
Nov 5 2019, 11:15 AM
jdenny closed D66531: [lit] Fix `not` calling internal commands.
Nov 5 2019, 11:15 AM · Restricted Project

Nov 1 2019

jdenny updated the diff for D66531: [lit] Fix `not` calling internal commands.
  • Rebased onto recent master.
  • Adjusted tests not to use diff as an example in-process builtin because it's now an out-of-process builtin.
  • Fixed discovery of out-of-process builtins behind not.
Nov 1 2019, 8:21 PM · Restricted Project
jdenny committed rGcb2c4bb0e0da: [lit] Fix internal env calling env (authored by jdenny).
[lit] Fix internal env calling env
Nov 1 2019, 11:18 AM
jdenny closed D65697: [lit] Fix internal env calling env.
Nov 1 2019, 11:16 AM · Restricted Project

Oct 31 2019

jdenny committed rG0d4e6519c5dd: [lit] Fix internal env calling other internal commands (authored by jdenny).
[lit] Fix internal env calling other internal commands
Oct 31 2019, 11:40 AM
jdenny closed D66506: [lit] Fix internal env calling other internal commands.
Oct 31 2019, 11:40 AM · Restricted Project

Oct 29 2019

jdenny committed rG7c1d536c21c7: [lit] Extend internal diff to support `-` argument (authored by jdenny).
[lit] Extend internal diff to support `-` argument
Oct 29 2019, 5:43 PM
jdenny committed rGb163806cdc31: [lit] Make internal diff work in pipelines (authored by jdenny).
[lit] Make internal diff work in pipelines
Oct 29 2019, 5:43 PM

Oct 28 2019

jdenny added a comment to D69207: [lit] Don't fail when printing test output with special chars.

Can you please try adding an errors='ignore' argument to the failing decode call? Or I can push a patch if that's easier. Thanks.

Oct 28 2019, 6:14 AM · Restricted Project

Oct 25 2019

jdenny committed rG27fdf8a29d1e: [lit] Don't fail when printing test output with special chars (authored by jdenny).
[lit] Don't fail when printing test output with special chars
Oct 25 2019, 3:34 PM
jdenny closed D69207: [lit] Don't fail when printing test output with special chars.
Oct 25 2019, 3:34 PM · Restricted Project

Oct 19 2019

jdenny updated the diff for D69207: [lit] Don't fail when printing test output with special chars.

While the test suite was already passing for me in Windows and Ubuntu using either Python 2 or 3, it raised an exception when passing -a to lit (or if the test suite failed and managed to print output containing special characters) in Ubuntu when using Python 2. This change fixes that.

Oct 19 2019, 3:50 PM · Restricted Project

Oct 18 2019

jdenny updated the summary of D66574: [lit] Make internal diff work in pipelines.
Oct 18 2019, 5:00 PM · Restricted Project
jdenny updated the diff for D67643: [lit] Extend internal diff to support `-` argument.

Rebased onto updated D66574.

Oct 18 2019, 4:51 PM · Restricted Project
jdenny added a parent revision for D66574: [lit] Make internal diff work in pipelines: D69207: [lit] Don't fail when printing test output with special chars.
Oct 18 2019, 4:42 PM · Restricted Project
jdenny updated the diff for D66574: [lit] Make internal diff work in pipelines.

Rebased this onto D69207.

Oct 18 2019, 4:42 PM · Restricted Project
jdenny added a child revision for D69207: [lit] Don't fail when printing test output with special chars: D66574: [lit] Make internal diff work in pipelines.
Oct 18 2019, 4:42 PM · Restricted Project
jdenny created D69207: [lit] Don't fail when printing test output with special chars.
Oct 18 2019, 4:32 PM · Restricted Project

Oct 17 2019

jdenny committed rGe96e2d322723: Revert r375114: "[lit] Make internal diff work in pipelines" (authored by jdenny).
Revert r375114: "[lit] Make internal diff work in pipelines"
Oct 17 2019, 7:49 AM
jdenny committed rG5e684e8d88ba: Revert r375116: "[lit] Extend internal diff to support `-` argument" (authored by jdenny).
Revert r375116: "[lit] Extend internal diff to support `-` argument"
Oct 17 2019, 7:49 AM
jdenny committed rL375121: Revert r375114: "[lit] Make internal diff work in pipelines".
Revert r375114: "[lit] Make internal diff work in pipelines"
Oct 17 2019, 7:49 AM
jdenny committed rL375120: Revert r375116: "[lit] Extend internal diff to support `-` argument".
Revert r375116: "[lit] Extend internal diff to support `-` argument"
Oct 17 2019, 7:49 AM
jdenny committed rG849d67a70080: [lit] Extend internal diff to support `-` argument (authored by jdenny).
[lit] Extend internal diff to support `-` argument
Oct 17 2019, 7:02 AM
jdenny committed rG221e418f0c56: [lit] Make internal diff work in pipelines (authored by jdenny).
[lit] Make internal diff work in pipelines
Oct 17 2019, 7:02 AM
jdenny committed rL375114: [lit] Make internal diff work in pipelines.
[lit] Make internal diff work in pipelines
Oct 17 2019, 7:02 AM
jdenny committed rL375116: [lit] Extend internal diff to support `-` argument.
[lit] Extend internal diff to support `-` argument
Oct 17 2019, 7:02 AM

Oct 16 2019

jdenny updated the diff for D67643: [lit] Extend internal diff to support `-` argument.

Rebased onto the most recent D66574.

Oct 16 2019, 5:58 PM · Restricted Project
jdenny updated the diff for D66574: [lit] Make internal diff work in pipelines.

Rebased onto D68839 (recently re-landed). As a result, the diff.py created here has to import lit.util for to_string. The only way I found to make that possible was to set PYTHONPATH in TestRunner.py when calling diff.py.

Oct 16 2019, 5:58 PM · Restricted Project
jdenny committed rGd3dd489b9a6f: [lit] Fix another test case that r374652 missed (authored by jdenny).
[lit] Fix another test case that r374652 missed
Oct 16 2019, 5:01 PM
jdenny committed rL375058: [lit] Fix another test case that r374652 missed.
[lit] Fix another test case that r374652 missed
Oct 16 2019, 5:01 PM
jdenny committed rG6ce2d810320c: [lit] Fix a test case that r374652 missed (authored by jdenny).
[lit] Fix a test case that r374652 missed
Oct 16 2019, 10:56 AM
jdenny committed rL375023: [lit] Fix a test case that r374652 missed.
[lit] Fix a test case that r374652 missed
Oct 16 2019, 10:56 AM
jdenny committed rG2622419c78c2: [lit] Fix internal diff's --strip-trailing-cr and use it (authored by jdenny).
[lit] Fix internal diff's --strip-trailing-cr and use it
Oct 16 2019, 10:28 AM
jdenny committed rGf095b8c425ec: [lit] Clean up internal diff's encoding handling (authored by jdenny).
[lit] Clean up internal diff's encoding handling
Oct 16 2019, 10:28 AM
jdenny committed rL375020: [lit] Fix internal diff's --strip-trailing-cr and use it.
[lit] Fix internal diff's --strip-trailing-cr and use it
Oct 16 2019, 10:28 AM
jdenny committed rL375018: [lit] Clean up internal diff's encoding handling.
[lit] Clean up internal diff's encoding handling
Oct 16 2019, 10:19 AM

Oct 15 2019

jdenny updated the diff for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.

Rebased onto D68664, which I previously forgot this patch requires. Otherwise, when using Windows or when using Python 3, a lit test introduced here fails because it expects \r\n and \n to be different while, when using Windows or Python 3, \r\n is read as \n in text mode. D68664 reads in binary mode and thus prevents that problem.

Oct 15 2019, 5:54 PM · Restricted Project
jdenny added a parent revision for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it: D68664: [lit] Clean up internal diff's encoding handling.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny added a parent revision for D67643: [lit] Extend internal diff to support `-` argument: D66574: [lit] Make internal diff work in pipelines.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny edited child revisions for D68664: [lit] Clean up internal diff's encoding handling, added: 1; removed: 1.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny added a child revision for D66574: [lit] Make internal diff work in pipelines: D67643: [lit] Extend internal diff to support `-` argument.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny removed a parent revision for D67643: [lit] Extend internal diff to support `-` argument: D68664: [lit] Clean up internal diff's encoding handling.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny updated the diff for D68664: [lit] Clean up internal diff's encoding handling.

Rebased onto master so it doesn't depend on D66574 anymore. Thus, it modifies TestRunner.py instead of diff.py.

Oct 15 2019, 5:08 PM · Restricted Project
jdenny removed a child revision for D66574: [lit] Make internal diff work in pipelines: D68664: [lit] Clean up internal diff's encoding handling.
Oct 15 2019, 5:08 PM · Restricted Project
jdenny removed a parent revision for D68664: [lit] Clean up internal diff's encoding handling: D66574: [lit] Make internal diff work in pipelines.
Oct 15 2019, 5:08 PM · Restricted Project

Oct 14 2019

jdenny added a parent revision for D66506: [lit] Fix internal env calling other internal commands: D67643: [lit] Extend internal diff to support `-` argument.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny added a child revision for D67643: [lit] Extend internal diff to support `-` argument: D66506: [lit] Fix internal env calling other internal commands.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny removed a parent revision for D66506: [lit] Fix internal env calling other internal commands: D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny edited child revisions for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it, added: 1; removed: 1.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny added a parent revision for D66574: [lit] Make internal diff work in pipelines: D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny removed a parent revision for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it: D67643: [lit] Extend internal diff to support `-` argument.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny removed a child revision for D67643: [lit] Extend internal diff to support `-` argument: D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.
Oct 14 2019, 6:59 PM · Restricted Project
jdenny updated the diff for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.
  • Added --strip-trailing-cr to another test that needs it.
  • Removed some accidental FileCheck options.
  • Rebased onto master so it doesn't depend on D66574 anymore. Thus, it modifies TestRunner.py instead of diff.py.
Oct 14 2019, 6:50 PM · Restricted Project
jdenny added a parent revision for D66574: [lit] Make internal diff work in pipelines: D68668: [lit] Extend internal diff to support -U.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny removed a parent revision for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it: D68668: [lit] Extend internal diff to support -U.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny added a child revision for D67643: [lit] Extend internal diff to support `-` argument: D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny added a parent revision for D68839: [lit] Fix internal diff's --strip-trailing-cr and use it: D67643: [lit] Extend internal diff to support `-` argument.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny edited child revisions for D68668: [lit] Extend internal diff to support -U, added: 1; removed: 1.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny removed a parent revision for D68668: [lit] Extend internal diff to support -U: D67643: [lit] Extend internal diff to support `-` argument.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny removed a child revision for D67643: [lit] Extend internal diff to support `-` argument: D68668: [lit] Extend internal diff to support -U.
Oct 14 2019, 5:55 PM · Restricted Project
jdenny committed rG7e385bd2f526: [lit] Extend internal diff to support -U (authored by jdenny).
[lit] Extend internal diff to support -U
Oct 14 2019, 1:06 PM
jdenny committed rL374814: [lit] Extend internal diff to support -U.
[lit] Extend internal diff to support -U
Oct 14 2019, 12:57 PM