jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (16 w, 1 d)

Recent Activity

Fri, Feb 16

jdenny added inline comments to D43248: [Attr] Fix printing of parameter indices in attributes.
Fri, Feb 16, 10:30 AM
jdenny added inline comments to D43248: [Attr] Fix printing of parameter indices in attributes.
Fri, Feb 16, 8:55 AM

Thu, Feb 15

jdenny added a comment to D43248: [Attr] Fix printing of parameter indices in attributes.
Thu, Feb 15, 4:13 PM
jdenny added inline comments to D43248: [Attr] Fix printing of parameter indices in attributes.
Thu, Feb 15, 10:09 AM

Wed, Feb 14

jdenny added a comment to D43204: [OpenMP] Fix trailing space when printing pragmas.

LG

Wed, Feb 14, 8:57 AM

Tue, Feb 13

jdenny created D43248: [Attr] Fix printing of parameter indices in attributes.
Tue, Feb 13, 10:58 AM

Mon, Feb 12

jdenny created D43204: [OpenMP] Fix trailing space when printing pragmas.
Mon, Feb 12, 12:04 PM

Jan 9 2018

jdenny added a comment to D41841: [OpenMP] Fix handling of clause on wrong directive.

Alexey: Thanks for accepting. I do not have commit privileges. Would
you please commit for me?

Jan 9 2018, 10:59 AM

Jan 8 2018

jdenny created D41841: [OpenMP] Fix handling of clause on wrong directive.
Jan 8 2018, 3:45 PM

Dec 15 2017

jdenny added a comment to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

LGTM

Dec 15 2017, 6:43 AM
jdenny added inline comments to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
Dec 15 2017, 3:51 AM
jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
  1. Use std::binary_search, as suggested by Hal.
Dec 15 2017, 3:48 AM

Dec 8 2017

jdenny added a comment to D40995: [TextDiagnosticBuffer] Fix diagnostic note emission order..

Hi Richard. Thanks for accepting. I don't have commit privileges. Would you please commit for me?

Dec 8 2017, 7:38 PM

Dec 7 2017

jdenny added a dependency for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>: D40995: [TextDiagnosticBuffer] Fix diagnostic note emission order..
Dec 7 2017, 6:50 PM
jdenny added a dependent revision for D40995: [TextDiagnosticBuffer] Fix diagnostic note emission order.: D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
Dec 7 2017, 6:50 PM
jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

This update does the following:

Dec 7 2017, 6:47 PM
jdenny created D40995: [TextDiagnosticBuffer] Fix diagnostic note emission order..
Dec 7 2017, 6:39 PM
jdenny added a comment to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

I've not done a detailed review of the string manipulation here, but this looks like a great feature, thanks!

Dec 7 2017, 6:19 PM
jdenny added a comment to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

I marked the comments related to Hal's suggestions as done to avoid confusion for future reviews. I'm not used to using this sort of tool for reviews. Hopefully it's appropriate for the author to do that rather than the reviewer.

Dec 7 2017, 6:17 PM
jdenny abandoned D40752: [OpenMP] Fix assert fail after target implicit map checks.
Dec 7 2017, 9:53 AM
jdenny added a comment to D40752: [OpenMP] Fix assert fail after target implicit map checks.

Alexey: I see that you committed the error message change, so I think this issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new here.

Dec 7 2017, 9:40 AM

Dec 5 2017

jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

This update includes all of Hal's suggestions.

Dec 5 2017, 4:03 PM
jdenny added a comment to D40752: [OpenMP] Fix assert fail after target implicit map checks.

r319774 works for my current use cases. Thanks.

While we're on this topic, do you happen to know the rationale behind the OpenMP restriction for which err_omp_union_type_not_allowed diagnoses violations? I googled but couldn't find the rationale. If you would prefer that I ask this in a different forum, would you please suggest one? Thanks.

You cannot map the member of the union, but you can map the whole union. Mapping of separate members is not allowed because you will definitely have troubles with overlapping memory for union members.

Thanks for that clarification. Is there any way to word the error message "mapped storage cannot be derived from a union" to make this point clearer? I'm thinking "an individual member of" instead of "derived from" would help. Does that work ok?

You can try it now, there should no more error messages

Yes. Thanks.

I agree, that error message does not sound quite good. Maybe, mapping of union members is not allowed?

Dec 5 2017, 1:45 PM
jdenny added a comment to D40752: [OpenMP] Fix assert fail after target implicit map checks.

r319774 works for my current use cases. Thanks.

While we're on this topic, do you happen to know the rationale behind the OpenMP restriction for which err_omp_union_type_not_allowed diagnoses violations? I googled but couldn't find the rationale. If you would prefer that I ask this in a different forum, would you please suggest one? Thanks.

You cannot map the member of the union, but you can map the whole union. Mapping of separate members is not allowed because you will definitely have troubles with overlapping memory for union members.

Dec 5 2017, 1:21 PM
jdenny added a comment to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
Dec 5 2017, 12:43 PM
jdenny added a comment to D40752: [OpenMP] Fix assert fail after target implicit map checks.

r319774 works for my current use cases. Thanks.

Dec 5 2017, 9:30 AM
jdenny added a comment to D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

I think this is a good idea.

Dec 5 2017, 8:19 AM

Dec 1 2017

jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.

Rebased on master/trunk fetched today.

Dec 1 2017, 2:14 PM
jdenny updated subscribers of D40752: [OpenMP] Fix assert fail after target implicit map checks.
Dec 1 2017, 1:36 PM
jdenny created D40752: [OpenMP] Fix assert fail after target implicit map checks.
Dec 1 2017, 1:35 PM

Nov 15 2017

jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
  1. Capitalized some of the new local variables according to coding standards.
Nov 15 2017, 8:33 AM

Nov 10 2017

jdenny added a comment to D39859: [OpenMP] diagnose assign to firstprivate const.

Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me?

Nov 10 2017, 7:10 AM

Nov 9 2017

jdenny updated the diff for D39859: [OpenMP] diagnose assign to firstprivate const.

Hi Alexey. Thanks for your comments. This update should address them all.

Nov 9 2017, 1:57 PM
jdenny added a reviewer for D39859: [OpenMP] diagnose assign to firstprivate const: ABataev.
Nov 9 2017, 12:06 PM
jdenny created D39859: [OpenMP] diagnose assign to firstprivate const.
Nov 9 2017, 12:05 PM

Nov 8 2017

jdenny updated the diff for D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
  1. Extended -verify to accept multiple prefixes, like FileCheck's --check-prefixes.
Nov 8 2017, 3:56 PM

Nov 6 2017

jdenny created D39694: [VerifyDiagnosticConsumer] support -verify=<prefixes>.
Nov 6 2017, 1:00 PM