jdenny (Joel E. Denny)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2017, 3:15 PM (46 w, 4 d)

Recent Activity

Aug 9 2018

jdenny added inline comments to D50485: [lit] Add LIT_DEBUG environment variable to support passing options though ninja.
Aug 9 2018, 12:48 PM
jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

LIT_DEBUG=2: FileCheck is passed -v

In order to support this, can you post a new patch updating this one to have a default of verbose to be set via an environment variable? (FILECHECK_VERBOSE?)

Aug 9 2018, 12:45 PM

Jul 27 2018

jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

Default: same as now

LIT_DEBUG=1: LIT is passed -vv
LIT_DEBUG=2: FileCheck is passed -v
LIT_DEBUG=3: FileCheck is passed FILECHECK_VERBOSE (dumps all input on failure), plus same as above
Jul 27 2018, 11:32 AM

Jul 20 2018

jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

@jdenny Right, I see now!
So my point was that instead of having many different "better-debug" flags, maybe it's better to have one, and just call it "VERBOSE", or similar.

Jul 20 2018, 4:55 PM
jdenny updated the diff for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

Ping. Rebased.

Jul 20 2018, 3:46 PM
jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

lit runs only

Yeah, that's why I have originally created the LIT_FILTER variable.

LIT_FLAGS would work too, right?

Does this variable exist? I've just grepped through LIT source and have not seen it.

Jul 20 2018, 2:51 PM
jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

@jdenny The precedence should always be given to command line flags, since that's what was specified explicitly vs. lingering in the environment.

Jul 20 2018, 2:31 PM
jdenny added a comment to D47114: [FileCheck] Implement -v and -vv for tracing matches.

@dblaikie @probinson @jdenny In practice it seems hard to modify a command line arg for FileCheck, since it requires changing all tests.
I recently did a similar option in https://reviews.llvm.org/D49328, but used an environment variable instead.
Independently, lit has -v and -vv options which are also hard to set through the ninja invocation.

Should we try to standardize on an environment variable, e.g. DEBUG=1/2/3/4? Ideally, it could be done automatically when the user does ninja -v, but AFAIK it does not set any environment variable which could be set from LIT.

Jul 20 2018, 1:55 PM
jdenny committed rL337605: [FileCheck] Fix search ranges for DAG-NOT-DAG.
[FileCheck] Fix search ranges for DAG-NOT-DAG
Jul 20 2018, 1:15 PM
jdenny closed D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG.
Jul 20 2018, 1:15 PM
jdenny added a comment to D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG.

Sorry, lost track of this one. One comment suggestion and LGTM.

Jul 20 2018, 12:44 PM
jdenny updated the diff for D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG.

Ping. Rebased.

Jul 20 2018, 10:06 AM

Jul 19 2018

jdenny committed rCRT337521: [libFuzzer] Use separate test directory for each config.
[libFuzzer] Use separate test directory for each config
Jul 19 2018, 7:44 PM
jdenny committed rL337521: [libFuzzer] Use separate test directory for each config.
[libFuzzer] Use separate test directory for each config
Jul 19 2018, 7:44 PM
jdenny closed D49249: [libFuzzer] Use separate test directory for each config.
Jul 19 2018, 7:44 PM
jdenny updated the summary of D49249: [libFuzzer] Use separate test directory for each config.
Jul 19 2018, 11:11 AM
jdenny updated the diff for D49249: [libFuzzer] Use separate test directory for each config.

Removed config.test_exec_root, which is unique to each config by default.

Jul 19 2018, 10:51 AM
jdenny added a comment to D49249: [libFuzzer] Use separate test directory for each config.

The other test configs don't define config.test_exec_root at all. Do we need it?

Jul 19 2018, 10:47 AM

Jul 12 2018

jdenny committed rL336967: [FileCheck] Implement -v and -vv for tracing matches.
[FileCheck] Implement -v and -vv for tracing matches
Jul 12 2018, 8:13 PM
jdenny closed D47114: [FileCheck] Implement -v and -vv for tracing matches.
Jul 12 2018, 8:13 PM
jdenny created D49249: [libFuzzer] Use separate test directory for each config.
Jul 12 2018, 9:44 AM

Jul 11 2018

jdenny committed rL336859: [FileCheck] Add -allow-deprecated-dag-overlap to another compiler-rt test.
[FileCheck] Add -allow-deprecated-dag-overlap to another compiler-rt test
Jul 11 2018, 3:12 PM
jdenny committed rCRT336859: [FileCheck] Add -allow-deprecated-dag-overlap to another compiler-rt test.
[FileCheck] Add -allow-deprecated-dag-overlap to another compiler-rt test
Jul 11 2018, 3:12 PM
jdenny committed rT336854: [FileCheck] Add -allow-deprecated-dag-overlap to failing test-suite tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing test-suite tests
Jul 11 2018, 3:11 PM
jdenny committed rL336854: [FileCheck] Add -allow-deprecated-dag-overlap to failing test-suite tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing test-suite tests
Jul 11 2018, 2:22 PM
jdenny committed rL336848: finish: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.
finish: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests
Jul 11 2018, 1:36 PM
jdenny committed rL336847: [FileCheck] Don't permit overlapping CHECK-DAG.
[FileCheck] Don't permit overlapping CHECK-DAG
Jul 11 2018, 1:32 PM
jdenny committed rL336846: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests
Jul 11 2018, 1:32 PM
jdenny closed D49192: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests.
Jul 11 2018, 1:32 PM
jdenny committed rL336845: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests
Jul 11 2018, 1:32 PM
jdenny committed rCRT336845: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests
Jul 11 2018, 1:32 PM
jdenny closed D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
Jul 11 2018, 1:32 PM
jdenny committed rL336844: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests
Jul 11 2018, 1:32 PM
jdenny committed rC336844: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests
Jul 11 2018, 1:31 PM
jdenny closed D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.
Jul 11 2018, 1:31 PM
jdenny committed rL336843: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.
[FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests
Jul 11 2018, 1:31 PM
jdenny closed D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.
Jul 11 2018, 1:30 PM
jdenny committed rL336833: Revert r336830: [FileCheck] Don't permit overlapping CHECK-DAG.
Revert r336830: [FileCheck] Don't permit overlapping CHECK-DAG
Jul 11 2018, 12:08 PM
jdenny committed rL336830: [FileCheck] Don't permit overlapping CHECK-DAG.
[FileCheck] Don't permit overlapping CHECK-DAG
Jul 11 2018, 11:48 AM
jdenny closed D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Jul 11 2018, 11:48 AM
jdenny added a dependent revision for D49192: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests: D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Jul 11 2018, 9:05 AM
jdenny added a dependency for D47106: [FileCheck] Make CHECK-DAG non-overlapping: D49192: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests.
Jul 11 2018, 9:05 AM
jdenny created D49192: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests.
Jul 11 2018, 8:34 AM
jdenny updated the diff for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.

Rebased. There's 1 new test requiring -allow-deprecated-dag-overlap.

Jul 11 2018, 8:27 AM

Jul 10 2018

jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

The mechanical changes to the tests are actually pretty easy to skim through, given the way Phabricator's web interface does change highlighting. The three you cited are all fine.

Jul 10 2018, 8:14 AM
jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

Given that you feel so very strongly about it, and that this is a tool that really has absolutely zero exposure outside our own test system, I'm willing to say that erring on the side of extra testing is acceptable here.

Jul 10 2018, 7:34 AM
jdenny accepted D48842: [llvm] Document "%T" as deprecated in CommandGuide/lit.rst.
Jul 10 2018, 7:04 AM

Jul 5 2018

jdenny updated the diff for D47114: [FileCheck] Implement -v and -vv for tracing matches.

This updates -v to make more sense in the case of the new CHECK-EMPTY directive. Without this update, -v reported the match for CHECK-EMPTY as occurring at the preceding newline. That's confusing, especially if the preceding line was also empty because it then seemed like the expected empty line was the preceding line instead. Because CHECK-EMPTY is conceptually a CHECK-NEXT for an empty line, -v now reports the match as occurring after the preceding newline, just as it does for CHECK-NEXT. That is, as for CHECK-NEXT, the match range starts at the empty line, and there is a constraint that there is one preceding newline in the search range.

Jul 5 2018, 1:44 PM
jdenny added a dependency for D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG: D47114: [FileCheck] Implement -v and -vv for tracing matches.
Jul 5 2018, 12:04 PM
jdenny added a dependent revision for D47114: [FileCheck] Implement -v and -vv for tracing matches: D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG.
Jul 5 2018, 12:04 PM
jdenny created D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG.
Jul 5 2018, 12:03 PM
jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

At that point, I think the behavior becomes tractable. The first DAG group finds what it finds, the NOT forces no reordering therefore the second DAG group's range starts at the endpoint of the first group's matches. After the second DAG group runs, the NOT's range is from the endpoint of the first group's matches to the earliest of the second group's matches.

How does that all sound?

The main question remaining for me is about the start of the second DAG group's match range and thus whether reordering detection happens.

Jul 5 2018, 9:27 AM

Jul 3 2018

jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Jul 3 2018, 3:13 PM
jdenny added inline comments to D47106: [FileCheck] Make CHECK-DAG non-overlapping.
Jul 3 2018, 1:51 PM
jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

Regarding the DAG-NOT-DAG reordering diagnostic: Rereading the comments, and the llvm-dev discussion, are we agreed that we can eliminate it? That is, the first DAG group defines some match range, the second DAG group defines a disjoint match range, and the NOT group looks at the text from the end of the first match range to the start of the second match range. No attempt to diagnose ordering problems.

Jul 3 2018, 11:02 AM
jdenny updated the diff for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

Ping. Rebased.

Jul 3 2018, 9:38 AM

Jul 2 2018

jdenny updated the diff for D47114: [FileCheck] Implement -v and -vv for tracing matches.

Rebased.

Jul 2 2018, 8:02 PM
jdenny updated the diff for D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.

Rebased.

Jul 2 2018, 1:08 PM
jdenny updated the diff for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.

Rebased. There are 5 new tests requiring -allow-deprecated-dag-overlap.

Jul 2 2018, 1:06 PM
jdenny updated the diff for D47106: [FileCheck] Make CHECK-DAG non-overlapping.

Rebased. The number of tests broken by this change in functionality continues to grow. Can we move forward?

Jul 2 2018, 1:04 PM
jdenny added inline comments to D48842: [llvm] Document "%T" as deprecated in CommandGuide/lit.rst.
Jul 2 2018, 12:33 PM
jdenny added a comment to D48189: [llvm] Document "%T" as deprecated in TestingGuide.rst.

%T should also be deprecated (or removed) below, where it's documented incorrectly:

Jul 2 2018, 9:37 AM

Jun 28 2018

jdenny committed rL335911: [OPENMP] Fix incomplete type check for array reductions.
[OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:59 PM
jdenny committed rC335911: [OPENMP] Fix incomplete type check for array reductions.
[OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:59 PM
jdenny closed D48735: [OPENMP] Fix incomplete type check for array reductions.
Jun 28 2018, 12:59 PM
jdenny committed rL335910: Revert r335907: [OPENMP] Fix incomplete type check for array reductions.
Revert r335907: [OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:59 PM
jdenny committed rC335910: Revert r335907: [OPENMP] Fix incomplete type check for array reductions.
Revert r335907: [OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:59 PM
jdenny committed rL335907: [OPENMP] Fix incomplete type check for array reductions.
[OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:50 PM
jdenny committed rC335907: [OPENMP] Fix incomplete type check for array reductions.
[OPENMP] Fix incomplete type check for array reductions
Jun 28 2018, 12:50 PM
jdenny created D48735: [OPENMP] Fix incomplete type check for array reductions.
Jun 28 2018, 12:04 PM

Jun 19 2018

jdenny updated the diff for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition.

Rebased. Ping.

Jun 19 2018, 2:30 PM

Jun 18 2018

jdenny updated the diff for D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests.

Rebased. Two more tests are affected:

Jun 18 2018, 2:57 PM
jdenny updated the diff for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests.

Rebased.

Jun 18 2018, 2:53 PM

May 30 2018

jdenny committed rL333630: [lit] Fix windows cmd.exe test config for r333620.
[lit] Fix windows cmd.exe test config for r333620
May 30 2018, 10:52 PM
jdenny committed rL333620: [lit] Terminate ": RUN at line N" with ";" not "&&".
[lit] Terminate ": RUN at line N" with ";" not "&&"
May 30 2018, 8:45 PM
jdenny committed rL333614: [lit] Report line number for failed RUN command.
[lit] Report line number for failed RUN command
May 30 2018, 5:59 PM
jdenny committed rL333592: Revert r333584: [lit] Report line number for failed RUN command.
Revert r333584: [lit] Report line number for failed RUN command
May 30 2018, 2:11 PM
jdenny committed rL333584: [lit] Report line number for failed RUN command.
[lit] Report line number for failed RUN command
May 30 2018, 12:46 PM
jdenny closed D44598: [lit] Report line number for failed RUN command.
May 30 2018, 12:46 PM
jdenny committed rL333574: [AST] Fix loss of enum forward decl from decl context.
[AST] Fix loss of enum forward decl from decl context
May 30 2018, 11:38 AM
jdenny committed rC333574: [AST] Fix loss of enum forward decl from decl context.
[AST] Fix loss of enum forward decl from decl context
May 30 2018, 11:38 AM
jdenny closed D46846: [AST] Fix loss of enum forward decl from decl context.
May 30 2018, 11:38 AM

May 29 2018

jdenny updated the diff for D46846: [AST] Fix loss of enum forward decl from decl context.

Rebased. Ping.

May 29 2018, 7:33 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Would there be any harm in committing this patch as is? If we decide to remove all support for windows cmd.exe, that should be a separate patch anyway.

May 29 2018, 5:46 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

A high level question. Why are we even testing using cmd.exe with an external shell? IIRC that's not a use case LLVM uses for Windows. Instead
the internal shell is used on Windows. Is this (cmd.exe as an external shell) really something we want to support? I don't see anything desirable about supporting cmd.exe as an
external shell because that means it can be very easy to write non-portable shell tests.

I'm not a windows developer. I fixed that because others reverted my patch when it broke windows buildbots. Someone else will have to answer. Here's the bugzilla, in case that helps:

https://bugs.llvm.org/show_bug.cgi?id=37239

May 29 2018, 2:00 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Ping.

What seems to be the problem?
This was accepted before, reverted due to windows bot breakage,
https://reviews.llvm.org/D44598#1091098 suggests that breakage is fixed.
Just commit again?

There was enough of a code change that I thought the reviewer would want to take another look. Is that not the right approach?

A high level question. Why are we even testing using cmd.exe with an external shell? IIRC that's not a use case LLVM uses for Windows. Instead
the internal shell is used on Windows. Is this (cmd.exe as an external shell) really something we want to support? I don't see anything desirable about supporting cmd.exe as an
external shell because that means it can be very easy to write non-portable shell tests.

May 29 2018, 1:31 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Ping.

What seems to be the problem?
This was accepted before, reverted due to windows bot breakage,
https://reviews.llvm.org/D44598#1091098 suggests that breakage is fixed.
Just commit again?

May 29 2018, 1:17 PM
jdenny added a comment to D44598: [lit] Report line number for failed RUN command.

Ping.

May 29 2018, 1:05 PM

May 24 2018

jdenny set the repository for D44598: [lit] Report line number for failed RUN command to rL LLVM.
May 24 2018, 12:36 PM
jdenny set the repository for D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition to rC Clang.
May 24 2018, 12:35 PM
jdenny set the repository for D46846: [AST] Fix loss of enum forward decl from decl context to rC Clang.
May 24 2018, 12:35 PM
jdenny set the repository for D47106: [FileCheck] Make CHECK-DAG non-overlapping to rL LLVM.
May 24 2018, 12:34 PM
jdenny set the repository for D47171: [FileCheck] Add -allow-deprecated-dag-overlap to failing llvm tests to rL LLVM.
May 24 2018, 12:33 PM
jdenny set the repository for D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests to rC Clang.
May 24 2018, 12:33 PM
jdenny set the repository for D47114: [FileCheck] Implement -v and -vv for tracing matches to rL LLVM.
May 24 2018, 12:32 PM
jdenny set the repository for D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests to rCRT Compiler Runtime.
May 24 2018, 7:17 AM
jdenny added a dependent revision for D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests: D47106: [FileCheck] Make CHECK-DAG non-overlapping.
May 24 2018, 7:09 AM
jdenny added a dependency for D47106: [FileCheck] Make CHECK-DAG non-overlapping: D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
May 24 2018, 7:09 AM
jdenny created D47326: [FileCheck] Add -allow-deprecated-dag-overlap to failing compiler-rt tests.
May 24 2018, 7:09 AM

May 23 2018

jdenny added a comment to D47106: [FileCheck] Make CHECK-DAG non-overlapping.

(Replying here instead of inline as the thread is getting kind of long.)

Sorry, I didn't realize FileCheck would try to detect and explicitly diagnose reordering DAG across NOT. That seems like more trouble than it's worth. NOT is documented to enforce ordering, and we can make it just do that, and if you mess up then your test fails by not matching rather than telling you something is in the wrong order. (Then you can use -v or -vv to work out what happened, if you need to.)

Once we define the DAGs as separated into distinct groups by a NOT, I think it's conceptually straightforward to say each DAG group has a "matching range" from the start of the earliest match to the end of the latest match. Two DAG groups can't have overlapping match ranges (just like you are making individual DAG matches not overlap).

May 23 2018, 3:45 PM